Path: csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From: Vincent Bernat <bernat@debian.org>
Newsgroups: linux.debian.maint.python
Subject: Re: Searching for sponsor and critique
Date: Sun, 09 Aug 2015 15:40:02 +0200
Message-ID: <pVyZs-7vr-15@gated-at.bofh.it>
References: <pU4TL-85f-15@gated-at.bofh.it> <pUAgZ-3gz-77@gated-at.bofh.it> <pUXZT-4jZ-3@gated-at.bofh.it> <pVxAl-5ye-1@gated-at.bofh.it>
Old-Return-Path: <bernat@debian.org>
Organization: Debian
Mail-Followup-To: debian-python@lists.debian.org
User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature"
Approved: robomod@news.nic.it
Lines: 56
Sender: robomod@news.nic.it
Xref: csiph.com linux.debian.maint.python:7172

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

 =E2=9D=A6  9 ao=C3=BBt 2015 13:46 +0200, Lennart Weller <lhw@ring0.de>=C2=
=A0:

>> Everything looks good except the LICENSE.txt which is not here. It is in
>> fact called LICENSE upstream and it should be added to the manifest to
>> be present in the tarball. A note to upstream would be nice. Add a
>> comment to debian/copyright pointing to the appropriate URL to find the
>> license. As it is present in debian/copyright, you don't have to add a
>> special patch or anything like that.
>
> What do you mean here? The LICENSE file is part of the git repo on
> Github but not in the tarball on PyPI which is the base of the package.
> Also the machine-readable copyright file basically includes the same
> license and copyright notice as the LICENSE file from the git repo.

Yes. I just said exactly that, didn't I?

I also propose that you add a small comment in debian/copyright
explaining that the license is not present in the tarball (which is a
bug, upstream should add it to MANIFEST.in) but can be checked on
GitHub.
=2D-=20
Don't use conditional branches as a substitute for a logical expression.
            - The Elements of Programming Style (Kernighan & Plauger)

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVx1aWAAoJEJWkL+g1NSX5Q98P/2AsC8CPfqe0VgWPXtK63uN6
h/uLAVSg+Vw3/EGlS1d9GkRduZdM2wfEvrv40hnYLdEmOyAJxONW2fL+FfOKO4g/
ztbx63GHpOjhjDoPssc4WSXnQFglLq5A1MM+ptDd2HonX3pvwsPvq2z27Mlpuma0
fjR5Ip36ZCXMmKBgsZMxaWKJvHtX/GYl4rnQVkvDHD/vyWId626atd+YrNuHtlU+
EJnCCQdRVt2/Slirs3HsQpeLuuEkyEls/ZMVytVChMo9PLoNwkOqxf80CLBbVw0F
S1aUvhMLEfCHyCSRnupTAPcD79+frpUzK56iPVLMnxbuedkVt4wiSVZL8jKUSQzy
BwqDf4CNmg1MzAWrvEIXAM1fw4zm6eAYZqz5hURixCp1TOJIMEEzfNM9ELmamgRY
ozgrk7J6GS7e1bs+bcU5vhEeljrP1XG6k0UkUjJnGJlyXZ6v1DcTMZ8Hp7K2sZ1z
YRLZ1689P03Z2k0k1EmZh5SllBvbntXpNMhL2vRqUOvWJQnoptLkSAbPjz7L06QB
qwjJVSkPUvh0aA8lsV6+F0gRHMX09m+w10EIg1X7ikGU0+MsXHSXtb2vtTO0dhd/
TfgGHyoCYRzFv5O+8DetHEoobsi2LnIj5NS+Ue8A3Dzr7WhGp8xJkVVV6rWP60oV
i6hOGaVRqzbf+YXyuiaB
=e10B
-----END PGP SIGNATURE-----
--=-=-=--


-- 
To UNSUBSCRIBE, email to debian-python-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: https://lists.debian.org/m3r3nch9ih.fsf@neo.luffy.cx