Path: csiph.com!weretis.net!feeder8.news.weretis.net!news.nntp4.net!news.hispagatos.org!srl.newsdeef.eu!news.corradoroberto.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: review for audio-visualizer-python/2.2.4-1 Date: Fri, 06 Mar 2026 13:20:01 +0100 Message-ID: X-Mailbox-Line: From debian-python-request@lists.debian.org Fri Mar 6 12:11:00 2026 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.41 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/UWYd0oFX5yhMxBVjCFS9PcX"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23684 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20260306121025.32bd5e0f@debian.org Approved: robomod@news.nic.it Lines: 78 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Fri, 6 Mar 2026 12:10:25 -0000 X-Original-Message-ID: <20260306121025.32bd5e0f@debian.org> Xref: csiph.com linux.debian.maint.python:17422 --Sig_/UWYd0oFX5yhMxBVjCFS9PcX Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable hi Aeliton, I reviewed the audio-visualizer-python package, up for sponsorship in the Python team: * patches: 0003 seems to serve no other purpose than deleting a file. You don't want to use patches for that. To prevent that license file from getting installed, please use some other method with a much smaller footprint, such as overriding dh_install to exclude the file from install, or removing it after the install step in an override_after_ stanza. * rules: why is test_comp_spectrum_previewRender getting deselected? I can see it failed on i386 on the CI, but there could be a number of reasons for that. Was the cause for the failure investigated? Is the test itself buggy or does it correctly identify a bug in upstream code? Was the issue reported upstream? Adding an explanatory comment alongside the relevant setting in d/rules can be very helpful to provide a bit of context. For reference, the relevant part of the CI log: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D FAILURES =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D _______________________ test_comp_spectrum_previewRender ________________= _______ coreWithSpectrumComp =3D Component(module 5, pos 0) () Name: Spectrum v1 Preset: {'ampl...irror': False, 'mode': 0, 'mono': False, 'scale': 100, 'tc': 0.017, 'window': 0, 'x': 0.0, 'y': 0.0, 'zoom': 1} def test_comp_spectrum_previewRender(coreWithSpectrumComp): comp =3D coreWithSpectrumComp.selectedComponents[0] image =3D comp.previewRender() > assert imageDataSum(image) =3D=3D 71992628 E assert np.int32(71993239) =3D=3D 71992628 E + where np.int32(71993239) =3D imageDataSum() tests/test_comp_spectrum.py:24: AssertionError Once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail. --Sig_/UWYd0oFX5yhMxBVjCFS9PcX Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmmqxDEACgkQQoMEoXSN zHoLPRAAvjJNwGqFcoiJS1NNYEBNm0EeN+aO1GWemypWwuf5xrSlGL5yFR/IEyyB 02xzTbvP/Gk0RJd1mDmS/Hujjz/YFywWtO7qb7PCn7MPQFbFlv6Z4SgK94IUqsyd c2bRRdrx81caiXkc5qZQvILNyXaFTp2tIYILzNtHpQOtxzu2GBKfxPBQIckU9clw nzosB2zxwG3dyZ3+zblkHxfagr1oPqNlbS2Bg2RSEVO0MxFr2nlATwGshrJCQWL9 vCofMEon/9Yt0insCc2r8dulu5YO9BghCDZbLRDFsd1w9vVRy/Q9Y+xuhKmdjj0q 5wuVBnll07izIo8dbPG/SiQ+Dyh7e91gYfW0JL0tdoOBXYku80s9AJGsJPfRGjh2 d1B9uWcx/DkH3IT0Ag/it5+d1mLH9H++sVIBP4RbFcISgK1ACK331m7iTETeZknP vsejOkGBCXlZwQaKiGnI7BU4eyUz+ijQWiew1DnDI2cR4//DY6zjpShx+ME6LzSJ FHGFCGGfBchIwq3lVeKSRNmDS2coFYzefc5+EU0s7WFBUf4KlMXUxElGn9Kbuy02 GiI7JwakanNF8+OFCyWX+pI307sJ5Djm3nKvaEQNd2/i+EBCvo4qxFNQl/C7Ith2 3SMZ9mBqUgdlcNjfQ0IcmYiC6zOBp89PaWaeATHtkpgprokAFp8= =vA4k -----END PGP SIGNATURE----- --Sig_/UWYd0oFX5yhMxBVjCFS9PcX--