Path: csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: Re: Sponsorship Request: ITP: python-pykakasi -- Kana kanji simple inversion library Date: Fri, 06 Mar 2026 11:20:01 +0100 Message-ID: References:

X-Original-To: yokota X-Mailbox-Line: From debian-python-request@lists.debian.org Fri Mar 6 10:11:08 2026 Old-Return-Path: X-Amavis-Spam-Status: No, score=-113.51 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GMAIL=1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/HTEK498I+jGyw=o78K+QmLG"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23683 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20260306101032.3aa35ec6@debian.org Approved: robomod@news.nic.it Lines: 93 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Fri, 6 Mar 2026 10:10:32 -0000 X-Original-Message-ID: <20260306101032.3aa35ec6@debian.org> X-Original-References:

Xref: csiph.com linux.debian.maint.python:17421 --Sig_/HTEK498I+jGyw=o78K+QmLG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 1 Mar 2026 23:00:41 +0900 yokota wrote: > Current packaging site is moved under python-team: > https://salsa.debian.org/python-team/packages/python-pykakasi hi Hiroshi, please find my review of pykakasi below. Some of the issues closely resemble those identified for jaconv, but are included anyway to keep things in one place. For the binary package, I used a private build of jaconv left over from yesterday's review of that package. * copyright: upstream uses GPL-3+ in both code headers and pyproject.toml, not GPL-3 (only). * copyright: please don't repack the orig tarball unless doing so is necessary; if you want things like egg-info out of the way there's less intrusive ways to achieve that (d/clean etc.). * copyright: no need to repeat the upstream claim itself within a license paragraph, these aren't part of the terms of the license. In similar fashion, the copyright fields in various places should be trimmed to just "Copyright: ", without any extras such as 'Copyright (C)' or 'all rights reserved'. * rules: hardening enabled for a pkg with nothing to harden? * rules: undefined variable $(TEST_ARGS) used in argument to dh call (args were passed by environment var PYBUILD_TEST_ARGS instead) * docs: installs sphinx documentation sources into the binary package without actually building the docs? * docs: files such as AUTHORS and CONTRIBUTE that don't seem to be useful as end user documentation. * lintian: W: python3-pykakasi: extended-description-line-too-long line 2 W: python3-pykakasi: no-manual-page [usr/bin/kakasi-pykakasi] W: python3-pykakasi: python-module-in-wrong-location usr/lib/python3.14/d= ist-packages/pykakasi -> usr/lib/python3/dist-packages/pykakasi The files triggering that last warning are the following (all duplicates = of files also installed in /usr/lib/python3/dist-packages/pykakasi): drwxr-xr-x root/root 0 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/ drwxr-xr-x root/root 0 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/ drwxr-xr-x root/root 0 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/ -rw-r--r-- root/root 1252 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/halfkana3.db -rw-r--r-- root/root 6825 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/hepburndict3.db -rw-r--r-- root/root 3290 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/hepburnhira3.db -rw-r--r-- root/root 7507 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/itaijidict4.db -rw-r--r-- root/root 6827 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/kunreidict3.db -rw-r--r-- root/root 3273 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/kunreihira3.db -rw-r--r-- root/root 7735 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/passportdict3.db -rw-r--r-- root/root 3680 2025-12-29 15:45 ./usr/lib/python3.14/dist= -packages/pykakasi/data/passporthira3.db I'm not sure what causes these files to be installed there; this might well be an issue with the tooling rather than the packaging. --Sig_/HTEK498I+jGyw=o78K+QmLG Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmmqqBgACgkQQoMEoXSN zHqAwQ/8DCPjgGzoE1n8c9tLzeFyc0GYYBDweESJig9TDw45ciOpzytF+AiQCO7C aztSJTYmCJogyoA7bZmzXMukvRkBWSlfvgGNf8Ly/OrPYNf+FdUZyKv72Z5wWUBZ j4UE59CBFdJvggZ/T1w2Hgs6nRXW2Mhzv/PIDLQap/Q5nwd5qAGlkdJUwuXQfkIL UmZ/Dfnw2chHOnkOsLlwU59NUa21Fa73rLC3d+ia4MX2pcHs6HIeoP+fMDrl/yyH /mDvDQgX/CsWSDzIgbiw8PlU7BSvZa42Fq7n2UYscldTFORATJ8ENfufkYxx584r rKkjcbv5NUqL3IyBOvNZr9nriD4/T9rD+BSrKopfo+OdCFzTQRq+tMEcDoC3nTpM UOFGR3WVCca/Doc9ojBWoLNGGWNMMu3CbUqkdYYnWxlfxwxS587VjQZUkJs9IGF+ Ej14bF0Xe8dYwE6MTSTEe/Z6gsh6fikzJNUfi/xPhOOfuFovuZSnaY3gIyUMZl1g jizuE3olCd7HC8Vr4FSUKaGTGcg1m8SJkeZ5Iw4AyUoU5YYh0nIghqrk990o0Lop FzeMmnDlsYA4EYbFRhdA9SvzfUabSTG3+/HlkXtkMkG3BPgNT9B9Fag51cBL/cdt Ck8ZgQeEIY1yf+Jd+KIeQP+Yg7V85L378Iw0VrUePaIh6EE5ah8= =QqIX -----END PGP SIGNATURE----- --Sig_/HTEK498I+jGyw=o78K+QmLG--