Path: csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: Re: review for python-pgvector/0.4.2-1 Date: Wed, 04 Mar 2026 12:00:01 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Wed Mar 4 10:53:08 2026 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.51 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/kAQOsjnZIg7Xs35dCxS0pL9"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23681 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20260304105230.7107c22c@debian.org Approved: robomod@news.nic.it Lines: 89 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Wed, 4 Mar 2026 10:52:30 -0000 X-Original-Message-ID: <20260304105230.7107c22c@debian.org> X-Original-References: <20260223164040.492b6a46@debian.org> <2398665.ElGaqSPkdT@office.arianott.com> Xref: csiph.com linux.debian.maint.python:17419 --Sig_/kAQOsjnZIg7Xs35dCxS0pL9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 04 Mar 2026 07:24:58 +0000 Arian Ott wrote: Hi Arian, thanks for making those improvements. First some new remarks: * control: the binary pkg has a dependency on python3-sqlmodel, but that module appears to be used in the tests only. * question: module dependencies on the binary package have been split into hard deps and recommended ones, although all import in the upstream code appear to be unconditional. What's the rationale here? Then for some of the old findings: > > * there's diff between the orig tarball pulled in by uscan and the > > one generated from the pristine-tar branch: > > (output from tardiff -m -s) > > =20 >=20 > I recreated the pristine-tar again and pushed it in the repo. Please push the updated pristine-tar and upstream branches. Tags also seems to be missing on salsa, although they must exist given that the commit messages on the master branch mention them; please push those as well. > > * autopkgtest: please test with all supported Python versions. The > > salsa CI logs show both 3.13 and 3.14 tested on build, but only > > 3.13 in the autopkgtest. =20 >=20 > I added a for loop iterating over all python versions. There seems to be a typo in that: https://salsa.debian.org/python-team/packages/python-pgvector/-/jobs/915476= 2#L582 You want to inspect key CI steps (build, lintian, autopkgtest), even if they got that green check-mark. An error like that should have been fatal, but wasn't. That might be the result of the entire code block within the pg_virtualenv not running with 'set -e' (unlike the "main" script). Please make sure the autopkgtest actually fails when things are broken, and check whether or not the build-time tests are affected by this as well. The autopkgtest also still carries a lot of excess dependencies. You don't want to do that, as that can mask missing dependencies on the binary package. Let the binary package take care of all runtime requirements, and limit the dependencies on the autopkgtest to whatever is needed on top of that to support the tests. Note that this is fundamentally different from the situation during build, where you don't yet have a binary package at your disposal and therefore must list everything (including modules only needed at runtime) as build-deps. > Upstream rejected all patches =C2=AF\_(=E3=83=84)_/=C2=AF Too bad, thanks anyway for putting in the effort. --Sig_/kAQOsjnZIg7Xs35dCxS0pL9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmmoDu4ACgkQQoMEoXSN zHp+Vg//b8eCXijdAPCwdSGrdkgSGJ9V+mCqM4Ukuicy5g+4xFp9/QMkpX6/F9fQ RbHE7RedZBy/rdZKFY6ETe7ylVl2uLl0SrahEiHT5GAf0sj/MVTHqzv1C4ifBtxy CR9ESkzzVWDMOFvXgJGZxvqAPLkN/y0UuxHWxDJiSg3/VPjpJyfpgh2oADj92U3O /4Hth/OrwXnoIGa1IkcfhdNhxGZj8cP+lrJNnkv/3ynx1dbQYiI1FVL7F3G4BzcX ODPvjRZ8/BrwiEUbiCVFPLFsN22DY+1s5dUbt3MgGiS4q+AuV26U6Oki2KckvMRF yRvOvdfLTARolHXmt3QzK6FgcNgANSfys0LUbhJCmkYibHCMNzMqP5Ap/CQCwbQJ ZFqraHq7OmfMtDKlPs/3T3o1OF6Kj6sX7VmPz/SIx3kNdiHsnxRjjMEWfK1jcwGu M3F2N1qydLqqng08p74+RgU9VVdb9TVSF9PTJF/rjSm392GAWTmo7Yak6Qk6Tah1 DZhJ1BrZVcGESOtLYeXNSsRwL/68bl7MuyZUAwmPHwhTVHhq1rCXE3gyJ+3NCluf egtrnMmBVtjJWVGp78S1vnVnqrqDeVuBSbtxzvDzdXOJYmC2TyAp6oWbr9bVlq/c dJuzJcGxtVNPfg64FMjFDctEliOkTffSKcD/PVWAmeG+tHY0bD0= =Hidb -----END PGP SIGNATURE----- --Sig_/kAQOsjnZIg7Xs35dCxS0pL9--