Path: csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: Re: RFS: python-papermill/2.7.0-1 [RC] [Team] -- Parameterize, execute, and analyze notebooks Date: Tue, 21 Apr 2026 17:40:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Apr 21 15:38:40 2026 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.949 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.4.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/eDQaluiKJfe3tU1Qj8h6O8s"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23747 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20260421153813.1fd74d8d@debian.org Approved: robomod@news.nic.it Lines: 78 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: , "Bastian Germann" X-Original-Date: Tue, 21 Apr 2026 15:38:13 -0000 X-Original-Message-ID: <20260421153813.1fd74d8d@debian.org> X-Original-References: <20260420122933.4507f937@debian.org> Xref: csiph.com linux.debian.maint.python:17470 --Sig_/eDQaluiKJfe3tU1Qj8h6O8s Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 21 Apr 2026 09:01:17 +0200 "Pieter Lenaerts" wrote: > On Mon Apr 20, 2026 at 2:29 PM CEST, Jeroen Ploemen wrote: > > did a review of python-papermill, up for sponsorship in the Python > > Team: =20 >=20 > Hi Jeroen, >=20 > Thanks for this detailed review. You may have seen that Bastian has > uploaded python-papermill in parallel. >=20 > I will implement your comments and make them part of a next version. >=20 > Some specifics: >=20 > > * control: the restriction on pyarrow only deals with i386, > > presumably because the salsa CI doesn't try any archs other than > > amd64 and i386. The Debian CI on the other hand runs on more > > archs; does the current setup survive that, or is this package > > going to run into trouble elsewhere as well? If so, you might > > want to switch the current [!i386] to a list of all archs where > > pyarrow is available. =20 >=20 > I should have looked at the apache-arrow debian/control file. [1] >=20 > apache-arrow restricts to 64-bit LE and that means I should exclude > not only i386. Yeah I noticed bage's upload; apparently my review was overlooked. For now, the package doesn't build at all because something way down the dependency chain of pyarrow is missing, but once it does I strongly suspect it will fail the CI on s390x (which is big endian and thus doesn't have python3-pyarrow) and not migrate as a result. In the meantime, please go ahead with the necessary improvements as this package is likely going to need another upload anyway. For the pyarrow test patch, you can use something along the lines of: HAVE_PYARROW =3D True try: import pyarrow except ImportError: HAVE_PYARROW =3D False pass ...to check for the presence of pyarrow, then use that boolean in place of the current check for a specific architecture. That way, the only place you need to maintain a list of architectures is on the build-dependency in d/control. --Sig_/eDQaluiKJfe3tU1Qj8h6O8s Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmnnmeUACgkQQoMEoXSN zHqt7RAAoDIfC8ZUKVCVbNweI62Rr48iUwnY/1mXRw1feD0c3iuQI1hDWnDKXwq9 Sl4AJ+w0kxUnKUkj50E0QMjH8VBd52EhrXjP3EHf2EyzDOglcX1IOqkUAxF/f9gu mMtBgu0HO86WVybETdFCzqpFV2GuJZ/cVbksyH0VHu9kxHiLuK3U4+7vLU2JnkNu M7Nzxv+L6LrwXxR2X8cfLU8fKnsHOVoI3NkXRCHLewJ8DtE2szaYpteL/OXrARRz Ti7bbTTndzcKLrTx3FNrgIZZnXvEfPOenFDO0ZmTHt4c/ZSDKNrU0fDvE+foBe6x ndsjEp9/HEP1Zlz+Rvbpdw3o9pam49Rs5cUtwE93xNi9ue/Jr5HiV3yQGPO++Bon QitFoIAws8LwVn4BCjEAz7RwzSh3Mw+B6bGOHUTAl/hFobehYp+PKVM1H3IX2sES j9dp+Fo2JeiYOgRAqFTBZ3mnI3m5Jgv1Udo6ThGGpsLm+si/EiSJd48jJIb+ARKY 5G4+wfCw79c7SddjCEwUscHTQuQabg0DTWgIWe3UechyJw3Qvsbk+lTSivjOfWKU OfyXauVX4Zo0HNRsV77xGBH5cs+ycvO+nMe+kByWYHTQg6BJDHz4vw//eZOQx6VY F/+2UpxkFJt+eICoeqf33sZxNjkifBdQf14tzwf2UL1p7vBP1Vw= =4LfM -----END PGP SIGNATURE----- --Sig_/eDQaluiKJfe3tU1Qj8h6O8s--