Path: csiph.com!pasdenom.info!newsfeed.bofh.team!3.eu.feeder.erje.net!feeder.erje.net!fu-berlin.de!bofh.it!news.nic.it!robomod From: "Pieter Lenaerts" Newsgroups: linux.debian.maint.python Subject: Re: RFS: python-papermill/2.7.0-1 [RC] [Team] -- Parameterize, execute, and analyze notebooks Date: Tue, 21 Apr 2026 09:10:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Apr 21 07:01:38 2026 Old-Return-Path: X-Amavis-Spam-Status: No, score=-12.098 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -4.6 MIME-Version: 1.0 Content-Type: multipart/signed; boundary=cdb1ef30bce162623af17b01017d00793fd80db873d66838a4bcc4f8b419; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailing-List: archive/latest/23746 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/DHYN1EOAYW6W.2UEGH3A7O3TB2@disroot.org Approved: robomod@news.nic.it Lines: 89 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: , "Bastian Germann" X-Original-Date: Tue, 21 Apr 2026 09:01:17 +0200 X-Original-Message-ID: X-Original-References: <20260420122933.4507f937@debian.org> Xref: csiph.com linux.debian.maint.python:17469 --cdb1ef30bce162623af17b01017d00793fd80db873d66838a4bcc4f8b419 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Apr 20, 2026 at 2:29 PM CEST, Jeroen Ploemen wrote: > did a review of python-papermill, up for sponsorship in the Python > Team: Hi Jeroen, Thanks for this detailed review. You may have seen that Bastian has uploade= d python-papermill in parallel. I will implement your comments and make them part of a next version. Some specifics: > * control: the restriction on pyarrow only deals with i386, > presumably because the salsa CI doesn't try any archs other than > amd64 and i386. The Debian CI on the other hand runs on more archs; > does the current setup survive that, or is this package going to > run into trouble elsewhere as well? If so, you might want to switch > the current [!i386] to a list of all archs where pyarrow is > available. I should have looked at the apache-arrow debian/control file. [1] apache-arrow restricts to 64-bit LE and that means I should exclude not onl= y i386. > A similar question applies to the patch that skips the pyarrow > tests on i386. That could be generalised to check for the > availability of pyarrow, rather than looking for any specific > architecture(s). Yes, this is the consequence. > * patches: the indentation issue that > fix_indent_error_in_test_iorw.py.patch deals with isn't present in > the upstream code, but introduced via > remove-relative-paths-and-entrypoints.diff. Please drop the former > and instead fix the latter. Ouch. I should have checked. Will do and will report this upstream. > > * patches: what's the reasoning behind the location change in > fix_test_s3_locationconstraint.patch? I got an IllegalLocationConstraintException from moto. However, when trying to retrace my steps and find the stackoverflow or othe= r source where I found the suggestion to change the region to fix that error = I bumped into a post [2] explaining that moto / boto3 can take info from outs= ide the project context. So, my own config might be contaminating this test. Though I don't see righ= t away how that would the correlate to the builds in sbuild or salsa CI. I wi= ll double check this. Thanks again! Pieter [1]: https://salsa.debian.org/science-team/arrow/-/blob/master/debian/contr= ol?ref_type=3Dheads#L12 [2]: https://til.codeinthehole.com/posts/python-tests-using-moto-should-be-= explicit-about-aws-regions/ --cdb1ef30bce162623af17b01017d00793fd80db873d66838a4bcc4f8b419 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIkEABYKADEWIQQrLg4/tS9aUxZMq8oFuPKwcqDg6wUCaecgvxMccGxlbmFlQGRp c3Jvb3Qub3JnAAoJEAW48rByoODr4okBAP17Hgxz+AuksL5RX+IaS6DaJSy55kKl qwjWBEM667aRAP4nhBRoh4uyfeGqm1EZ1sioonn98TbwKs2htSYDBgBXDw== =Klzh -----END PGP SIGNATURE----- --cdb1ef30bce162623af17b01017d00793fd80db873d66838a4bcc4f8b419--