Path: csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: review for python-pytooling/8.8.0-1 Date: Tue, 09 Dec 2025 18:00:01 +0100 Message-ID: X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Dec 9 16:58:42 2025 Old-Return-Path: X-Amavis-Spam-Status: No, score=-115.41 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, MD5_SHA1_SUM=-1, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/loXV0w5ToyTx7PzVZTYdBWg"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23503 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20251209165811.46114821@debian.org Approved: robomod@news.nic.it Lines: 106 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Tue, 9 Dec 2025 16:58:11 -0000 X-Original-Message-ID: <20251209165811.46114821@debian.org> Xref: csiph.com linux.debian.maint.python:17267 --Sig_/loXV0w5ToyTx7PzVZTYdBWg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable hi Aryan, I took a look at the python-pytooling package, up for sponsorship in the Python team: * repo: d/salsa-ci.yml exists but the CI wasn't enabled. Fixed already. * copyright: missing a copyright holder for a bunch of files: pyTooling/CLIAbstraction/Command.py:15:# Copyright 2014-2016 Technische U= niversit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics and Ar= chitecture # pyTooling/CLIAbstraction/ValuedFlag.py:15:# Copyright 2014-2016 Technisch= e Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics and= Architecture # pyTooling/CLIAbstraction/Argument.py:15:# Copyright 2014-2016 Technische = Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics and A= rchitecture # pyTooling/CLIAbstraction/ValuedFlagList.py:15:# Copyright 2014-2016 Techn= ische Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics= and Architecture # pyTooling/CLIAbstraction/Flag.py:15:# Copyright 2014-2016 Technische Univ= ersit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics and Archi= tecture # pyTooling/CLIAbstraction/KeyValueFlag.py:15:# Copyright 2014-2016 Technis= che Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics a= nd Architecture # pyTooling/CLIAbstraction/ValuedTupleFlag.py:15:# Copyright 2014-2016 Tech= nische Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostic= s and Architecture # pyTooling/CLIAbstraction/BooleanFlag.py:15:# Copyright 2014-2016 Technisc= he Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics an= d Architecture # pyTooling/CLIAbstraction/OptionalValuedFlag.py:15:# Copyright 2014-2016 T= echnische Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnos= tics and Architecture # pyTooling/CLIAbstraction/__init__.py:15:# Copyright 2014-2016 Technische = Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics and A= rchitecture # tests/unit/CLIAbstraction/Executable.py:15:# Copyright 2007-2016 Technisc= he Universit=C3=A4t Dresden - Germany, Chair of VLSI-Design, Diagnostics an= d Architecture # * control: why is there a dependency on python3-all on the binary pkg? * rules: tests are disabled wholesale, despite numerous test-specific build-deps and what looks like a pytest-based testsuite. I created a branch and enabled the unit tests [1], and that seems to work alright (on amd64 at least, see [2]). Benchmark and performance tests also worked locally, but progressed rather slowly so I left these off for now. The testsuite fails on i386 because of the extremely limited linux platform detection/support in pyTooling/Platform/__init__.py, lines 247-257. That code looks like it can only ever work on amd64 and arm64. So unless it's possible to somehow add support for other archs, tests on build (as well as the autopkgtest) need to be limited to those two - for example by adding an override for dh_auto_test depending on the architecture, see [3]. I'll leave the decision whether or not to enable tests to you. Please do comment out the testing-related build-deps if you decide to leave them off. * autopkgtest: 'Testsuite: autopkgtest-pkg-pybuild' when no tests are run on build only creates the illusion of an autopkgtest. Please don't do that, it's basically the equivalent of running /bin/true. Once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail. [1]https://salsa.debian.org/python-team/packages/python-pytooling/-/commit/= ff8082ce38bff8da14ad113f3c3c3f0d5720a7ec [2]https://salsa.debian.org/python-team/packages/python-pytooling/-/pipelin= es/987532 [3]https://codesearch.debian.net/search?q=3Dpath%3Adebian%2Frules%20filter.= *DEB_HOST_ARCH&literal=3D0&perpkg=3D1 --Sig_/loXV0w5ToyTx7PzVZTYdBWg Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmk4VSMACgkQQoMEoXSN zHrWMhAA2LSMV7YwNImYERm2SFWJO3dPri1D933RN+0DDJ8qDxcsxsWuPJStbH2D 0XCIG2LJMdSYdh9W4ZyGoJcPV7kqgTG32qQ9Yf2QUHgeTPsQR3/LAW9m7krOffa2 OeJbGMV8UyMO1M1GOkWMUNbSJOU5zBSK/Hdb1F4KiER7xphMiQzgeY6t4Lsw87q5 qQETGmy6Ky0/6QUp+kXvCcTFnH4cfsmpJekZ5UQBlbTzsRmTQV5Lm3gVOysnV/E5 ZoyOs5or4timZ6L0AYMKbAIQm20K/emAfAOC7CgPWySG41jtX27YWxdq1HkCNEeJ EhDTR9umsyFnm9arN4tccMsZKrb+6OBoeRhtPUxFf2VRUfnaj/6isHL/+0z4/S/O MIt5Md9Bskrgs5rl8ZBaUU2U96XuuT+N5Yr+Vw6xd9ES6+B+UwALV+97QDNp1biN uBVh5BRIc8tdOBvPcf/DxNlHIeAmFs4UA8i3Tx/xksrEUeK0yw7fIRmjYz+iMBpU +eAT5tx2Lxpm7wkMnVK9Cmgb+tDHXqpsQwAj9k/UFbmuwGAtOwRbQRdaRhj8d2fh bPOgF0Ufo2V/Mbsme6Qvr4TU4ZnFCp9GMs7XYq7/3z60oPRRtbXOgVJcjXK2OHg3 oeIaKFHlFYGqEHXtdfOwwYkD+L87z4C8BgLti9gwnuOwvo24J0w= =go1i -----END PGP SIGNATURE----- --Sig_/loXV0w5ToyTx7PzVZTYdBWg--