Path: csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: review for inkcut/2.1.6-1 Date: Sat, 13 Sep 2025 12:00:01 +0200 Message-ID: X-Original-To: alexander@sulfrian.net X-Mailbox-Line: From debian-python-request@lists.debian.org Sat Sep 13 09:51:43 2025 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.51 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/_8e8R1fm6v97_l5/s0XOaT3"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23242 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20250913095113.775a2184@debian.org Approved: robomod@news.nic.it Lines: 89 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Sat, 13 Sep 2025 09:51:13 -0000 X-Original-Message-ID: <20250913095113.775a2184@debian.org> Xref: csiph.com linux.debian.maint.python:17061 --Sig_/_8e8R1fm6v97_l5/s0XOaT3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable hi Alexander, I took a look at the inkcut package, up for sponsorship in the Python team: * copyright: according to the readme that ships in the same dir, the famfamfam part of inkcut/res/icons/ is the under cc-by-2.5, not 3.0. * copyright: missing entries for: tests/test_order.py:2:Copyright (c) 2022, Karlis Senko tests/test_filters.py:2:Copyright (c) 2022, Karlis Senko (thank you very much for correctly listing all the others!) * rules: there appears to be a typo in the pod2man commandd. * rules: override -> execute_after? * control: missing (build-)deps on python3-atom, python3-qtpy. Some of those are currently pulled in indirectly (for example atom via enaml), but they do get imported in inkcut's own code and therefore should be direct dependencies. * control: no Python deps for inkscape-inkcut, although there's Python code in the plugins importing external modules (lxml). Same as above, you want to add an explicit dependency. The other import in plugins/inkscape (inkex) appears to be part of inkscape itself (which is already a hard dependency), and installed into its private directory at /usr/share/inkscape/extensions/inkex/. Inkscape-inkcut in turn installs its plugins files into /usr/share/inkscape/extensions/inkcut/; I assume inkscape takes care of the python path to make these imports work? * control: could leverage ${source:Extended-Description} and ${source:Synopsis} instead of repeating the identical text for every binary package, see [1] for numerous examples. * d/upstream/metadata: links to the upstream documentation website [2] and user forum [3] could be useful additions here. * patches/Fix-missing-device-protocol.patch: does this one originate upstream? And if not, should it be forwarded? * the inkcut binary package is currently designed as a module package (with files stored in /usr/lib/python3/dist-packages/), rather than as an application (that just happens to be written in Python). The latter would typically use a directory in /usr/share// (see 'inkscape' or 'nfoview' for examples) so that the module is "private" (as in: not on the global python path). Is the inkcut module actually intended to be imported by 3rd party scripts, or should the inktcut binary package be changed to an "application layout"? Once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail. [1]https://codesearch.debian.net/search?q=3Dpath%3Adebian%2Fcontrol+%24%7Bs= ource%3AExtended-Description%7D&literal=3D1 [2]https://www.codelv.com/projects/inkcut/docs/ [3]https://inkcut.org/ --Sig_/_8e8R1fm6v97_l5/s0XOaT3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmjFPpEACgkQQoMEoXSN zHrsxRAA3dj31pkav1Y5y3CNKtbRp7xYQcPGJHniJLsf8pJ/b6H6clUikb98WuDR 891SvxfvfbvDGjaGs/6Ww5+fGyT6jm51X8I6HLjEbJGIVZRAxJPCuB227pR4Zqvy AQdQrqNVozPxT1uqgPZF361r9rq9aA7AtQzYxInZeqjwf0BQMkjs9mimPyZH92Dx K91JykAFOt9wX8LBggtj7Ep+qo08JfXj4LSJIR84E6ADG59AVIV87GjzBhpLFSCv wmWFddDbQ8TPimtlZfLa2iwXQ834EQybbzahuPlym8PoOPNU9PsE6EcLQfnK+6tv Mm9wa5RWyXn0Hs+DXqWMZ8CF2P6qbmVtPPoCSBcn0LRE9DROWYparWS5frfjfURA QOHWnsHFnr0Yp0B0+WHaMCjPU6VfuEiCFPuIyXkAbB0SW8+wKpBoN8BXHpW9skdB k0fXy2vSJ05zxvqFheOtdDjNucTY765dyng1kdv2ANjDai/TEh0Cs7Zn4k53qG/D +2iGFzvlk8HnP6bIEfr12eHcMT2j6MeI9MjdOLdekCLDkHEIbdgA7IJPSQvHNeEx zAmfMN7FgmjYDs9KST+69vndoKKzDns8TKPz4sToQXDC3BpPbFDh79BTRdN1h3kB diaUgr2LaG/6v9nk92gS7JhbK9beupFaSL7mRSZTiBC6IBOnBXQ= =0zZy -----END PGP SIGNATURE----- --Sig_/_8e8R1fm6v97_l5/s0XOaT3--