Groups > linux.debian.maint.python > #17231

Re: review for datasette/0.65.2-1

Path	csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Mahangu Weerasinghe <mahangu@gmail.com>
Newsgroups	linux.debian.maint.python
Subject	Re: review for datasette/0.65.2-1
Date	Fri, 05 Dec 2025 08:10:01 +0100
Message-ID	<LYy6Z-vc8-5@gated-at.bofh.it> (permalink)
References	<LWqGB-gBQ3-1@gated-at.bofh.it> <LWS9P-gWOP-1@gated-at.bofh.it> <LXg2t-hcIe-9@gated-at.bofh.it> <LY7q9-cQ5-1@gated-at.bofh.it> <LYljs-mii-11@gated-at.bofh.it>
X-Mailbox-Line	From debian-python-request@lists.debian.org Fri Dec 5 07:06:18 2025
Old-Return-Path	<mahangu@gmail.com>
X-Amavis-Spam-Status	No, score=-2.199 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=2, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001, REMOVEDOT=3] autolearn=no autolearn_force=no
X-Policyd-Weight	NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-vk1-xa31.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5
X-Gm-Message-State	AOJu0YzQI0JJ6QTP7xx8syrh2ljeZTwzChKDQ0gzLaN1QQvqVQiU7fs4 IMGA2t8U0zy+CCZE0EuMoux9wWS6AbeYJDMilCehmQKT45xudAYixLGCEd2udLoDFmlavXUII9+ cX8X2CSIyK1dq4JVlo1SAPFYr8hg4d3E=
X-Gm-Gg	ASbGncvJhBpPEdb+VzDTEWdTcI3jGskLjSZ+ha0sE3jJSPQSXPNSSCxuX61ubb8cwRG +u1kdXUjbynQwqjf7zBp5DcDldJaYkfVHagTZnsJ13/QexzZquzUqbtW0v05X4y5w9M1ooI1fiH E8dpZ3yt9t378uoGNWfOM8DWvU7HFybedRj3GGU0QxdCSDXsIhpo+j6jHAN0SZ2vFOhMD5gcO5R MEpbRzoKl3tK2ykkYTUkLlMhrkLm0KmqlGYB4MU7DxkZlLi/P+C84ykR1p9KcqZ42ii1c37L79R g+8om9m5iqyJQH9MyGgSOs0nQrPA
X-Google-SMTP-Source	AGHT+IHhrOok6IQ65HEa1tt9zswkobf4x69IfWc1NnAQ4UeGeve6wJsjXniJYHgtezYISKg7XOwuIRMk9ziFaC6jBSI=
X-Received	by 2002:a05:6122:3227:b0:559:60b8:fa81 with SMTP id 71dfb90a1353d-55e5be413c1mr3433802e0c.4.1764918360562; Thu, 04 Dec 2025 23:06:00 -0800 (PST)
MIME-Version	1.0
X-Gm-Features	AQt7F2p6w4WzWH095CTAOaVRY2fNtwV0iQByXsA4QRR4ljId3qfaXQufql-9E6I
Content-Type	multipart/alternative; boundary="000000000000f05e5d06452f13a1"
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/23465
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/CACe4y=8qrQxDmP-hARNgA-q_vGpOiF-cmtkkUZqG2ZB+o11Nfw@mail.gmail.com
Approved	robomod@news.nic.it
Lines	109
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Fri, 5 Dec 2025 12:35:49 +0530
X-Original-Message-ID	<CACe4y=8qrQxDmP-hARNgA-q_vGpOiF-cmtkkUZqG2ZB+o11Nfw@mail.gmail.com>
X-Original-References	<20251129104928.530c2227@debian.org> <CACe4y=8kyv_KLRqQRtUvSeunnZmhLUbWQMaqwLp5YO+5N1_UaA@mail.gmail.com> <20251201173704.6056319c@debian.org> <CACe4y=9X=Uk0fXJdGKbAi=tqK9yJzd3ua9XJtYASGzyrsfHXgA@mail.gmail.com> <20251204172823.62b5b90f@debian.org>
Xref	csiph.com linux.debian.maint.python:17231

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Jeroen,

Thanks for catching these and for the housekeeping on d/rules!

> table.js in missing-sources

Removed. Added lintian override with comment noting it's a false positive
(long lines, not minified).

> codemirror-5.57.0.min.css missing from d/missing-sources

Added codemirror-5.57.0.css from the 5.57.0 tag [0]. Updated README
accordingly.

> stack limit for all 32-bit archs

Noted on extending to sh4, m68k, etc. Will keep that in mind for the future!

Best,
Mahangu

[0] https://github.com/codemirror/codemirror5/blob/5.57.0/lib/codemirror.css


On Thu, Dec 4, 2025 at 10:58 PM Jeroen Ploemen <jcfp@debian.org> wrote:

> hi Mahangu,
>
> was doing some last minute checks before upload when I noticed these:
>
> * for datasette/static/table.js, the file in missing-sources seems to
>   be identical to the one in the orig tarball - neither is minified,
>   it just has a long line that triggers the lintian hit. So there's
>   no need for this to make an appearance in missing-sources.
>
> * datasette/static/codemirror-5.57.0.min.css on the other hand is
>   actually minified, but not present in d/missing-sources. I guess
>   lintian only looks for certain types of files, and css isn't among
>   them. Anyway, the original appears to live at [1] (and probably
>   somewhere in a codemirror tarball as well).
>
>
> I also changed the stack limit to cover all 32 bit archs, since
> there's a few ports that are also 32 bit (sh4, mk68, etc.), and did
> some housekeeping to trim down long lines in d/rules and remove
> overrides made redundant by other changes.
>
>
> [1]
> https://github.com/codemirror/codemirror5/blob/master/lib/codemirror.css
>

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar

Thread

review for datasette/0.65.2-1 Jeroen Ploemen <jcfp@debian.org> - 2025-11-29 11:50 +0100
  Re: review for datasette/0.65.2-1 Mahangu Weerasinghe <mahangu@gmail.com> - 2025-11-30 17:10 +0100
    Re: review for datasette/0.65.2-1 Jeroen Ploemen <jcfp@debian.org> - 2025-12-01 18:40 +0100
      Re: review for datasette/0.65.2-1 Mahangu Weerasinghe <mahangu@gmail.com> - 2025-12-04 03:40 +0100
        Re: review for datasette/0.65.2-1 Jeroen Ploemen <jcfp@debian.org> - 2025-12-04 18:30 +0100
          Re: review for datasette/0.65.2-1 Mahangu Weerasinghe <mahangu@gmail.com> - 2025-12-05 08:10 +0100

csiph-web