Path: csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: Re: review for datasette/0.65.2-1 Date: Mon, 01 Dec 2025 18:40:01 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Mon Dec 1 17:37:59 2025 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.51 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/=TEw28cPKi+Ss941zzQCVlT"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/23438 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20251201173704.6056319c@debian.org Approved: robomod@news.nic.it Lines: 108 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Mon, 1 Dec 2025 17:37:04 -0000 X-Original-Message-ID: <20251201173704.6056319c@debian.org> X-Original-References: <20251129104928.530c2227@debian.org> Xref: csiph.com linux.debian.maint.python:17205 --Sig_/=TEw28cPKi+Ss941zzQCVlT Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Mahangu, > Tested in clean chroot and Salsa CI also now passing. Ready for > re-review. >=20 > Note: I made additional changes to get CI green (test configuration > via PYBUILD_TEST_ARGS/PYBUILD_BEFORE_TEST, pristine-tar, > Build-Depends adjustments). I'm still learning Debian packaging, so > I'd appreciate any feedback if these aren't the right approaches. thanks for all those fixes, much better now. Don't worry if there's a lot of feedback, you didn't pick the easiest package to start out with packaging from scratch. Some issues remaining: * repo: upstream/0.65.2 tag still points to the old source import, should be moved to the newest one; see https://salsa.debian.org/python-team/packages/datasette/-/commits/upstream * vendored copy of pint gets installed into the binary pkg; you might want to add an entry to d/clean (datasette/vendored/*) to ensure it cannot be used or installed by accident. * control: there's still a load of unnecessary hardcoded python deps on binary pkg; you probably only need to keep markupsafe (or patch setup.py so it's picked up by dh_python/pybuild); everything else looks like it would be provided via ${python3:Depends}. * control: build-deps on python3-platformdirs, -typing-extensions, and -flex* were needed only for the vendored pint; with that out of the picture, these deps are unused and should be removed. * patches: remove-vendored-pint patch header contains boilerplate dep3 template. * rules: '--with python3' is redundant when build-depending on dh-sequence-python3. * rules: override_dh_auto_build -> execute_after_dh_auto_build? * copyright: the vendored copy of pint is still missing here. It must be included even if it's not used or installed, simply because it's shippped in the orig tarball. * some lintian hits need attention, particularly: (from https://salsa.debian.org/python-team/packages/datasette/-/jobs/8674686) I: datasette: unused-override application-in-library-section python [usr/= bin/datasette] [usr/share/lintian/overrides/datasette:4] =20 --> section already changed to 'database' I: datasette: package-contains-documentation-outside-usr-share-doc [usr/l= ib/python3/dist-packages/docs/*] =20 --> these typically go in /usr/share/doc/ W: datasette: package-contains-vcs-control-file [usr/lib/python3/dist-pac= kages/docs/.gitignore] =20 W: datasette: privacy-breach-generic [