Path: csiph.com!tncsrv06.tnetconsulting.net!newsfeed.endofthelinebbs.com!news.corradoroberto.it!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Soren Stoutner Newsgroups: linux.debian.bugs.dist,linux.debian.maint.python Subject: Bug#998151: python-trezor: incorrect binary package name, python3-trezor should be python3-trezorlib Date: Fri, 04 Oct 2024 18:50:01 +0200 Message-ID: References: X-Original-To: 998151-submitter@bugs.debian.org, 998151@bugs.debian.org X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Fri Oct 4 16:45:08 2024 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -1.699 Reply-To: Soren Stoutner , 998151@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: Debian Python Team X-Debian-Pr-Message: followup 998151 X-Debian-Pr-Package: src:python-trezor X-Debian-Pr-Source: python-trezor Organization: Debian MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7299064.ChYaqQxqx4"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Debian-User: soren X-Crossassassin-Score: 2 X-Debian-Message: from BTS X-Mailing-List: archive/latest/1861411 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 92 Sender: robomod@news.nic.it X-Original-Cc: Debian Python X-Original-Date: Fri, 04 Oct 2024 09:41:45 -0700 X-Original-Message-ID: <8869518.YNYsyFKe8d@soren-desktop> X-Original-References: <2293296.RJCQjk8tL4@soren-desktop> <163564433318.818565.9203419061094757269.reportbug@zion.matrix.int> Xref: csiph.com linux.debian.bugs.dist:1215163 linux.debian.maint.python:16320 --nextPart7299064.ChYaqQxqx4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Soren Stoutner To: 998151-submitter@bugs.debian.org, 998151@bugs.debian.org Cc: Debian Python Date: Fri, 04 Oct 2024 09:41:45 -0700 Message-ID: <8869518.YNYsyFKe8d@soren-desktop> Organization: Debian In-Reply-To: MIME-Version: 1.0 Carsten, On Friday, October 4, 2024 8:09:14 AM MST Carsten Schoenert wrote: > Am 03.10.24 um 07:10 schrieb Soren Stoutner: > > Sandro, > >=20 > > I have just taken over maintenance of python-trezor and would like to > > rectify > > this problem. As I have never renamed a python binary package, I would= =20 like > > to make sure I handle it correctly. > >=20 > > I can see the package is indeed installed into > > /usr/lib/python3/dist-packages/ trezorlib, which appears to be inline w= ith > > the upstream source code (/src/ trezorlib). > >=20 > > I assume that fixing this involves changing the name of the binary pack= age > > from =E2=80=9Cpython3-trezor=E2=80=9D to =E2=80=9Cpython3-trezorlib=E2= =80=9D. >=20 > why do you think this is needed? > I don't see any reason to do so. Keep it as it is. When I adopted this package, there was an existing bug report [1] claiming= =20 that the existing binary package name needs to be changed to comply with=20 Python Policy. The bug report doesn=E2=80=99t explain exactly what aspect = doesn=E2=80=99t=20 comply with the policy, but I assume it comes down to python3-trezor=20 installing to the following two directories, which have disparate names: /usr/lib/python3/dist-packages/trezorlib/ /usr/lib/python3/dist-packages/trezor-0.13.9.egg-info/ If this isn=E2=80=99t a policy violation I am in favor of leaving the packa= ge name as=20 is, which is why I copied my response to the debian-python list. > Upstream is using the name 'trezor' as package name and we should not > derive from that if not really strong reasons are given to do this. > Again I even don't see any more light reasons to do this renaming. Upstream seems to use both trezor and trezorlib, with the PyPI package name= d=20 trezor while the files are installed to trezorlib. Perhaps that is a probl= em=20 that upstream should address. I would appreciate any guidance on the best = way=20 to proceed with the Debian packaging. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D998151 =2D-=20 Soren Stoutner soren@debian.org --nextPart7299064.ChYaqQxqx4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEJKVN2yNUZnlcqOI+wufLJ66wtgMFAmcAGskACgkQwufLJ66w tgOlVw//bhB3zeiEU5onMu1sApC2BPRHu5F49h/Xo03lAEj+kDoDjlhTB0lACnZQ Rqeb4ltTvnVYqL3R/LJGQmgIDVEe4pfJ3sbMQvGt4JDqcxKeH/LxhB6XTokJePrK lD8QsfISfj+JhK5blD+nd4ICpd6X0ORCqJjMQJFH5VcR73YIQybwhqHPb7zxj5Ed yBO/AkpfwRiQI3+KkFu1o+hmPiv70LN0aW93meAHudxF0riWy+5iLv//6oBnt+B2 nrSDG+6cXv2CmzjqWJ0erPW/yOhMysicVOBaIvd0WI+CNZSSDe/Ec3fYkKbHm+Pa /2dsxii7pgbkMEs1JdSwy4NXnzBt+OshSavWub7rvd1sIERyNZJ3O8cGsKLFg4Mk 2LvO7fO29MwEelLZEIobM+ijFg9TJjPcpxzCsGwTfTJHrGDUX7Oyg4ZF0AZieG54 3iiJC9dQyiBDcrkUbVL7ofpJ6rW09rgKlb64Zdr9yXCvGaDZ7SDBBqnVIsMBHbVZ DCeWSQG2Q8ec1zrRy52bompxwWaTUMJKI6xNttCdVD5Rr7zVtrAYCTBrYF/q5ltR BXtdlx0lCESx6Se0tFJcP5RtZ7pbFv4t105drIkSnsQX6khYNY/NpMb0o63iqO59 b2ibs9sMfTUl4FYGSHP/F1bfv2E1l2RMKTbb/axqnClQIq/aD6w= =3xRJ -----END PGP SIGNATURE----- --nextPart7299064.ChYaqQxqx4--