Path: csiph.com!fu-berlin.de!news.servidellagleba.it!bofh.it!news.nic.it!robomod From: Carsten Schoenert Newsgroups: linux.debian.maint.python Subject: Re: Bug#1091197: ITP: python-genson -- user-friendly JSON Schema generator Date: Thu, 26 Dec 2024 08:50:02 +0100 Message-ID: References: X-Original-To: debian-python@lists.debian.org X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Dec 26 07:45:02 2024 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7.595 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, FREEMAIL_FROM=0.001, LDO_WHITELIST=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5.5 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US Autocrypt: addr=c.schoenert@t-online.de; keydata= xsFNBFIDTk4BEACx6disb51q5rTdDmnkOayFDiLgOrZ4InnRmbTsgYJaigcRXjVtjFaxwL0M Qtzrt9srlLBReWD4JvoLP9/8z2C1ORaoOUatApssuKd32Qa80lBlduIQCfaZ6K5Ij0TXeqIb dWXMWSvpaOwt+ecBGSdEepgABtxO9Xel9zqDsAauFxBRHGzJs3bSG8QRtwnQA2+9J8UEtzAc dY69YAkF3Q6HIPP/0mbGiget/1WGR+8tPKlVMYcgZtGIP2J36GkDbfDvdbH5QLn2KtMuGXLv f1CTy+vvQL3mY4caKamCU7tLi8FSufNZpPChguNOHsbuO//ACrTFqGysVFvq25zEb60t9Hoq AXHIMlDJFnR7XBUCyAHV4NROMvGZlFbLuZpUA81Kukj72xifqk9ZFl9sxqKPgheqi+dT8peV LgvgCgMgQjvZgQ5X4AG2kiIezWtjlToCZAZ4ufQ26aofvwZqhBrogQF/+272B9CJuKBLIx+R CEhtW4gTKShY3moc8Aqh8AFH3pWkXILAxEGnvMu8oapAUiRNXNOb/nBlYXH1BEc+Boarm8vj LElQxdI4uNEQsLvZxsL4iYvrbZ5OLZnjkMJjvU7XVFjxAkDAHT8eYH9LWK/VeiK8fm+zsDZU qy2dN77RYlQbO9TkKlJs3CR2lpT7Dr/ObtIqEf4VFOplxTY9kwARAQABzStDYXJzdGVuIFNj aG9lbmVydCA8Yy5zY2hvZW5lcnRAdC1vbmxpbmUuZGU+wsF3BBMBCAAhBQJSA05OAhsDBQsJ CAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJEIMBYBQlHR2w8DoP/2RO8DOOA/P2Bf5atiNtEbSD nPGlN5Roml4paIPoGMw42cezBekdkJ4B/Ccr2x5MigroUTYLZwxP6U7YUNVuZhRmaEjGVD35 pIklW/os+9b5srxpdHWatHC6w/OoRL0P5EtK3sHeMOrhhMsSZe/fCiXr5VetpVgNx9fdFmSs UhkiyaBar24bLNAaY3KAAnDAUxXfQxZdYZ6kxH2Wq6sypgfq1lk4TTzGUx32nmGcR/fBZmmc +ZbZPzjd3Mor9/Dg57aMt87j/MqIndHVuucAB+/lENM4ufK04DBoqHEorD2CQJvEkn7HjydE e0YNITrFkpsqbbeltIMNV6viIxQluoYjBobY+5CRvCtYr/9m5ND0tDwHesfaBY7NWkkWhCYs M+CtlyqCtSo9Y23i/ap99GSNfguVISp8nxy3i8w/ZQ44TIRv/0zEcRoYgl/iF3wB3Gug6DVa XSZKveGMc2Q1+5u9jWfC/Jvy+J1qPM9h2m5pvTwuBrdfaMGvOzCk0iqWvHUN4cZIa8io2WXD pbbnytAhqFDFYCfgpL1Q9eczVIOO3WaITAJVHGBYnLLpsgwdsIMGXyhRO9wSpC80o2HhQK90 ifpYS1VnLJLNt2D+B31uuQr6LIuq1rtUvAzM39i3ftMLCnL1jSa+6q0uVzyTWI1xsmF7g0md ulwfQ+5zLW4KzsFNBFIDTk4BEADKWf/qL0X1KWdBdTyI6qoz/1YL/hLniKAvR9J43Wtfv9EY NxRpIMGzNTOyCi/qlw0HbMo6vIxy/Tw8nTj36OjZrZQ0dFHKM66Vl4KNbA5kI0lCTj1FIjGR adMsBXWpJ44SdXF5BtAuq2/vZzYbLtjYGu5tnQrYLjGOQ0FByw3wuGnlBJVzGbbCxSB06mGa w5LXRq5HZN5zzmaiqx+z+hlOAtyo61x+gxT5BNQXGIdZkBKyzItx4OxFaiWh3JtLqSQDBkDo yzhPvEBaOFn99QUgfk4Maoj1PgFgoteKQrywY18HCtlpSMUAvX+k074kDYgrTLrh26ApECl+ bOK6P1BPWRN0uedKewnGGemJJwq2RihdpLzyHBaRlwokRH9Drs7pCsxfy9VgPCEbm7ytgzk0 EHkA7Hl/ur39TT8VLluc+zZ10xU4uuTWIBiUOeIbuJo+UVRZBFVMmsKDVQeFSi0ujz/VW/0N sW1L73406B3jYZB/bffFTGkH5acrq3cQ25Wcur92da30g5TOq3sG71+XDPVcNZgiMbDJf6tK 39rB/GjQ0Pk0O2GaiSL9tGkfjsxhZ7p5+lNCDOWWK8IAH6T7PKoIGPqRl8KmANE6qZsevgaM CWsvkJastf9a3F6ZbL15QD1qdtRebv8yhCxyikaqy8oZKWDer4pBy0oD+g9/CwARAQABwsFf BBgBCAAJBQJSA05OAhsMAAoJEIMBYBQlHR2wMKAP/iL+tk5G2vbVJCw0BKJBoMEjBedQI38l f9CeLSVtJeokIR8GkDqgTpwKJaH0/cou2Q2GUMJ5U4J/vvYFNzJk8jyT1fdC0N83HUGNKQ3H NGGcq0GQFoOHcSVeo1V77Fuf3YYhzD5mPz/ypvIvsnbuiRgxWx5meU9LfZzf8Ijzv6e67q1O G+JAKvitV4UvUo9l05ewadRg53QpWNmmRHSXflpmw0PX5C9TKsyY/Sg4DdBf2NIzktQyOxya T2yHaVuQUUQRQ0248NdA1ql7zV48ZjF1ADhagQ8bgYuGMdOW6upfUBvPqQl0poV8FwjNErex N+CUbA5inlT9oIP03LtwZoKKDuK2PojoTtGp7WZ4ryQX9i9ogUOGknAABxFg4iMBQVkyl9oF QSgHa0HlbjRj8uY1kqsO4FgrcoGiouNzEfhP5zpxvCg3BBuWngo9ApU+MXOAwuq1Gt4dzUg4 7Ir2s32nhiv5TErJzPdNrUSK/tOUZOSkOzXv1kOGbXAlhC/5a5VGfA99uFcYK899gpfB4q64 jrc3wewP0MXjVl8U004Px7sYT4BkAoCupRtmBoRWhttvbcv6T8uFMAF+j91ng0X1+n21fV+O 9wPRnD3/KJThRVMR8poUevmJbFgPfvGGmz1asVIK8tBamAZp5aCeqZ7HVkTmMbj1x07Ry7o0 iWLO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Toi-Expurgateid: 150726::1735199085-95FF8A55-19F54586/0/0 CLEAN NORMAL X-Toi-Msgid: 5f0a8186-4340-489a-8d0f-bab125ce1ab6 X-Mailing-List: archive/latest/22722 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/dabd8087-e135-4830-beab-7a97dfedb249@t-online.de Approved: robomod@news.nic.it Lines: 94 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Thu, 26 Dec 2024 09:44:42 +0200 X-Original-Message-ID: X-Original-References: <87jzbqsjq4.fsf__16847.3339335591$1734954690$gmane$org@kaka.sjd.se> <87o70zwauh.fsf@kaka.sjd.se> Xref: csiph.com linux.debian.maint.python:16629 Hello Simon, Am 26.12.24 um 02:23 schrieb Simon Josefsson: > Hi. I'm struggling with packaging for this package: > > https://salsa.debian.org/python-team/packages/python-genson ... > Why doesn't pybuild do the right thing by default? on which base pybuild could make the right decision? pybuild is doing what it need and should do. The missing installation of the subfolder looks to me like an upstream issue. If the folder is needed for later usage it needs to get installed by setuptools. > Any ideas how to resolve? > > Feel free to clone the project and/or push to it to experiment. I'll > take a little break from this package now... > > jas@kaka:~/dpkg/python-genson$ git diff debian/latest..hack > diff --git a/debian/rules b/debian/rules > index a1954a9..1658f7b 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -3,6 +3,7 @@ > include /usr/share/dpkg/pkg-info.mk # DEB_VERSION > > #export PYBUILD_NAME = genson > +export PYBUILD_TEST_ARGS= -k 'not test_no_input' > > %: > dh $@ --buildsystem=pybuild > @@ -10,8 +11,9 @@ include /usr/share/dpkg/pkg-info.mk # DEB_VERSION > B = $(CURDIR)/debian/tmp/usr/bin > M = $(CURDIR)/debian/tmp/usr/share/man/man1 > > -override_dh_auto_test: > - -dh_auto_test $(DH_BUILD_OPTS) > +execute_before_dh_auto_test: > + cp -rv genson/schema .pybuild/cpython3_3.12/build/genson/ > + cp -rv genson/schema .pybuild/cpython3_3.13/build/genson/ > > execute_after_dh_auto_install: > ifeq (,$(filter nodoc,$(DEB_BUILD_PROFILES))) > jas@kaka:~/dpkg/python-genson$ You can simplify this all by using the variable PYBUILD_BEFORE_TEST > $ git diff debian/rules > diff --git a/debian/rules b/debian/rules > index a1954a9..77ab492 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -2,7 +2,9 @@ > > include /usr/share/dpkg/pkg-info.mk # DEB_VERSION > > -#export PYBUILD_NAME = genson > +export PYBUILD_NAME = genson > +export PYBUILD_BEFORE_TEST = cp -rv {dir}/genson/schema {build_dir}/$(PYBUILD_NAME) > +export PYBUILD_TEST_ARGS= -k 'not test_no_input' > > %: > dh $@ --buildsystem=pybuild > @@ -10,9 +12,6 @@ include /usr/share/dpkg/pkg-info.mk # DEB_VERSION > B = $(CURDIR)/debian/tmp/usr/bin > M = $(CURDIR)/debian/tmp/usr/share/man/man1 > > -override_dh_auto_test: > - -dh_auto_test $(DH_BUILD_OPTS) > - > execute_after_dh_auto_install: > ifeq (,$(filter nodoc,$(DEB_BUILD_PROFILES))) > mkdir -pv $(M) And I personally would introduce another small package with just the binary genson. To mee it's totally fine it's serverd by the package python3-genson. It's done very often within other Python binary packages. And if you define and use own variables in the file d/rules please speaking namings. B and M are hard to read and for me using one character variable name is a bad habit. I would drop them completely, they are used just one time! -- Regards Carsten Schönert