Path: csiph.com!news.neodome.net!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod
From: weepingclown <weepingclown@disroot.org>
Newsgroups: linux.debian.maint.python
Subject: Re: Upload request: psrecord (NEW)
Date: Sun, 08 Dec 2024 19:50:01 +0100
Message-ID: <JRuvT-eUmy-3@gated-at.bofh.it>
References: <JBbQB-3XYB-7@gated-at.bofh.it> <JMo7L-bhbj-9@gated-at.bofh.it> <JMo7L-bhbj-7@gated-at.bofh.it> <JMCDL-bqol-15@gated-at.bofh.it> <JNwcW-c3lM-9@gated-at.bofh.it> <JOruy-cIUu-9@gated-at.bofh.it> <JOViV-d1FM-9@gated-at.bofh.it> <JOViV-d1FM-7@gated-at.bofh.it> <JRadP-evkz-5@gated-at.bofh.it> <JRadP-evkz-7@gated-at.bofh.it> <JRadP-evkz-3@gated-at.bofh.it> <JRsNr-eR4M-5@gated-at.bofh.it> <JRsNr-eR4M-3@gated-at.bofh.it> <JRtq9-eSyU-15@gated-at.bofh.it>
X-Original-To: debian-python@lists.debian.org
X-Mailbox-Line: From debian-python-request@lists.debian.org  Sun Dec  8 18:43:29 2024
Old-Return-Path: <weepingclown@disroot.org>
X-Amavis-Spam-Status: No, score=-7.198 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
X-Policyd-Weight: using cached result; rate:hard: -4.6
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Mailing-List: <debian-python@lists.debian.org> archive/latest/22653
List-ID: <debian-python.lists.debian.org>
List-URL: <https://lists.debian.org/debian-python/>
List-Archive: https://lists.debian.org/msgid-search/C424BDB8-80D0-43E9-A697-109F03CB6E83@disroot.org
Approved: robomod@news.nic.it
Lines: 37
Organization: linux.* mail to news gateway
Sender: robomod@news.nic.it
X-Original-Date: Sun, 08 Dec 2024 18:43:06 +0000
X-Original-Message-ID: <C424BDB8-80D0-43E9-A697-109F03CB6E83@disroot.org>
X-Original-References: <f3b17ed93c6c77aefec29e6b0d5cde405f6dd01a.camel@gmail.com> <a6b20a60e9e02d8d8b3113fe3b3f44a5d3795b13.camel@gmail.com> <80fe104d-453c-4555-b656-c3123a3bbe35@debian.org> <2f0bf5b0ed4df279b81295343eacf66f9d5ddf35.camel@gmail.com> <b8aec14e-ce50-4b4b-a87a-bd796c6ad0ac@debian.org> <3145534b-cf5e-4cd9-b0f6-23133f24914a@debian.org> <b8ce9f2d7f0a2ade742f3804109543a1bde39382.camel@gmail.com> <e9da7171-880a-47e7-abf3-7954675596e1@debian.org> <c2b8dbda97826df20c71237735b153edb12a6983.camel@gmail.com> <606c0e77e2ef7a267919957015dccc7d2bb51e7f.camel@gmail.com> <735d8e62-33ed-47c1-a64a-c5a7800f09fc@debian.org> <78dd4de9-1eea-4e3a-a284-0d7ae64f0e0f@web.de> <FBB4E291-0FF4-4D6B-A684-79FB6672B2BF@disroot.org> <0f87d667-6649-4a9b-8cc6-92c1724e8bf2@debian.org>
Xref: csiph.com linux.debian.maint.python:16563

Hi Peter,

I believe the previous way of doing this was -

override_dh_foo:
    dh_foo
    <do stuff>

which is now less verbose if you want -

execute_after_dh_foo:
    <do stuff>

or execute_before, when you need that=2E

My understanding is that there is no added benefit than less verbosity and=
 maybe more clarity (since it tells you in a first glance that it should ru=
n before/after dh_foo)=2E So yes, nothing problematic as long as you still =
have dh_foo there once you use override_dh_foo, but these execute_* targets=
 feel much better to me=2E tbph, overriding a target only to run the exact =
same thing again makes me feel stupid each time, so I change the older patt=
ers whenever I come across them in a package :p

Best,
Ananthu

On 8 December 2024 5:36:32 pm UTC, Peter Wienemann <wiene@debian=2Eorg> wr=
ote:
>As long as the override_dh_auto_clean target still contains dh_auto_clean=
 the original functionality should be retained=2E At least this is my under=
standing=2E Please correct me if this is wrong=2E But you are perfectly rig=
ht that using execute_after_dh_auto_clean is less error-prone=2E Thanks for=
 this suggestion=2E I added it to my notes=2E :-)
>
>Best regards
>
>Peter