Path: csiph.com!news.samoylyk.net!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Simon Josefsson Newsgroups: linux.debian.maint.python Subject: Re: python-sigstore / python-tuf: request for packaging help Date: Fri, 06 Dec 2024 17:00:02 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Fri Dec 6 15:50:24 2024 Old-Return-Path: X-Amavis-Spam-Status: No, score=-14.4 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -4.6 Openpgp: id=B1D2BD1375BECB784CF4F8C4D73CF638C53C06BE; url=https://josefsson.org/key-20190320.txt X-Hashcash: 1:23:241206:wrar@debian.org::gYZoiU2RNFWoWLjo:wvBo X-Hashcash: 1:23:241206:debian-python@lists.debian.org::zGO90W3tbY0xsghW:i3ZS User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Mailing-List: archive/latest/22631 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/87h67grets.fsf@kaka.sjd.se Approved: robomod@news.nic.it Lines: 102 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Fri, 06 Dec 2024 16:50:07 +0100 X-Original-Message-ID: <87h67grets.fsf@kaka.sjd.se> X-Original-References: <878qstsqjn.fsf@kaka.sjd.se> Xref: csiph.com linux.debian.maint.python:16546 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Andrey Rakhmatullin writes: > On Thu, Dec 05, 2024 at 11:39:24PM +0100, Simon Josefsson wrote: >> The self-tests tries seems to open some files which fails and I suspect >> it is because srcdir !=3D builddir reasons, or something similar, see >> errors here: >>=20 >> https://salsa.debian.org/jas/python-tuf/-/jobs/6707693 >>=20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ERRORS =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D >> ______________ ERROR collecting tests/test_metadata_generation.py ______= ________ >> tests/test_metadata_generation.py:10: in >> from tests.generated_data.generate_md import generate_all_files >> tests/generated_data/generate_md.py:60: in >> os.mkdir(OUT_DIR) >> E FileNotFoundError: [Errno 2] No such file or directory: 'generated_d= ata/ed25519_metadata' >>=20 >> How is this (seamingly common) problem solved normally? Do we copy test >> data files into the build directory somehow? Do we include them in the >> package? Do we patch hard-coded paths like this to make it work? > > It's not common and test data files are already copied because they are > under tests/. It's because of relative paths and I can reproduce this > problem by running pytest in the upstream's git checkout. You are right, I reported it upstream: https://github.com/theupdateframework/python-tuf/issues/2745 I disabled that self-check meanwhile, and got a bit further: collected 184 items tests/test_api.py .................................... [ = 19%] tests/test_examples.py FFF [ = 21%] tests/test_fetcher_ng.py FFFF.FFFF... [ = 27%] tests/test_metadata_eq_.py .... [ = 29%] tests/test_metadata_serialization.py ......................... [ = 43%] tests/test_repository.py ........ [ = 47%] tests/test_trusted_metadata_set.py .......................... [ = 61%] tests/test_updater_consistent_snapshot.py ... [ = 63%] tests/test_updater_delegation_graphs.py ...... [ = 66%] tests/test_updater_fetch_target.py ..... [ = 69%] tests/test_updater_key_rotations.py .. [ = 70%] tests/test_updater_ng.py .FF.FF.F.FFFF [ = 77%] tests/test_updater_top_level_update.py ................................. [ = 95%] ... [ = 97%] tests/test_updater_validation.py .. [ = 98%] tests/test_utils.py F.. [1= 00%] ... =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 21 failed, 163 passe= d, 5 warnings in 5.39s =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D See full log: https://salsa.debian.org/jas/python-tuf/-/jobs/6710680/viewer Several failures seems related to not being able to find some test file, any ideas how to fix this further? I'll see if I can figure out how to disable only the failing tests, pending some better fix. It seems a large portion of the self-tests now work so I think this is in good enough shape for an upload to NEW. /Simon --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIoEARYIADIWIQSjzJyHC50xCrrUzy9RcisI/kdFogUCZ1MdLxQcc2ltb25Aam9z ZWZzc29uLm9yZwAKCRBRcisI/kdForiJAQCoUkLXAQGLcaRIkDXghi03mdBZ8vZD md4pyjqNw/EySQEA1Gd66hDfwBvbbr1rYZjCw6YAUtYtPR+Emjs33mYEHQw= =KSnd -----END PGP SIGNATURE----- --=-=-=--