Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: Komal Sukhani Newsgroups: linux.debian.maint.java Subject: Re: Review of cmdreader package Date: Sat, 22 Aug 2015 10:00:02 +0200 Message-ID: References: X-Original-To: Hans-Christoph Steiner X-Mailbox-Line: From debian-java-request@lists.debian.org Sat Aug 22 07:56:39 2015 Old-Return-Path: X-Amavis-Spam-Status: No, score=-5.779 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=2, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_LOW=-0.7] autolearn=no autolearn_force=no X-Policyd-Weight: using cached result; rate: -7 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=YYIyf7fsx76nKa+HKBH79u64Pojze+h72zSkNMAexpA=; b=ZyU6Oyrodei3nRaD9LsOpZtQLp6f9YqijUyKSjGwIlZGQ+a7Lm+91P0+0HKg+KwCjn EPdr8R854zjI6X/mXQ3lWN7SRwMhnuTg3yRdJh5T6hsPkrcYYL14XHza8kh/Sek/QBK3 WZjS64gkqdq8+GUhTY+STBMXeAZaYw7nWsIZ6EgBgvqrHizzhI4eb+P8LOVqwRXgbUsw t1qlPEo+fxZC1x87SMRIAeUI/ciWs+iT6r5TdB1sayH5SReVlDC1IIfNW4KYMnnUGIsN ci0eqpstaDCv3TqRV5c1k8fKs6INkEEx0fMzlq7wywz6n3uk8EYK+f2SawxSaqkBfmC/ nnHQ== MIME-Version: 1.0 X-Received: by 10.112.17.70 with SMTP id m6mr11546536lbd.113.1440230181872; Sat, 22 Aug 2015 00:56:21 -0700 (PDT) Content-Type: multipart/alternative; boundary=001a11c3d3e262aaec051de1b86a X-Mailing-List: archive/latest/18590 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CAA0p-ueGhadoyoSXKdTPgQ3C1Q_W1KZ=Mh7FT_OfYdUKdrqnMA@mail.gmail.com Approved: robomod@news.nic.it Lines: 309 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Markus Koschany , =?UTF-8?B?5q635ZWf6IGw?= , debian-java@lists.debian.org X-Original-Date: Sat, 22 Aug 2015 13:26:21 +0530 X-Original-Message-ID: X-Original-References: <55C0B06A.4060006@at.or.at> <55D46203.3050306@at.or.at> Xref: csiph.com linux.debian.maint.java:8278 --001a11c3d3e262aaec051de1b86a Content-Type: text/plain; charset=UTF-8 Hi Hans, Ant was searching for ivy.jar in /usr/share/ant/lib and -/tmp/buildd/.ant/lib. This was causing the problem. I have corrected rules file by providing location of ivy.jar to ant with 'lib' flag. I think there won't be any problem now. As you suggested, I have added my name in uploaders field. On Wed, Aug 19, 2015 at 4:31 PM, Hans-Christoph Steiner wrote: > > Komal Sukhani: > > Hi Hans, > > > > On Tue, Aug 4, 2015 at 6:00 PM, Hans-Christoph Steiner > > wrote: > > > >> > >> Hey Komal, > >> > >> Looks good overall. You seem to be getting much quicker at packaging > :) I > >> pushed some commits to fix some minor things. Here are some open > issues: > >> > >> I am glad to know that you are happy with my progress. > > > > > >> * its not building for me, perhaps there is a missing Build-Depends: > like > >> 'ivy' or something else? Here's the error: > >> > >> debian/rules build > >> dh build > >> dh_testdir > >> dh_auto_configure > >> dh_auto_build > >> ant > >> Buildfile: /tmp/buildd/cmdreader-1.5/build.xml > >> > >> config-ivy: > >> > >> BUILD FAILED > >> /tmp/buildd/cmdreader-1.5/build.xml:66: Problem: failed to create task > or > >> type > >> antlib:org.apache.ivy.ant:configure > >> Cause: The name is undefined. > >> Action: Check the spelling. > >> Action: Check that any custom tasks/types have been declared. > >> Action: Check that any / declarations have taken > >> place. > >> No types or tasks have been defined in this namespace yet > >> > >> This appears to be an antlib declaration. > >> Action: Check that the implementing library exists in one of: > >> -/usr/share/ant/lib > >> -/tmp/buildd/.ant/lib > >> -a directory added on the command line with the -lib argument > >> > >> > >> Total time: 0 seconds > >> dh_auto_build: ant returned exit code 1 > >> debian/rules:7: recipe for target 'build' failed > >> make: *** [build] Error 2 > >> dpkg-buildpackage: error: debian/rules build gave error exit status 2 > >> E: Failed autobuilding of package > >> > >> > >> The build was failing due to missing ivy package. I have added ivy in > > build-depends. > > I tried your latest commits and I still get the same error. Are you able > to > build this? Does it require packages or package versions that are only in > experimental? > > > >> * The whole debian/ directory got included into git after a build was > run. > >> That means that all of the build products where included as well, they > >> shouldn't be. I removed them, and added a debian/.gitignore file so > that > >> they > >> are can't be committed to git. > >> > >> * add_hamcrest.patch is 0 bytes, either the contents are missing or it > >> should > >> be removed > >> > >> > > I have made all above changes and have pushed those on Alioth. > > > > > >> * Since this is a java package, I recommend adding it as part of the > Java > >> team > >> (I cc'ed the list) by setting the Maintainer: field. But you are of > course > >> welcome to keep yourself as the maintainer. > >> > >> I would love to be a Debian Maintainer. Do I need to do anything for > > becoming a Maintainer? > > You can set yourself as Maintainer: if you want to be the only maintainer > for > the package. You can add yourself to Uploaders: to mark that you have > worked > on the package, then set Maintainer: to the pkg-java line used in other > pkg-java packages. That marks the package as a "team" package, meaning you > are encouraging others to work on it as well. > > > .hc > > > > > >> * I pushed a trivial commit to use the canonical, HTTPS URLs for git. > >> > >> .hc > >> > >> Komal Sukhani: > >>> Hi all, > >>> > >>> I have packaged cmdreader > >>> , which is > >>> dependency of lombok-ast, and have > >>> uploaded my code to Alioth. > >>> > >>> Can you please review that package? > >>> > >>> Now I am working on lombok which is also required by lombok-ast. > >>> > >>> Komal Sukhani > >>> > >> > > > --001a11c3d3e262aaec051de1b86a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Hans,

Ant was searchin= g for ivy.jar in /usr/share/ant/lib and -/tmp/buildd/.ant/lib. This was cau= sing the problem.
I have corrected rules file by providing locatio= n of ivy.jar to ant with 'lib' flag. I think there won't be any=
problem now.

As you suggested, I have added my name = in uploaders field.


On Wed, Aug 19, 2015 at 4:31 PM, Hans-Christoph Steiner <hans= @at.or.at> wrote:

Komal Sukhani:
> Hi Hans,
>
> On Tue, Aug 4, 2015 at 6:00 PM, Hans-Christoph Steiner <hans@at.or.at>
> wrote:
>
>>
>> Hey Komal,
>>
>> Looks good overall.=C2=A0 You seem to be getting much quicker at p= ackaging :)=C2=A0 I
>> pushed some commits to fix some minor things.=C2=A0 Here are some = open issues:
>>
>> I am glad to know that you are happy with my progress.
>
>
>> * its not building for me, perhaps there is a missing Build-Depend= s: like
>> 'ivy' or something else?=C2=A0 Here's the error:
>>
>>=C2=A0 debian/rules build
>> dh build
>>=C2=A0 =C2=A0 dh_testdir
>>=C2=A0 =C2=A0 dh_auto_configure
>>=C2=A0 =C2=A0 dh_auto_build
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ant
>> Buildfile: /tmp/buildd/cmdreader-1.5/build.xml
>>
>> config-ivy:
>>
>> BUILD FAILED
>> /tmp/buildd/cmdreader-1.5/build.xml:66: Problem: failed to create = task or
>> type
>> antlib:org.apache.ivy.ant:configure
>> Cause: The name is undefined.
>> Action: Check the spelling.
>> Action: Check that any custom tasks/types have been declared.
>> Action: Check that any <presetdef>/<macrodef> declarat= ions have taken
>> place.
>> No types or tasks have been defined in this namespace yet
>>
>> This appears to be an antlib declaration.
>> Action: Check that the implementing library exists in one of:
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-/usr/share/ant/lib
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-/tmp/buildd/.ant/lib
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-a directory added on the command= line with the -lib argument
>>
>>
>> Total time: 0 seconds
>> dh_auto_build: ant returned exit code 1
>> debian/rules:7: recipe for target 'build' failed
>> make: *** [build] Error 2
>> dpkg-buildpackage: error: debian/rules build gave error exit statu= s 2
>> E: Failed autobuilding of package
>>
>>
>> The build was failing due to missing ivy package. I have added ivy= in
> build-depends.

I tried your latest commits and I still get the same error.=C2= =A0 Are you able to
build this?=C2=A0 Does it require packages or package versions that are onl= y in
experimental?


>> * The whole debian/ directory got included into git after a build = was run.
>> That means that all of the build products where included as well, = they
>> shouldn't be.=C2=A0 I removed them, and added a debian/.gitign= ore file so that
>> they
>> are can't be committed to git.
>>
>> * add_hamcrest.patch is 0 bytes, either the contents are missing o= r it
>> should
>> be removed
>>
>>
> I have made all above changes and have pushed those on Alioth.
>
>
>> * Since this is a java package, I recommend adding it as part of t= he Java
>> team
>> (I cc'ed the list) by setting the Maintainer: field.=C2=A0 But= you are of course
>> welcome to keep yourself as the maintainer.
>>
>> I would love to be a Debian Maintainer. Do I need to do anything f= or
> becoming a Maintainer?

You can set yourself as Maintainer: if you want to be the only maint= ainer for
the package.=C2=A0 You can add yourself to Uploaders: to mark that you have= worked
on the package, then set Maintainer: to the pkg-java line used in other
pkg-java packages.=C2=A0 That marks the package as a "team" packa= ge, meaning you
are encouraging others to work on it as well.


=C2=A0
.hc




>> * I pushed a trivial commit to use the canonical, HTTPS URLs for g= it.
>>
>> .hc
>>
>> Komal Sukhani:
>>> Hi all,
>>>
>>> I have packaged cmdreader
>>> <https://github.com/rzwitse= rloot/com.zwitserloot.cmdreader>, which is
>>> dependency of lombok-ast, and have
>>> uploaded my code to Alioth.
>>>
>>> Can you please review that package?
>>>
>>> Now I am working on lombok which is also required by lombok-as= t.
>>>
>>> Komal Sukhani
>>>
>>
>

--001a11c3d3e262aaec051de1b86a--