Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From: Hans-Christoph Steiner <hans@at.or.at>
Newsgroups: linux.debian.maint.java
Subject: Re: Review of cmdreader package
Date: Wed, 19 Aug 2015 13:10:02 +0200
Message-ID: <pZ9pM-45B-15@gated-at.bofh.it>
References: <pTQe6-3ei-5@gated-at.bofh.it> <pTQe6-3ei-7@gated-at.bofh.it> <pTQe6-3ei-3@gated-at.bofh.it>
X-Original-To: Komal Sukhani <komaldsukhani@gmail.com>
X-Mailbox-Line: From debian-java-request@lists.debian.org  Wed Aug 19 11:01:47 2015
Old-Return-Path: <hans@at.or.at>
X-Amavis-Spam-Status: No, score=-7.68 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
X-Policyd-Weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .at. - helo: .out3-smtp.messagingengine. - helo-domain: .messagingengine.)  FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -7
Dkim-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=2TSyvEx9jH/sCOB 7XKKjXhn66iw=; b=k+EmMW5oTJHMeUf2rtvY7E7qoyc/Hxkx0hQffltkfCwOFkJ 4sGasbZ0IwzSbHDTzGut9G3TJLlSaL/l+qN8nIsVD/82cfYLo8jlce11DjSnhRE9 lW5SeqPrbYhlIRcdZepkKC5DbFzVPzxepEEUwcqFlZHtxjOgE+ZV1be6MTKQ=
X-Sasl-Enc: YdmapTSfZMq64CLrgssZG8o94ITRNRzjPbkMwclvfY6k 1439982085
Organization: @||@
MIME-Version: 1.0
Openpgp: url=http://pgp.surfnet.nl:11371/pks/lookup?op=get&search=0x9F0FE587374BBE81
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Mailing-List: <debian-java@lists.debian.org> archive/latest/18574
List-ID: <debian-java.lists.debian.org>
List-URL: <https://lists.debian.org/debian-java/>
List-Archive: https://lists.debian.org/55D46203.3050306@at.or.at
Approved: robomod@news.nic.it
Lines: 116
Sender: robomod@news.nic.it
X-Original-Cc: Markus Koschany <apo@gambaru.de>, =?UTF-8?B?5q635ZWf6IGw?= <seamlikok@gmail.com>, debian-java@lists.debian.org
X-Original-Date: Wed, 19 Aug 2015 13:01:23 +0200
X-Original-Message-ID: <55D46203.3050306@at.or.at>
X-Original-References: <CAA0p-ufLZyT01cBM=D1D9cyrUwLne_+cT_pEf_PXE3kc22XB3w@mail.gmail.com>	<55C0B06A.4060006@at.or.at> <CAA0p-ufH2+jQedje74Mg1Jp15asunQOkwrK+pzW6j-H_ZfzMVg@mail.gmail.com>
Xref: csiph.com linux.debian.maint.java:8263


Komal Sukhani:
> Hi Hans,
> 
> On Tue, Aug 4, 2015 at 6:00 PM, Hans-Christoph Steiner <hans@at.or.at>
> wrote:
> 
>>
>> Hey Komal,
>>
>> Looks good overall.  You seem to be getting much quicker at packaging :)  I
>> pushed some commits to fix some minor things.  Here are some open issues:
>>
>> I am glad to know that you are happy with my progress.
> 
> 
>> * its not building for me, perhaps there is a missing Build-Depends: like
>> 'ivy' or something else?  Here's the error:
>>
>>  debian/rules build
>> dh build
>>    dh_testdir
>>    dh_auto_configure
>>    dh_auto_build
>>         ant
>> Buildfile: /tmp/buildd/cmdreader-1.5/build.xml
>>
>> config-ivy:
>>
>> BUILD FAILED
>> /tmp/buildd/cmdreader-1.5/build.xml:66: Problem: failed to create task or
>> type
>> antlib:org.apache.ivy.ant:configure
>> Cause: The name is undefined.
>> Action: Check the spelling.
>> Action: Check that any custom tasks/types have been declared.
>> Action: Check that any <presetdef>/<macrodef> declarations have taken
>> place.
>> No types or tasks have been defined in this namespace yet
>>
>> This appears to be an antlib declaration.
>> Action: Check that the implementing library exists in one of:
>>         -/usr/share/ant/lib
>>         -/tmp/buildd/.ant/lib
>>         -a directory added on the command line with the -lib argument
>>
>>
>> Total time: 0 seconds
>> dh_auto_build: ant returned exit code 1
>> debian/rules:7: recipe for target 'build' failed
>> make: *** [build] Error 2
>> dpkg-buildpackage: error: debian/rules build gave error exit status 2
>> E: Failed autobuilding of package
>>
>>
>> The build was failing due to missing ivy package. I have added ivy in
> build-depends.

I tried your latest commits and I still get the same error.  Are you able to
build this?  Does it require packages or package versions that are only in
experimental?


>> * The whole debian/ directory got included into git after a build was run.
>> That means that all of the build products where included as well, they
>> shouldn't be.  I removed them, and added a debian/.gitignore file so that
>> they
>> are can't be committed to git.
>>
>> * add_hamcrest.patch is 0 bytes, either the contents are missing or it
>> should
>> be removed
>>
>>
> I have made all above changes and have pushed those on Alioth.
> 
> 
>> * Since this is a java package, I recommend adding it as part of the Java
>> team
>> (I cc'ed the list) by setting the Maintainer: field.  But you are of course
>> welcome to keep yourself as the maintainer.
>>
>> I would love to be a Debian Maintainer. Do I need to do anything for
> becoming a Maintainer?

You can set yourself as Maintainer: if you want to be the only maintainer for
the package.  You can add yourself to Uploaders: to mark that you have worked
on the package, then set Maintainer: to the pkg-java line used in other
pkg-java packages.  That marks the package as a "team" package, meaning you
are encouraging others to work on it as well.

.hc




>> * I pushed a trivial commit to use the canonical, HTTPS URLs for git.
>>
>> .hc
>>
>> Komal Sukhani:
>>> Hi all,
>>>
>>> I have packaged cmdreader
>>> <https://github.com/rzwitserloot/com.zwitserloot.cmdreader>, which is
>>> dependency of lombok-ast, and have
>>> uploaded my code to Alioth.
>>>
>>> Can you please review that package?
>>>
>>> Now I am working on lombok which is also required by lombok-ast.
>>>
>>> Komal Sukhani
>>>
>>
>