Hi Hans,

On Tue, Aug 4, 2015 at 6:00 PM, Hans-Christoph Steiner <hans@= at.or.at> wrote:

Hey Komal,

Looks good overall.=C2=A0 You seem to be getting much quicker at packaging = :)=C2=A0 I
pushed some commits to fix some minor things.=C2=A0 Here are some open issu= es:

I am glad to know that you are happy with my progress= .

=C2=A0

* its not building for me, perhaps there is a missing Build-Depends: like 'ivy' or something else?=C2=A0 Here's the error:

=C2=A0debian/rules build
dh build
=C2=A0 =C2=A0dh_testdir
=C2=A0 =C2=A0dh_auto_configure
=C2=A0 =C2=A0dh_auto_build
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ant
Buildfile: /tmp/buildd/cmdreader-1.5/build.xml

config-ivy:

BUILD FAILED
/tmp/buildd/cmdreader-1.5/build.xml:66: Problem: failed to create task or t= ype
antlib:org.apache.ivy.ant:configure
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have= taken place.
No types or tasks have been defined in this namespace yet

This appears to be an antlib declaration.
Action: Check that the implementing library exists in one of:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -/usr/share/ant/lib
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -/tmp/buildd/.ant/lib
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -a directory added on the command line with the= -lib argument

Total time: 0 seconds
dh_auto_build: ant returned exit code 1
debian/rules:7: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package

The build was failing due to missing ivy package. I h= ave added ivy in build-depends.

=C2=A0

* The whole debian/ directory got included into git after a build was run.<= br> That means that all of the build products where included as well, they
shouldn't be.=C2=A0 I removed them, and added a debian/.gitignore file = so that they
are can't be committed to git.

* add_hamcrest.patch is 0 bytes, either the contents are missing or it shou= ld
be removed

I have made all above changes and have= pushed those on Alioth.
=C2=A0

* Since this is a java package, I recommend adding it as part of the Java t= eam
(I cc'ed the list) by setting the Maintainer: field.=C2=A0 But you are = of course
welcome to keep yourself as the maintainer.

I would love to be a Debian Maintainer. Do I need to = do anything for becoming a Maintainer?
=C2=A0

* I pushed a trivial commit to use the canonical, HTTPS URLs for git.

.hc

Komal Sukhani:
> Hi all,
>
> I have packaged cmdreader
> <https://github.com/rzwitser= loot/com.zwitserloot.cmdreader>, which is

> dependency of lombok-ast, and = have
> uploaded my code to Alioth.
>
> Can you please review that package?
>
> Now I am working on lombok which is also required by lombok-ast.
>
> Komal Sukhani
>