Path: csiph.com!1.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!news-1.dfn.de!news-2.dfn.de!news.dfn.de!fu-berlin.de!bofh.it!news.nic.it!robomod From: =?UTF-8?B?SsOpcsO0bWUgQ2hhcmFvdWk=?= Newsgroups: linux.debian.maint.java Subject: Re: Bug#1054361: ITP: jruby-jzlib Date: Tue, 24 Oct 2023 16:30:01 +0200 Message-ID: References: X-Original-To: Emmanuel Bourg , debian-java@lists.debian.org X-Mailbox-Line: From debian-java-request@lists.debian.org Tue Oct 24 14:29:15 2023 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7.8 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, FVGT_m_MULTI_ODD=0.02, LDO_WHITELIST=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -4.6 X-Riseup-User-ID: 103C185DA77FB311C8493EE5D9B781FDA5C27A5FEB29F6A9DAE5EDEE7E5A8439 MIME-Version: 1.0 Content-Language: fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailing-List: archive/latest/23398 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/b1b3940c-d37a-43ae-8394-03700c170922@riseup.net Approved: robomod@news.nic.it Lines: 44 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Tue, 24 Oct 2023 10:28:49 -0400 X-Original-Message-ID: X-Original-References: <08e5cc7f-a158-4af5-9fe7-e0a5cf74d8bf@riseup.net> <63f1b611-474a-4541-aea4-750d13fb9c9b@riseup.net> Xref: csiph.com linux.debian.maint.java:12714 Hi Emmanuel, Le 2023-10-24 à 10 h 02, Emmanuel Bourg a écrit : > Hi Jérôme, > > Le 24/10/2023 à 15:18, Jérôme Charaoui a écrit : > >> I've prepared the jruby-jzlib package, but I'm uncertain about the >> relationship it should have with jzlib. >> >> Since the module itself is still using the same "com.jcraft" >> namespace, I'm thinking of using a Conflicts: and Provides: on >> libjzlib-java. > > No that's not necessary, because the libjzlib-java and > libjruby-jzlib-java packages do not conflict at the filesystem level. > The Conflicts field doesn't cover classpath conflicts. Right, my thinking was to use the same path usj/jzlib.jar to signal the classpath conflict. Otherwise, we can install it to usj/jruby-jzlib.jar and not make the packages conflict, but I'm not sure what would happen if both were installed at the same time, at the JVM-level. >> You can check out the package here: >> https://salsa.debian.org/lavamind/jruby-jzlib > > I got a quick look at the jzlib fork [1] and there are very few changes > compared to the original project, it just adds a JPMS auto module name. > We could simply patch our existing jzlib package instead of introducing > a new one. On the jruby side, that would mean patching the Maven > coordinates of jzlib (org.jruby:jzlib -> com.jcraft:jzlib). There are some (small) code changes as well, here is a pkgdiff report: https://paste.lib3.net/lavamind/2023-10-24-gBV6KdXXUJ4R0DlxXjjnjz0RmA9OCJ6goNYKux5c03M/changes_report.html In addition, I believe there may be more substantive changes in the future since there are zlib-related bugs reported against JRuby which may lead to further changes in jruby-jzlib, see https://github.com/jruby/jruby/issues/6613 Thanks, -- Jérôme