Path: csiph.com!1.us.feeder.erje.net!3.us.feeder.erje.net!2.eu.feeder.erje.net!feeder.erje.net!fu-berlin.de!bofh.it!news.nic.it!robomod From: Vladimir Petko Newsgroups: linux.debian.maint.java Subject: Re: help with plugin versions and maven-debian-helper Date: Thu, 09 Feb 2023 23:20:02 +0100 Message-ID: References:

X-Mailbox-Line: From debian-java-request@lists.debian.org Thu Feb 9 22:16:03 2023 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7.481 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5.5 X-Gm-Message-State: AO0yUKV6nioaaQJ8oI6lnKkjypWgtboEx52SbDs6BynS6rwrfjrMzyze 0twzlPnhhfCU7e+FDHTLRKLWNxJ+/uzDesvSJ52LNifUo5n23lLDeYdKff7834Xfqlv4oeSB8v+ iniBzTrzFaPUtLi5X1t2jq3V6kbh4C4A6Ek06myR+sXt+qDLm74R+AVSAOw== X-Received: by 2002:aa7:9410:0:b0:5a8:5868:6e9a with SMTP id x16-20020aa79410000000b005a858686e9amr709440pfo.38.1675980939680; Thu, 09 Feb 2023 14:15:39 -0800 (PST) X-Google-SMTP-Source: AK7set+WzMkg/fkcv1F71MFhC3sYSZBIl3zqa28oIr/I3Ymp0M5tl4aWMSrpWRQoUvkrEU3pTF1IR0F2/MNMVJOOWc0= X-Received: by 2002:aa7:9410:0:b0:5a8:5868:6e9a with SMTP id x16-20020aa79410000000b005a858686e9amr709437pfo.38.1675980939313; Thu, 09 Feb 2023 14:15:39 -0800 (PST) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000089eb2505f44bb832" X-Mailing-List: archive/latest/23194 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CALFf3kdKkq_6vPY_zgv=OPAOhzZPtyWQj5L0gWR+Pv1zH+uNzg@mail.gmail.com Approved: robomod@news.nic.it Lines: 99 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Joe Nahmias , debian-java@lists.debian.org X-Original-Date: Fri, 10 Feb 2023 11:15:28 +1300 X-Original-Message-ID: X-Original-References: <5727dc243076178631326e380aa5ac10@apache.org>

<775eae911ef06536b5f24424e4c91ae2@apache.org> Xref: csiph.com linux.debian.maint.java:12543 --00000000000089eb2505f44bb832 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Sorry for jumping into the discussion, but it looks like maven-helper deploys jar files slightly incorrectly. It places .jar in /usr/share/java and then creates a symlink -.jar to it, rather than place -.jar and create a symlink .jar. Would it be ok to submit a patch for that? Best Regards, Vladimir. On Fri, Feb 10, 2023 at 11:07 AM Emmanuel Bourg wrote: > Le 2023-02-09 19:39, Joe Nahmias a =C3=A9crit : > > > Thanks for all your help. I think I managed to figure this out finally. > > I've put my repo on salsa here: > > https://salsa.debian.org/java-team/jackson-modules-java8 > > > > Anyone care to do a(n in-depth) review before I upload? > > Great! Here is my review: > > - Don't build the -java-doc package, that's useless > - The Maven wrapper should be removed (mwn* and .mvn/wrapper/*) > - I'd use the default gbp branch layout (master/upstream/pristine-tar) > instead of the DEP 14 layout (debian/latest). Most Java packages > follow the gbp layout and it's important all packages remain > consistent. > - Drop the +ds suffix > - debian/changelog doesn't close an ITP bug > - Why declaring a Provides field on virtual packages? That's unusual > > The content of the binary package is perfect. Nice trick in > debian/control > to reuse the same description, I didn't know that was possible. > > Emmanuel Bourg > > --00000000000089eb2505f44bb832 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi,

=C2=A0Sorry for jumping into the discussion, b= ut it looks like maven-helper deploys
=C2=A0jar files slightly incorrec= tly. It places <package>.jar in /usr/share/java and
=C2=A0then cr= eates a symlink <package>-<version>.jar to it, rather than plac= e
=C2=A0<package>-<version>.jar and create a symlink <pa= ckage>.jar. Would it be ok to
=C2=A0submit a patch for that?

= Best Regards,
=C2=A0Vladimir.

<= div dir=3D"ltr" class=3D"gmail_attr">On Fri, Feb 10, 2023 at 11:07 AM Emman= uel Bourg <ebourg@apache.org>= ; wrote:

Le 2023= -02-09 19:39, Joe Nahmias a =C3=A9crit=C2=A0:

> Thanks for all your help. I think I managed to figure this out finally= .
> I've put my repo on salsa here:
> https://salsa.debian.org/java-team/jack= son-modules-java8
>
> Anyone care to do a(n in-depth) review before I upload?

Great! Here is my review:

- Don't build the -java-doc package, that's useless
- The Maven wrapper should be removed (mwn* and .mvn/wrapper/*)
- I'd use the default gbp branch layout (master/upstream/pristine-tar)<= br> =C2=A0 =C2=A0instead of the DEP 14 layout (debian/latest). Most Java packag= es
=C2=A0 =C2=A0follow the gbp layout and it's important all packages rema= in
consistent.
- Drop the +ds suffix
- debian/changelog doesn't close an ITP bug
- Why declaring a Provides field on virtual packages? That's unusual
The content of the binary package is perfect. Nice trick in
debian/control
to reuse the same description, I didn't know that was possible.

Emmanuel Bourg

--00000000000089eb2505f44bb832--