Path: csiph.com!1.us.feeder.erje.net!2.eu.feeder.erje.net!feeder.erje.net!fu-berlin.de!bofh.it!news.nic.it!robomod From: Emmanuel Bourg Newsgroups: linux.debian.maint.java Subject: Re: help with plugin versions and maven-debian-helper Date: Thu, 09 Feb 2023 23:10:01 +0100 Message-ID: References: X-Original-To: Joe Nahmias X-Mailbox-Line: From debian-java-request@lists.debian.org Thu Feb 9 22:07:42 2023 Old-Return-Path: X-Amavis-Spam-Status: No, score=-6.998 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -3.5 MIME-Version: 1.0 User-Agent: Roundcube Webmail/1.4.13 X-Sender: ebourg@apache.org X-Originating-IP: 78.197.213.85 X-Webmail-Userid: ebourg-oss@ariane-software.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-ID: 7969119541965748406 X-Vr-Spamstate: OK X-Vr-Spamcause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehfedgudehhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepggffhffvvefujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpefgmhhmrghnuhgvlhcuuehouhhrghcuoegvsghouhhrghesrghprggthhgvrdhorhhgqeenucggtffrrghtthgvrhhnpeelvdfhgeevgedtudektedujeeffedvtddujeekffdtjeeivddvhfeuvdekkeevgeenucffohhmrghinhepuggvsghirghnrdhorhhgnecukfhppeduvdejrddtrddtrddupdejkedrudeljedrvddufedrkeehpdduhedurdektddrvdelrddvudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoegvsghouhhrghesrghprggthhgvrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeguvggsihgrnhdqjhgrvhgrsehlihhsthhsrdguvggsihgrnhdrohhrghdpoffvtefjohhsthepmhhoheeitddpmhhouggvpehsmhhtphhouhht X-Mailing-List: archive/latest/23193 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/775eae911ef06536b5f24424e4c91ae2@apache.org Approved: robomod@news.nic.it Lines: 25 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-java@lists.debian.org X-Original-Date: Thu, 09 Feb 2023 23:07:14 +0100 X-Original-Message-ID: <775eae911ef06536b5f24424e4c91ae2@apache.org> X-Original-References: <5727dc243076178631326e380aa5ac10@apache.org> Xref: csiph.com linux.debian.maint.java:12542 Le 2023-02-09 19:39, Joe Nahmias a écrit : > Thanks for all your help. I think I managed to figure this out finally. > I've put my repo on salsa here: > https://salsa.debian.org/java-team/jackson-modules-java8 > > Anyone care to do a(n in-depth) review before I upload? Great! Here is my review: - Don't build the -java-doc package, that's useless - The Maven wrapper should be removed (mwn* and .mvn/wrapper/*) - I'd use the default gbp branch layout (master/upstream/pristine-tar) instead of the DEP 14 layout (debian/latest). Most Java packages follow the gbp layout and it's important all packages remain consistent. - Drop the +ds suffix - debian/changelog doesn't close an ITP bug - Why declaring a Provides field on virtual packages? That's unusual The content of the binary package is perfect. Nice trick in debian/control to reuse the same description, I didn't know that was possible. Emmanuel Bourg