Path: csiph.com!newsfeed.xs4all.nl!newsfeed8.news.xs4all.nl!news.dns-netz.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod From: Thorsten Glaser Newsgroups: linux.debian.bugs.dist,linux.debian.maint.java Subject: Bug#976669: lintian: please warn about autopkgtests that test rebuilt source, not as-installed, where possible Date: Sun, 06 Dec 2020 20:00:03 +0100 Message-ID: X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Sun Dec 6 18:57:11 2020 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -3.95 Reply-To: Thorsten Glaser , 976669@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: debian-java@lists.debian.org, Debian Lintian Maintainers X-Debian-Pr-Message: report 976669 X-Debian-Pr-Package: lintian X-Debian-Pr-Source: lintian X-Spam-Bayes: score:0.0000 Tokens: new, 27; hammy, 150; neutral, 197; spammy, 0. spammytokens: hammytokens:0.000-+--sk:dh_auto, 0.000-+--XDebbugsCc, 0.000-+--X-Debbugs-Cc, 0.000-+--testcase, 0.000-+--autopkgtests Content-Language: de-DE-1901 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Debian-Message: from BTS X-Mailing-List: archive/latest/1636857 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 80 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Sun, 6 Dec 2020 19:52:20 +0100 (CET) X-Original-Message-ID: Xref: csiph.com linux.debian.bugs.dist:1036114 linux.debian.maint.java:11965 Package: lintian Severity: wishlist X-Debbugs-Cc: debian-java@lists.debian.org Hi lintian people, the request is, of course, not generally solvable. However, for a few buildsystems and ways to =E2=80=9Ctest=E2=80=9D, this is possible, an= d these should be warned about (probably at Error level even). It all begun with=E2=80=A6 > I find java packages with maven-debian-helper can be tested by: >=20 > =3D=3D=3D=3D > Test-Command: dh_auto_configure; dh_auto_test The trouble here is that, with maven-debian-helper in Build-Depends and used (if pom.xml exists, it=E2=80=99s used), this calls =E2=80=9Cmvn te= st=E2=80=9D, and Maven helpfully expands this to =E2=80=9Cmvn compile test=E2=80=9D because = the source is not yet compiled. It=E2=80=99s probably much more involved to do as-inst= alled testing with Maven=E2=80=A6 but that=E2=80=99s for d-java@l.d.o to figure o= ut. But some people are using this, and this should be an Error. Some other buildsystems also do this. I don=E2=80=99t know many, but for example some Makefile-based ones also have a =E2=80=9Ctest: build=E2=80= =9D dependency. So maybe the mere presence of dh_auto_test in a testcase should also be warned about, but with a much lower severity than Error. Error should be used for these we positively know about that rebuilds are caused and that the rebuilt code is the code being tested. Perhaps specialists for other buildsystems could also be asked whether theirs do that, and errors tagged for those. On Sun, 6 Dec 2020, Paul Wise wrote: > On Sat, Dec 5, 2020 at 6:45 PM Thorsten Glaser wrote: >=20 > > We probably should let maven-debian-helper=E2=80=99s dh module > > abort any building (dh_auto_{build,test}) if run under > > autopkgtests to enforce this. >=20 > I'd suggest to start with a lintian warning about this and maybe when > there are fewer packages using it, then change the dh module. Good point. I=E2=80=99m doing so with this. bye, //mirabilos --=20 tarent solutions GmbH Rochusstra=C3=9Fe 2-4, D-53123 Bonn =E2=80=A2 http://www.tarent.de/ Tel: +49 228 54881-393 =E2=80=A2 Fax: +49 228 54881-235 HRB 5168 (AG Bonn) =E2=80=A2 USt-ID (VAT): DE122264941 Gesch=C3=A4ftsf=C3=BChrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Ale= xander Steeg ************************************************* Mit unserem Consulting bieten wir Unternehmen ma=C3=9Fgeschneiderte Angebot= e in Form von Beratung, Trainings sowie Workshops in den Bereichen Softwaretechnologie, IT Strategie und Architektur, Innovation und Umsetzung sowie Agile Organisation. Besuchen Sie uns auf https://www.tarent.de/consulting . Wir freuen uns auf Ihren Kontakt. *************************************************