Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Emmanuel Bourg Newsgroups: linux.debian.maint.java Subject: Re: Review: imageviewer-image-viewer Date: Sun, 31 May 2020 10:40:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-java-request@lists.debian.org Sun May 31 08:37:18 2020 Old-Return-Path: X-Amavis-Spam-Status: No, score=-12.001 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5.5 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Mailing-List: archive/latest/22235 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/8d2b0fd1-46b9-84f9-d60c-f14177a99318@apache.org Approved: robomod@news.nic.it Lines: 36 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Sun, 31 May 2020 10:37:01 +0200 X-Original-Message-ID: <8d2b0fd1-46b9-84f9-d60c-f14177a99318@apache.org> X-Original-References: Xref: csiph.com linux.debian.maint.java:11656 Hi Samyak, I got a quick look and technically it's good. I'd suggest some cosmetic changes: - the empty debian/maven.cleanIgnoreRules and debian/maven.publishedRules files can be removed - don't bother packaging the javadoc, it's just a waste of resources - the libjs-jquery dependency can be removed (even if the doc is built) - the indentation of debian/rules is weird, try 'wrap-and-sort -sa' - why repeating twice "imageviewer" in the package name? I suggest renaming to "kazocsaba-imageviewer" for the source package and "libkazocsaba-imageviewer-java" for the binary package. - there is a character encoding issue in debian/copyright on the name of the upstream author Le 29/05/2020 à 23:33, Samyak Jain a écrit : > Hi, > > I have packaged libimageviewer-image-viewer-java which is acting as a > dependency for a Gradle based Package. Since it is my first attempt to > package a maven based java package. It will be great if someone can > review it. The package builds fines. > > The package exists here[1]. Since I'm a Debian contributor it will be > very helpful if someone can sponsor the package as well. > > I have created an empty repository in the java team which exists here > [2]. I'll push the changes once the package is reviewed. > > > Thanks and regards > Samyak Jain > > [1] https://salsa.debian.org/samyak-jn/libimageviewer-image-viewer-java > [2] https://salsa.debian.org/java-team/libimageviewer-image-viewer-java