Path: csiph.com!newsfeed.xs4all.nl!newsfeed9.news.xs4all.nl!178.20.174.218.MISMATCH!feeder5.feed.usenet.farm!feed.usenet.farm!aioe.org!bofh.it!news.nic.it!robomod From: Gilles Filippini Newsgroups: linux.debian.maint.java Subject: Re: Packaging libsis-jhdf5-java -- help needed Date: Fri, 01 May 2020 01:30:01 +0200 Message-ID: References: X-Original-To: Pierre Gruet X-Mailbox-Line: From debian-java-request@lists.debian.org Thu Apr 30 23:28:21 2020 Old-Return-Path: X-Amavis-Spam-Status: No, score=-4.68 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, LDO_WHITELIST=-5, MEDS2=2, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_LOW=-0.7] autolearn=no autolearn_force=no X-Policyd-Weight: using cached result; rate: -3.5 Autocrypt: addr=pini@debian.org; prefer-encrypt=mutual; keydata= mQENBEodEFABCACzPp/Veq9REEcswZBugoAAFi/1MFHPTHV9iZmnz6YOmjPwupYogaAKntpq ArCM72LOf+1XSbWVf300nzvus+bmGLXECUuCtjZmIuWraMZMaqSZE5ydpFjf2BQ5rPDSSIWg LQpn6Or4OOcoa4QNPnLr2yzx2yIAd/be2ke9Xwq9f+5moRb/JGM6IDtXvJnmelglNLtWW+T+ aLMk4VU0TSVmqdf4e90SyGjCkTKltLOP4vv/J9Uh/0uIwx6Kb9RQqmJh+uDGpEQFeDfHsZEq K6yL0Jhfby2OdS9m/s6O+849YVY1wGLQscgLu+ynlBZDykX6kFdPmScY/49tpf/Rl1ENABEB AAG0IkdpbGxlcyBGaWxpcHBpbmkgPHBpbmlAZGViaWFuLm9yZz6JAVQEEwEIAD4CGw8FCwkI BwMFFQoJCAsFFgIDAQACHgECF4AWIQSgk5vMCsMTTla0jJHv6Gxsf/7PgwUCWxWJSwUJFLrf 8gAKCRDv6Gxsf/7Pg6cyB/kBDsiQm+A8xugLOCDADz/qibcAxAMfHz2pseMg6k0hGii7+7g0 oYb+suWBVT5FRIWR7aiKNLFB2zpA7qXelEdwJn9h25amO0fwdSSu0ZgBaSL+imp08eo+QVDV ZKdgNdT0NuX1t7s/EAEyz/J6RRYumU2vRQmanqqjL2wZaA4wyBP0cEBsvaxcvtUqKiQfh7FA 08IGDHyNBmtqvKlkfCBMMjjWRxukHSQTmuzWtF8tv/zyxRfMDcN5nwSmwhnDKSoel21CN9k0 DkqNLVUxR9sBRUZtt/5ztnDfS2MFUFU4HPSvtjQWd6AUsdlBbMe0jPv9b44naUnPEHct6BF1 9RUN User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8582BC76E40CE1B20C0FF182" Content-Language: en-US X-Mailing-List: archive/latest/22168 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/dffd73fe-fc2f-d27b-01c2-998524efd5ee@debian.org Approved: robomod@news.nic.it Lines: 73 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Andreas Tille , Debian Med Project List , Debian Java List X-Original-Date: Fri, 1 May 2020 01:12:25 +0200 X-Original-Message-ID: X-Original-References: <68857e65-b679-924f-08c7-e79ffe91d79e@free.fr> <20200429095922.GO1150@an3as.eu> <20200429153654.GR1150@an3as.eu> <167e766f-a18b-b7bc-dfd7-4fcea3fced43@debian.org> <662451e3-fe2b-20cc-bc1a-bc0869fe41c9@free.fr> <71cac6e1-cac0-6977-73b7-60ce6d42f2c6@free.fr> Xref: csiph.com linux.debian.maint.java:11598 This is a multi-part message in MIME format. --------------8582BC76E40CE1B20C0FF182 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Pierre Gruet a écrit le 30/04/2020 à 23:45 : > Thanks for looking at the issue and proposing a fix. It is very helpful! > I will thus look at it and investigate further the failures that remain. This package looks weird. Where does the mix-up between libhdf5-java and libsis-jhdf5-java come from? There shouldn't have any dependency to libhdf5-java as I understand it. The tests failures come from this confusion. Using the attached patch, the package builds correctly and only 10 failing test cases remain. BTW the override_dh_auto_clean target should be reintroduced. Best, _g. --------------8582BC76E40CE1B20C0FF182 Content-Type: text/x-patch; charset=UTF-8; name="no-libhdf5-java.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="no-libhdf5-java.patch" diff --git a/debian/control b/debian/control index 63213c8..df8b3f2 100644 --- a/debian/control +++ b/debian/control @@ -21,8 +21,7 @@ Build-Depends: debhelper-compat (= 12), testng, libhamcrest-java, libjmock2-java, - libobjenesis-java, - libhdf5-java + libobjenesis-java Standards-Version: 4.5.0 Vcs-Browser: https://salsa.debian.org/med-team/libsis-jhdf5-java Vcs-Git: https://salsa.debian.org/med-team/libsis-jhdf5-java.git diff --git a/debian/rules b/debian/rules index b64e410..4d6439b 100755 --- a/debian/rules +++ b/debian/rules @@ -25,7 +25,7 @@ override_dh_auto_build: cd source/c && \ $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -shared -fPIC -Wl,--exclude-libs,ALL \ -I/usr/lib/jvm/default-java/include/ -I/usr/include/hdf5/serial \ - *.c jni/*.c -o libsis-jhdf5.so -lz -lhdf5_serial + *.c jni/*.c -o libjhdf5.so -lz -lhdf5_serial override_jh_installlibs: mv targets/gradle/libs/sis-jhdf5-1.jar targets/gradle/libs/sis-jhdf5.jar diff --git a/debian/tests/providedTests b/debian/tests/providedTests index f07438a..affc631 100644 --- a/debian/tests/providedTests +++ b/debian/tests/providedTests @@ -19,7 +19,7 @@ TESTCLASSPATH=/usr/share/java/junit4.jar:/usr/share/java/testng.jar:/usr/share/j export CLASSPATH="$SOURCEDIR/sourceTest/java:/usr/share/java/sis-jhdf5.jar:$TESTCLASSPATH" \ JNIPATH="`readlink -f source/c`:/usr/lib/jni" \ TZ=Europe/Zurich LC_ALL=C -export COMPILPATH=/usr/share/java/commons-lang3.jar:/usr/share/java/commons-io.jar:/usr/share/java/sis-base.jar:/usr/share/java/jarhdf5.jar +export COMPILPATH=/usr/share/java/commons-lang3.jar:/usr/share/java/commons-io.jar:/usr/share/java/sis-base.jar:/usr/share/java/sis-jhdf5.jar find $SOURCEDIR/sourceTest/java -name '*.java' | env CLASSPATH="$CLASSPATH:$COMPILPATH" xargs javac && \ - java -Xmx2048M -Djava.library.path=/usr/lib/jni -Dnative.libpath.jhdf5=/usr/lib/x86_64-linux-gnu/jni/libhdf5_java.so org.testng.TestNG -verbose 2 $SOURCEDIR/sourceTest/java/tests.xml + java -Xmx2048M -Djava.library.path=/usr/lib/jni org.testng.TestNG -verbose 2 $SOURCEDIR/sourceTest/java/tests.xml --------------8582BC76E40CE1B20C0FF182--