Groups | Search | Server Info | Keyboard shortcuts | Login | Register


Groups > gnu.utils.bug > #2273

Re: [sharutils] Does not compile with -fno-common

From Petr Pisar <ppisar@redhat.com>
Newsgroups gnu.utils.bug
Subject Re: [sharutils] Does not compile with -fno-common
Date 2020-01-23 16:19 +0100
Message-ID <mailman.3347.1579792757.1979.bug-gnu-utils@gnu.org> (permalink)
References <dc59915b-005b-12fd-d990-96a483cdb6b4@suse.de> <20200123151904.GA16884@dhcp-0-146.brq.redhat.com>

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, Jan 20, 2020 at 07:47:15PM +0100, Christian Voegl wrote:
> Trying to build sharutils 4.15.2 with  -fno-common fails with
> 
>    [   30s]
>    /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld:
>    shar-opts.o:(.data.rel.ro.local+0x0): multiple definition of
>    `program_name'; shar.o:(.rodata+0x10): first defined here
>    [   30s]
>    /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld:
>    ../lib/libgnu.a(md5.o): in function `md5_stream':
>    [   30s] md5.c:(.text+0x15d): multiple definition of `md5_stream';
>    shar.o:shar.c:(.text+0x28): first defined here
> 
> 
> As -fno-common is going to be the default, I think this should be fixed.
> 
Please try the two patches attached. The first one should fix the program_name
symbol. The second the md5_stream symbol. I was able to reproduce the first
one, but not the second one. (Depiste tha fact I do not link to openssl.)

-- Petr

Back to gnu.utils.bug | Previous | Next | Find similar


Thread

Re: [sharutils] Does not compile with -fno-common Petr Pisar <ppisar@redhat.com> - 2020-01-23 16:19 +0100

csiph-web