Path: csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail
From: Samuel Thibault <samuel.thibault@gnu.org>
Newsgroups: gnu.hurd.help
Subject: Re: Trouble executing example translator from Hurd Hacking Guide
Date: Sun, 28 Jul 2019 11:33:13 +0200
Organization: I am not organized
Lines: 23
Approved: help-hurd@gnu.org
Message-ID: <mailman.9.1564306404.1985.help-hurd@gnu.org>
References: <877e84gsx7.fsf@gmail.com> <20190727090956.2b3nk43p42rgcmof@function> <20190727093244.443dqtvyku6yyo2y@function> <877e82cy5q.fsf@gmail.com> <20190728093313.s5zyy7sfotaybj5l@function>
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: usenet.stanford.edu 1564306404 21487 209.51.188.17 (28 Jul 2019 09:33:24 GMT)
X-Complaints-To: action@cs.stanford.edu
Cc: bug-hurd@gnu.org, help-hurd@gnu.org
To: Andrew Eggenberger <andrew.eggenberger@gmail.com>
Envelope-to: help-hurd@gnu.org
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Mail-Followup-To: Andrew Eggenberger <andrew.eggenberger@gmail.com>, bug-hurd@gnu.org, help-hurd@gnu.org
Content-Disposition: inline
In-Reply-To: <877e82cy5q.fsf@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized.
X-Received-From: 2a0c:e300::1
X-BeenThere: help-hurd@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Users list for the GNU Hurd <help-hurd.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/help-hurd>, <mailto:help-hurd-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/help-hurd>
List-Post: <mailto:help-hurd@gnu.org>
List-Help: <mailto:help-hurd-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/help-hurd>, <mailto:help-hurd-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID: <20190728093313.s5zyy7sfotaybj5l@function>
X-Mailman-Original-References: <877e84gsx7.fsf@gmail.com> <20190727090956.2b3nk43p42rgcmof@function> <20190727093244.443dqtvyku6yyo2y@function> <877e82cy5q.fsf@gmail.com>
Xref: csiph.com gnu.hurd.help:397

Hello,

Andrew Eggenberger, le dim. 28 juil. 2019 04:21:21 -0500, a ecrit:
> It's working now,

Good :)

> Both putting #define _FILE_OFFSET_BITS 64 and switching the offset
> type in the read function to loff_t

? Only one of the two should be needed. Note that the #define needs to
be very first, before #includes, since it's driving what includes are
supposed to do.

> There's also a small bug in the program itself. Instead of assigning
> the char '1' in the for loop, it's assigning the int 1, causing it to
> output the character with the ascii code 1.

AIUI that was the purpose, but apparently it would be less surprising to
emit '1' chars, so I changed that too.

Samuel