Path: csiph.com!3.us.feeder.erje.net!feeder.erje.net!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From: "G. Branden Robinson" <INVALID.NOREPLY@gnu.org>
Newsgroups: gnu.groff.bug
Subject: [bug #57592] [PATCH] tmac/<files containing a ".nx" request>: Add a warning
Date: Thu, 16 Jan 2020 01:06:41 -0500 (EST)
Lines: 27
Approved: bug-groff@gnu.org
Message-ID: <mailman.2686.1579154811.1979.bug-groff@gnu.org>
References: <20200113-183655.sv93188.51644@savannah.gnu.org> <20200114-121803.sv97361.68437@savannah.gnu.org> <20200115-033545.sv108747.2685@savannah.gnu.org> <20200115-034311.sv108747.17875@savannah.gnu.org> <20200116-060641.sv108747.66365@savannah.gnu.org>
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Trace: usenet.stanford.edu 1579154811 4328 209.51.188.17 (16 Jan 2020 06:06:51 GMT)
X-Complaints-To: action@cs.stanford.edu
To: "G. Branden Robinson" <g.branden.robinson@gmail.com>, Bjarni Ingi Gislason <bjarniig@rhi.hi.is>, Ingo Schwarze <schwarze@usta.de>, bug-groff@gnu.org
Envelope-to: bug-groff@gnu.org
X-PHP-Originating-Script: 1001:sendmail.php
X-Savane-Server: savannah.gnu.org:443 [209.51.188.79]
X-Savane-Project: groff
X-Savane-Tracker: bugs
X-Savane-Item-ID: 57592
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 PureBrowser/60.9.0
X-Apparently-From: 1.144.111.201 (Savane authenticated user gbranden)
In-Reply-To: <20200115-034311.sv108747.17875@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.79
X-BeenThere: bug-groff@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Bug reports for the GNU version of nroff, troff et al" <bug-groff.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-groff>, <mailto:bug-groff-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-groff>
List-Post: <mailto:bug-groff@gnu.org>
List-Help: <mailto:bug-groff-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-groff>, <mailto:bug-groff-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID: <20200116-060641.sv108747.66365@savannah.gnu.org>
X-Mailman-Original-References: <20200113-183655.sv93188.51644@savannah.gnu.org> <20200114-121803.sv97361.68437@savannah.gnu.org> <20200115-033545.sv108747.2685@savannah.gnu.org> <20200115-034311.sv108747.17875@savannah.gnu.org>
Xref: csiph.com gnu.groff.bug:1625

Follow-up Comment #4, bug #57592 (project groff):

To be fair to Bjarni, he wasn't requesting a change in the semantics of `.nx`,
but asking us to add include guards to some of the macro packages.

But as Ingo pointed out, the macro files should be written idempotently. 
Having them skip to the next file of input when a symbol (string, macro,
diversion, request) that the package defines is already defined is a pretty
conventional way to do this and I do not think requires a warning.

I regret my lack of clarity in characterizing my objection earlier.  In fact I
think our "include guards" could be improved by keying of a simple that is
_only_ there for the purpose of detecting multiple inclusion.

But better still would be to simply have "reentrant" macro packages. :P

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57592>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/