Path: csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail
From: "G. Branden Robinson" <INVALID.NOREPLY@gnu.org>
Newsgroups: gnu.groff.bug
Subject: [bug #58337] negative arguments to .ss request cause assertion failure
Date: Fri,  8 May 2020 18:44:28 -0400 (EDT)
Lines: 54
Approved: bug-groff@gnu.org
Message-ID: <mailman.2457.1588977870.3066.bug-groff@gnu.org>
References: <20200508-224427.sv108747.18258@savannah.gnu.org>
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Trace: usenet.stanford.edu 1588977870 8679 209.51.188.17 (8 May 2020 22:44:30 GMT)
X-Complaints-To: action@cs.stanford.edu
To: "G. Branden Robinson" <g.branden.robinson@gmail.com>, bug-groff@gnu.org
Envelope-to: bug-groff@gnu.org
X-PHP-Originating-Script: 1001:sendmail.php
X-Savane-Server: savannah.gnu.org:443 [209.51.188.72]
X-Savane-Project: groff
X-Savane-Tracker: bugs
X-Savane-Item-ID: 58337
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0
X-Apparently-From: 1.129.111.28 (Savane authenticated user gbranden)
In-Reply-To: 
X-BeenThere: bug-groff@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Bug reports for the GNU version of nroff, troff et al" <bug-groff.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-groff>, <mailto:bug-groff-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-groff>
List-Post: <mailto:bug-groff@gnu.org>
List-Help: <mailto:bug-groff-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-groff>, <mailto:bug-groff-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID: <20200508-224427.sv108747.18258@savannah.gnu.org>
Xref: csiph.com gnu.groff.bug:1847

URL:
  <https://savannah.gnu.org/bugs/?58337>

                 Summary: negative arguments to .ss request cause assertion
failure
                 Project: GNU troff
            Submitted by: gbranden
            Submitted on: Fri 08 May 2020 10:44:27 PM UTC
                Category: Core
                Severity: 3 - Normal
              Item Group: Crash/Not responding
                  Status: In Progress
                 Privacy: Public
             Assigned to: gbranden
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

I didn't think my C99-conformant assert() rewrite would pay off this quickly.


$ ./build/test-groff -Tutf8
.ss 12 -1
a
troff: ../src/roff/troff/number.cpp:653: scale(): assertion failed: 'x >= 0 &&
y > 0'
[...]/build/groff: error: troff: Signal 6 (core dumped)


Same happens if the arguments to .ss are swapped.

Seems like we should just reject negative values for these parameters.

Zeroes are fine.  They result in ugly typography (for conventional
applications), but they don't crash groff.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58337>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/