Path: csiph.com!goblin3!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@gmail.com>
Newsgroups: gnu.emacs.bug
Subject: bug#43164: 26.3.50; project.el still broken under Emacs 26.3
Date: Thu, 03 Sep 2020 13:48:01 +0100
Lines: 34
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Approved: bug-gnu-emacs@gnu.org
Message-ID: <mailman.2185.1599137344.2469.bug-gnu-emacs@gnu.org>
References: <wvr43641ay5e.fsf@gmail.com> <CALDnm50ybn77HAyPbTM6mL6wOyeW-zjdMVprbLEfvLptq68M_w@mail.gmail.com> <87mu28pp54.fsf@gmail.com> <878sdrowla.fsf@gmail.com>
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Philipp Stephani <p.stephani2@gmail.com>
To: 43164-done@debbugs.gnu.org
Envelope-to: bug-gnu-emacs@gnu.org
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-gnu-emacs@gnu.org
Resent-Date: Thu, 03 Sep 2020 12:49:01 +0000
Resent-Message-ID: <handler.43164.D43164.159913729124825.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
Mail-Followup-To: 43164@debbugs.gnu.org, joaotavora@gmail.com, p.stephani2@gmail.com
In-Reply-To: <87mu28pp54.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 02 Sep 2020 09:19:03 +0100")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
Precedence: list
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Xref: csiph.com gnu.emacs.bug:134827

Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:

> Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:
>
>> This is breaking Eglot for Emacs 26.3 users:
>> https://github.com/joaotavora/eglot/issues/530
>
> Over there, Andrii Kolomoiets has identified the culprit commit:
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Db63c5a7efc89c2323=
0f53a346e29e72a9b4faafc

I fixed this in 5142149758333cfddc25c8c696e0e6f322e37d62, by not adding
the keybinding to a non-existing keymap.  I tested merely by loading the
project.el file in Emacs 26.3 and checking it loaded OK.  I bumped the
version to 0.5.2 and it should be in GNU ELPA soon.

Directly calling M-x project-other-tab-command in Emacs 26.3 will still
fail, but that's not a show-stopping bug as this one was.

In the future, we must make sure to honour the advice in the file's
header:

   ;; Package-Requires: ((emacs "26.3") (xref "1.0.2"))
=20=20=20=20
   ;; This is a GNU ELPA :core package.  Avoid using functionality that
   ;; not compatible with the version of Emacs recorded above.

Jo=C3=A3o