Path: csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail From: Stefan Kangas Newsgroups: gnu.emacs.bug Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message Date: Thu, 3 Sep 2020 03:40:30 -0700 Lines: 45 Sender: "Debbugs-submit" Approved: bug-gnu-emacs@gnu.org Message-ID: References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> <831s9xl54b.fsf@gnu.org> <874leq1hw4.fsf@mail.linkov.net> <87worlgh0k.fsf@mail.linkov.net> <878swkxqo1.fsf_-_@mail.linkov.net> <83wok37mqd.fsf@gnu.org> <878skl767i.fsf@stefankangas.se> <87blji65go.fsf@gnus.org> NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: usenet.stanford.edu 1599129666 9090 209.51.188.17 (3 Sep 2020 10:41:06 GMT) X-Complaints-To: action@cs.stanford.edu Cc: Lars Ingebrigtsen , Robert Pluim , 32676@debbugs.gnu.org, Eli Zaretskii , Juri Linkov To: Ernesto Alfonso Envelope-to: bug-gnu-emacs@gnu.org X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Sep 2020 10:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=SAaeT6AZVwsyZQSGxmaPbCy2w4Es22KvDQa/TDjZR3c=; b=tWTYxZzFPJNJkAhz07CrgZFEceABush9WZ4GJs0vyKEyIp59RXdW1C08lYZ5cW0fZ5 Ykm5T4QAaXK30WrHokPOA76a8VSZ/pPp0SqIzaFAle/u+XfAv1jZj7Ns04+TzW4osAMD dwWYMuadT09GNCZo+8ZgIpmD+4bOcTaQlhifGvSCaKlAwcfrXqSnIMyZ6HENFcaprEeA wyxd8TuVvJDLsEtzfBMV7oa1j9JygePjGiw+Bi1XVex7V6pKsWIx47EojoqwF2IZMSiF cDEiJmYKIzHFairMeAJQ/Zk6bBidhsckRgmD+szlca1oyLPVIkJx8AOYaTy1d/67/1hB O6FA== X-Gm-Message-State: AOAM532Ams2bOD3dBNmT2YHCkZWnk/6Ai0sFfmnPhGBLY7WBcvhza/OG pCfTSlTqhw2/vePRACPzjbGPs/hPBVjc2xXc/Wk= X-Google-Smtp-Source: ABdhPJxfuzySkboJEKEsiy7wMrZJU+3hi0DQRQY+plEkfZHFH6yUmjP+ACgGIoYfGtYG45hNzXcumAi6fkuJZJymgu0= X-Received: by 2002:a17:906:bb0e:: with SMTP id jz14mr1465059ejb.525.1599129631185; Thu, 03 Sep 2020 03:40:31 -0700 (PDT) In-Reply-To: (Ernesto Alfonso's message of "Thu, 3 Sep 2020 01:00:16 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: X-Mailman-Original-References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> <831s9xl54b.fsf@gnu.org> <874leq1hw4.fsf@mail.linkov.net> <87worlgh0k.fsf@mail.linkov.net> <878swkxqo1.fsf_-_@mail.linkov.net> <83wok37mqd.fsf@gnu.org> <878skl767i.fsf@stefankangas.se> <87blji65go.fsf@gnus.org> Xref: csiph.com gnu.emacs.bug:134821 Hi Ernesto, Thanks for following up on this. Ernesto Alfonso writes: > I currently work for Google, and my understanding is that Google has a > special agreement with the FSF. Please let me know if this is correct > or if I still need to provide a copyright assignment. Someone else will have to answer this. > Also, I am not sure if this patch is still applicable. In what way? From reading the discussion, it seems like the feature was considered useful, but there were some additional comments before it was ready. I copied in those comments below. Could you have a look at them? Thanks in advance. Juri Linkov writes: >> I'd like to know if this patch is still being considered? > > Why not? Your patch provides a helpful feature. I see only 2 problems > with its latest version: > > 1. compilation-current-error should be generalized not to be too > compilation-specific; > > 2. next-error-hook should not be used for core features, > you could call next-error-message-highlight directly > from next-error-found. > > PS: maybe a better name for defcustom would be next-error-message-highlight, > not next-error-message-highlight-p, to be more future-proof, > for the case when someone might want to add more choices later > (e.g. fringe, timers, etc.) Best regards, Stefan Kangas