Groups | Search | Server Info | Login | Register

Groups > gnu.chess.bug > #7

Bugs in PGNSaveToFile

Show all headers | View raw

Dear GNU Chess developers,

while translating GNU Chess into German, I stumbled upon the
PGNSaveToFile function and noticed some bugs:

* The result of getchar() is saved in a char variable. That variable is
later passed to tolower, resulting in undefined behavior. The variable
type should be int.

* If the input stream ends during "while( getchar() != '\n' )", the
program gets stuck in a CPU-consuming endless loop.

* In that same loop, the parenthesis is placed wrong. This is just a
formatting issue. The formatting in this function is inconsistent in
several other places, too.

* The code explicitly checks for the characters "yn", which only works
well for English. For example, German requires "jn", French requires
"on", Spanish requires "sn". It would be better to use the rpmatch
function instead.

Best,
Roland

Back to gnu.chess.bug | Previous | Next | Find similar

Thread

Bugs in PGNSaveToFile Roland Illig <roland.illig@gmx.de> - 2018-07-15 22:26 +0200

csiph-web