Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail From: A Newsgroups: gnu.bash.bug Subject: Readline history bug Date: Fri, 31 Jan 2020 20:32:35 +0000 Lines: 105 Approved: bug-bash@gnu.org Message-ID: References: Reply-To: A NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="---------------------f2e7e4c6f2bfae16cca0b833c7154859"; charset=UTF-8 X-Trace: usenet.stanford.edu 1580515676 16813 209.51.188.17 (1 Feb 2020 00:07:56 GMT) X-Complaints-To: action@cs.stanford.edu To: "bug-bash@gnu.org" Envelope-to: bug-bash@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.ch; s=default; t=1580502758; bh=gSTbGgm6HiJXBbl06qcdYGf+SrZpcOE+6rJtOx0Mahk=; h=Date:To:From:Reply-To:Subject:Feedback-ID:From; b=KVKfgEk9ZZC+3GreVv8WDV5vKvqdtCtyiNWFw4eko8Czq+0dJp57SZHA0ghjLMfdN 7gHbplogpK2e8rKtUvABm580TZ2Z5t7uoiEOPvg5JdkblkTX9qK1S0aLpkYniM7RrL 1JoGgndGrzguRvVfOhR3aU/PR0Wj/OIR/MQad/4Q= Feedback-ID: zjvAP0A3DnpSWPx2ehr76hlhi2ujpQK0tbouJBQsJQbgGdv2-K21TwEUVf_QCQRSbFs3SP78iUHvZolVEEKo9w==:Ext:ProtonMail X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.70.40.132 X-Mailman-Approved-At: Fri, 31 Jan 2020 19:07:54 -0500 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: Xref: csiph.com gnu.bash.bug:15859 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) -----------------------f2e7e4c6f2bfae16cca0b833c7154859 Content-Type: multipart/mixed;boundary=---------------------6a708ae2c729276a4d4f9cfd9b33a801 -----------------------6a708ae2c729276a4d4f9cfd9b33a801 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain;charset=utf-8 The readline package doesn't return the errno for some errors in write_his= tory, append_history, and history_truncate_file. This caused an error in the CPython interpreter(at exit time) when the .py= thon_history file was not writable. In particular these calls return -1 when the internal`histfile_restore`cal= l fails because`rename`fails. It's fine for`histfile_restore`to return the= result from`rename`, but this should be checked for failure (e.g. -1) and= handled appropriately by the caller in`history_do_write`and`history_trunc= ate_file`. For example, in`history_do_write`they do the following: if (rv =3D=3D 0 && histname && tempname) rv =3D histfile_restore (tempname, histname); if (rv !=3D 0) { if (tempname) unlink (tempname); history_lines_written_to_file =3D 0; } This needs a simple fix to update the value of`rv`when`histfile_restore`fa= ils: if (rv =3D=3D 0 && histname && tempname) rv =3D histfile_restore (tempname, histname); if (rv !=3D 0) { rv =3D errno; if (tempname) unlink(tempname); history_lines_written_to_file =3D 0; } Code snippet taken from=C2=A0https://github.com/python/cpython/pull/18299#= issuecomment-580883515 -----------------------6a708ae2c729276a4d4f9cfd9b33a801 Content-Type: application/pgp-keys; filename="publickey - auroralanes@protonmail.ch - 0x72D037C6.asc"; name="publickey - auroralanes@protonmail.ch - 0x72D037C6.asc" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="publickey - auroralanes@protonmail.ch - 0x72D037C6.asc"; name="publickey - auroralanes@protonmail.ch - 0x72D037C6.asc" LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tDQpWZXJzaW9uOiBPcGVuUEdQLmpz IHY0LjguMA0KQ29tbWVudDogaHR0cHM6Ly9vcGVucGdwanMub3JnDQoNCnhzQk5CRjNyL25zQkNB RHF5QWU3R2IyYTRrQ0ExVHBJaFBOWkE5VGpzTEFsSDRyeXpqVFI5QlI5TmF5bw0KYThIdUMwR050 ZENLNk1TdndJZGF0OUdPS3orNWY1dDk4NGhnNkZtZ1ZNMEltRkIwR1J1NjZrUFlTN0pHDQpJK0tx WStsRDZwMDZDTlVLVXRWcER1OHZHQ0p6WVpHc0xqR0ZtSngvSHFDSm5MRkhKRFdpOU9QcGNMTlMN CjhYWktid3hyNTJ0bENWc0FNYzdEaGlCZk1yRVhvWnd0cUNoRFBSdG5EWkwvbHJxU2x4M1dFV1Zh S0JaZA0KR0tpWXVqMjNyOU9hTTM0TnZMenN3Y2grNHN6bGx4eURjcTRFYTJGQm12QXRjRkVFSXJJ TXl4TzgrekM5DQpFa0VjQVMvck5qSTdMR0ZaL2V1Rk1TNjU2dkNkVzBYZXMvbGoxTXRiMFdRd0F5 N1JHNE0vNW5VRkFCRUINCkFBSE5OV0YxY205eVlXeGhibVZ6UUhCeWIzUnZibTFoYVd3dVkyZ2dQ R0YxY205eVlXeGhibVZ6UUhCeQ0KYjNSdmJtMWhhV3d1WTJnK3dzQjFCQkFCQ0FBZkJRSmQ2LzU3 QmdzSkJ3Z0RBZ1FWQ0FvQ0F4WUNBUUlaDQpBUUliQXdJZUFRQUtDUkJpbTUyQ3ZMTUpjcmlPQi80 M0J3bkhMUWt0cFhTV1lZbXJ4RzZLV25Jc3E5NzQNCkxDUFoxcXZlYzdaNnJma1JwSDZLUXI0Rm1K TXU0aVVOdTlieUgwSTZLRno5WEVZUTRhQmdhVE9yQ0FYQg0KS1RlTU1vU2lWekV2TDY1NlI4ODhH OHdrdHF4YVlvYUgwZnk3RzFBbkhMSU54N1FNMVMzNFhLNnJNdDQwDQp5Y2NOOUtUZzhrTnhvTGt0 Y3psaGlIQ1QvbTA3bU02THZXQWhkNnRHckdOWlE4SldtUStkVG0zS1JDYkINCjUxWEVqWHJFaVJY cVFEWi9qdzMxYTFIWlVqRGM1US90MG96aTJaTTBFUUo5UGdsZDNvSGRDc204bzloaA0KeEhYL0pB MlF4cnhzdXIxUUtKNU1idEJCbkk5VHpzTkdhMHkyYUFLZVZxRTdGNDFOWU1ocVVramlUZ0RFDQpX UUlpMnVpNDJlOGx6c0JOQkYzci9uc0JDQUNtRWVwaUNQaERmOHpKZ3RBWk9tbmpSNEhHdm5YOHJh Z2wNCjJPaEFuQWNFSTVzYXJSd2dRV1gwcWxaNy9UazlPMGx6YmN4bWpQWkhGQ3BQTkF2YWhSOEdn L3V3c2JqTQ0KTE15Tk5uZ2t1WXFPSWFLa2tBTk9sOTdXRVZLemFNQ2JVUUU5Uk93VUF3N3BNdFVz R0xYaXpXa3F2TysrDQpWY1VmaGlNVFl6a09xOStqNHFvcm1EMHJxTWZFdm1VKzBxSHMvbUc5bUwz Sk9TY204dWJEa2dNamtndUUNCnFQMkRUUXg0c0pYdDFTV3dLYktSTHhtVHJPQnNhdWhBZG84Umps eDdEVTdJOUx3TDZHb3BwVnlSOVRWcA0KTzJXSExOMFdSUEtZTVFvRU5WWi9rUmh3TE5IUFF0YkJu T2x4dWxrSTVVbjdrbHVKRWpjVm8rSk5yekplDQozVlFZR2J0bEFCRUJBQUhDd0Y4RUdBRUlBQWtG QWwzci9uc0NHd3dBQ2drUVlwdWRncnl6Q1hKend3Z0ENCmdtZ2tNNW1QeWdiVE9KSXVTSXhMMU4z eUhrUWp3ZExMK1VwbEE0S2ZLblBhRnFGbkZwU29MSTFIeXJMVA0KdGtVd2hMblpVNTBDSkxPTWxM RnVZUzdrRFdaRjV1RVViNi95bTZzK1lDeWhmVjdNTnF6SlQxZWs0QW1PDQpXVVlrYWZYcXhWcEFG cGoyZ1lYYXQ2Wlp0dXJoRHh5SXYwajF5cG1VTlI5YmNDcW56SlU0ZHI0ZGNSVDANClMzMjNrTC9r ekNXdmtpTVFBZmlaaURyNjVORTIxc1JheG1IbEpMVGd3MlphSWU0MWkya0ozSXhZcktyZw0KWWVv dThLT1ZXRGtFREhMME1keUxJQ3ppR0pRektJTGxBTWVxYzhQVWY3bjJXSEg3eWhMb2VIL1I5elhV DQpQN2ZLWlBEaVNMdE1YMUZub0xrb281MlNubmRsVTNKL1lzZExEZzI1Qmc9PQ0KPU1iMTMNCi0t LS0tRU5EIFBHUCBQVUJMSUMgS0VZIEJMT0NLLS0tLS0NCg== -----------------------6a708ae2c729276a4d4f9cfd9b33a801-- -----------------------f2e7e4c6f2bfae16cca0b833c7154859 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wsBcBAEBCAAGBQJeNI7fAAoJEGKbnYK8swlyL1QH/2uAH9SEHSTiOC11+W27 iv/orOo+i/zAC9wu9HWg3q8KRSp2n0JMzr0vHJyu2Npln6iKw4e/6ZL19Q22 kqG18XIe1/A1RsXEBLl9nznMVVD+yqLWqamqM0a+RQCJSHGpoqpF307UCSjV nXByvPGaZtoP4UkkxQhPJruYvJusgyvFJCu27xwbJSmnqrO9DFFv/o+0GAbI TeUsCQsvjTKhYqVDzeadlO/3mmgRWTeZB6vRYgB7JEEi/2VwepLQ+ht4XyVm 6mm+5FzSWGJGpvRUi8j3/WZ64n19XuX9a8ZfS/FiJDCgNH156/ffhKQZXOLj WtADpSOO/YdU89v+EbTWLUA= =irWu -----END PGP SIGNATURE----- -----------------------f2e7e4c6f2bfae16cca0b833c7154859--