Path: csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail From: Greg Wooledge Newsgroups: gnu.bash.bug Subject: Re: [PATCH] Implement rehashing for associative arrays (Re: speeding up hash_search?) Date: Mon, 20 Apr 2020 08:49:11 -0400 Lines: 12 Approved: bug-bash@gnu.org Message-ID: References: <20200420124911.GW845@eeg.ccf.org> NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: usenet.stanford.edu 1587386984 31304 209.51.188.17 (20 Apr 2020 12:49:44 GMT) X-Complaints-To: action@cs.stanford.edu To: bug-bash@gnu.org Envelope-to: bug-bash@gnu.org Mail-Followup-To: bug-bash@gnu.org Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: none client-ip=139.137.100.1; envelope-from=wooledg@eeg.ccf.org; helo=mail.eeg.ccf.org X-detected-operating-system: by eggs1p.gnu.org: First seen = 2020/04/20 08:49:12 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 139.137.100.1 X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: <20200420124911.GW845@eeg.ccf.org> X-Mailman-Original-References: Xref: csiph.com gnu.bash.bug:16186 On Mon, Apr 20, 2020 at 06:48:44PM +0900, Koichi Murase wrote: > Also, I am sorry that I disturbed your plan for contributing to Bash. > I actually initially doubted that the insertion with the current > implementation is O(N), so I created the test first and then found > that it is an easy fix rather than reimplementing it by B-tree or > other data structures. I couldn't stop my interest in how much it is > improved by the easy fix. This should in no way make the OP feel that they didn't contribute. Spotting and diagnosing problems is important work, even if their proposed patch wasn't selected as the best solution.