Path: csiph.com!aioe.org!news.glorb.com!usenet.stanford.edu!not-for-mail
From: Chet Ramey <chet.ramey@case.edu>
Newsgroups: gnu.bash.bug
Subject: Re: extra \1 in declare -p
Date: Wed, 22 Jul 2015 08:45:43 -0400
Lines: 32
Approved: bug-bash@gnu.org
Message-ID: <mailman.7257.1437569153.904.bug-bash@gnu.org>
References: <CAAZkfoKirh-7ZOV329tnzr-6HJN1paNFhVVE4g04xzs-nEeQFQ@mail.gmail.com>
Reply-To: chet.ramey@case.edu
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Trace: usenet.stanford.edu 1437569154 21338 208.118.235.17 (22 Jul 2015 12:45:54 GMT)
X-Complaints-To: action@cs.stanford.edu
Cc: chet.ramey@case.edu
To: isabella parakiss <izaberina@gmail.com>, bug-bash <bug-bash@gnu.org>
Envelope-to: bug-bash@gnu.org
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
In-Reply-To: <CAAZkfoKirh-7ZOV329tnzr-6HJN1paNFhVVE4g04xzs-nEeQFQ@mail.gmail.com>
X-Junkmail-Status: score=10/50, host=mpv5.cwru.edu
X-Junkmail-Whitelist: YES (by domain whitelist at mpv1.tis.cwru.edu)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]
X-Received-From: 129.22.105.36
X-BeenThere: bug-bash@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-bash>
List-Post: <mailto:bug-bash@gnu.org>
List-Help: <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
Xref: aioe.org gnu.bash.bug:11250

On 7/20/15 2:23 PM, isabella parakiss wrote:
> Hi, about this bug:
> http://lists.gnu.org/archive/html/bug-bash/2003-03/msg00093.html
> 
> The fix was to add this in lib/sh/shquote.c
>       else if (c == CTLESC || c == CTLNUL)
>         *r++ = CTLESC;
> 
> I think the fix it was applied twice, it should only check this in the
> prompt string, right?
> 
> 
> Now declare -p produces output that can't be eval'ed.
> 
> $ var=$'x\1y\177z'; declare -p var | sed -n l
> declare -- var="x\001\001y\001\177z"$
> 
> 
> Removing lines 151-152 (from the 4.4 alpha branch) seems to fix this.
> The duplicate code keeps checking the prompt in lines 297-298.
> (${var@P} is expanded by that part so it should be fine...)
> I hope it won't cause other problems.

Thanks, this looks like a good fix.  I'll check other uses of sh_double_quote.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/