Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail From: konsolebox Newsgroups: gnu.bash.bug Subject: Re: Add sleep builtin Date: Tue, 21 Aug 2018 19:34:02 +0800 Lines: 23 Approved: bug-bash@gnu.org Message-ID: References: <2801c537-6f5e-a727-49ab-7fb1bc8c32f8@case.edu> NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: usenet.stanford.edu 1534851291 14597 208.118.235.17 (21 Aug 2018 11:34:51 GMT) X-Complaints-To: action@cs.stanford.edu Cc: Chester Ramey , bug-bash To: itvirta@iki.fi Envelope-to: bug-bash@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MzstHU87yTBzauJI1nki0/uZYpbeITZyCa3RtVUh+p4=; b=qzI3y97U7B4rMCiVJ6qxAZ0XTOuPuiP+QBQssoj7wYXnqvgkE81u4Y/qwaYRvEXqLW yC8MV95zI/d3X8sCQYWljRbMYGHqE/G9YCMn+3AfWnIjwedUV/xR/Ds+BduDuh+emhdf rEkvXZIgEzLCSF74zhaB/8YHLFH7nKauGNJzHZPWrAv1iZlJO5Rv4bYC2Bmtz8qxkx0x i/Hlum3UMwgl2Vx1hgfM1/91ee1UuE4qRgVJJAZ8OjtnXC7446YQtGmfbNLbKMmopLzy /UhrFfmWGT11VpKqhW/JneRudzRycv7KYpIf2xwxGK2BKt+MiWhfINN9Ud8pZNoIWsAY hZpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MzstHU87yTBzauJI1nki0/uZYpbeITZyCa3RtVUh+p4=; b=UP841QAd6N232RCqfQaRNzBkOpWCWyGQsAvCisoxUt/fNSWexwDOTrz5fhZNddQs53 89FECncBJ8Oyt2IoGr1Gj8Twmtt4+pa8vbcaeCzCKk4uvmd/Otsu1t70yH6piV8dmcrM KtKLfWzqM3mHzpM/sKPHZcZRs1gbf4e6reg9Sk5IhdRoiE7ckpWBpsajlfskd3jrU6ga 9BLS5ejgAgmmDKpjMhH7swRTzcFgnONxwMzUynouxaG/gyXi/m2DJqz3DgtcPs+FowBB jWPJkQw6bAzDhIaakLXkmmWiY23I/cb/KUCqdh9DK9dOj9decu33uiu7bA/QR1nCdn7s peAg== X-Gm-Message-State: AOUpUlE0bB0qafmox66pjE/26C+wDN3riLTQuMg7qqjoW2bsHTlaoH1h kfRxofbIuOC0g2RZlVzYr8jcU984M4pvTs1LjSc= X-Google-Smtp-Source: AA+uWPw51r7h9+xZOx19+xAO5sAEhndox0Wd17v63O9yV+r8Mj5hH193J0DJu81rjO6ZVO+55c/FimQ2GjMiJrGLKX4= X-Received: by 2002:a24:c48a:: with SMTP id v132-v6mr17377048itf.72.1534851286761; Tue, 21 Aug 2018 04:34:46 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c0b::22d X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Xref: csiph.com gnu.bash.bug:14518 On Tue, Aug 21, 2018 at 4:23 PM Ilkka Virta wrote: > > On 21.8. 02:35, Chet Ramey wrote: > > I don't think there's a problem with a `syntax conflict' as long as any > > builtin sleep accepts a superset of the POSIX options for sleep(1). > > The sleep in GNU coreutils accepts suffixes indicating minutes, hours > and days (e.g. sleep 1.5m or sleep 1m 30s for 90 seconds). I didn't > see support for those in konsolebox's patch, so while that's not > conflicting syntax per se, the lack of that option might trip someone. That was intended, and this patch is basically just a copy of the loadable version. I don't really find it necessary to make the builtin sleep a complete copy of the external one. The code would significantly increase if we add a parser for those formats. Also it's basically people's fault for not reading documentation. One should be aware enough if they enable the builtin. Mksh's sleep also does the same. Anyway I respect whatever Chet decides it to become. -- konsolebox