Path: csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail From: Jessica Clarke Newsgroups: gnu.bash.bug Subject: [PATCH] finfo.c: Fix -Wformat warnings Date: Sat, 27 Jun 2020 21:09:25 +0100 Lines: 30 Approved: bug-bash@gnu.org Message-ID: References: <20200627200925.38810-1-jrtc27@jrtc27.com> NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Trace: usenet.stanford.edu 1593295308 7491 209.51.188.17 (27 Jun 2020 22:01:48 GMT) X-Complaints-To: action@cs.stanford.edu Cc: Jessica Clarke To: bug-bash@gnu.org Envelope-to: bug-bash@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jrtc27.com; s=gmail.jrtc27.user; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jXgLAJwAodYgqMIse4p72gEyDqP0YulodKNBk+jP9Zg=; b=eGi3jrL/55F0z4EykZ2d1N1f0nG8Qwi62fT+Ddh8iRdyzAHHx/Jk9gC6nUFKj3b8Ir sbgHXwEM/lwooLfLRy9j8lx64vXMESFWSA6DjBlDboKAvAhn13ym/FKoWata2hB2HHUa gtshAx3DFRhjVephJNugUiKPuIGb/uUHFHISfKkzHIcnSewa+i2J+43mThImxM4f8VEg s+11Bs0J/O3GFu7pk9yM8xmnjYKVoqE46O2XdSq381Sl9zn2elBLaC/lw/585CNMG/fn fCNtaPXIiCgdJv55IJdwBMFgRBpdRrOdxc+sO62/WooMsjm3xY+zGMtWTN2LGAxcvPg2 YqSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jXgLAJwAodYgqMIse4p72gEyDqP0YulodKNBk+jP9Zg=; b=b1XYjpr/lPmJHRJBqfjxaR51vh+ZTS+W+oOFtfK/fpYv/vDwaJuUX607rgzb+YIV4J TyxAhjTd5g4wQO/pmgcgqFmm/kknHDHy4ziUcDrCbbk70wW/JrSuquv60tDn5zDrf+eY pSJs8vIVHkmSmgePFAhL9BqFEThZSt/kBpLd5+FzsTjAQ2ZK+Ut5+jE7Q0xMtVc0VBsw OouULC8ulMhjG4jiBr2Y3MLRlE3ezWJZRcX67q0hVb8lShZEZT9UKqvVxHIqCSbUOYMI 7bLP5ak4ms/26FC4V/dJT9TxXVCujN0kVVLWKTHyocEwDz4Y+yOmrjVa0YdN9sfmqXfG 4YkA== X-Gm-Message-State: AOAM531tQwr2rNU1ODipT2480pfTJU32FO9yvRWMa67bCRAJreNvYH8k TizMb+6NzDH+Fh+1oC4E5dfNjFqnKI4= X-Google-Smtp-Source: ABdhPJzGNQ8U4zh7tmP7lWzelF8v+8u1ia7DiGlL6GpiwBJg9Rp4/HJ8oggmk1/4kMjks27iMafyxA== X-Received: by 2002:a1c:2906:: with SMTP id p6mr7706356wmp.68.1593288567163; Sat, 27 Jun 2020 13:09:27 -0700 (PDT) X-Mailer: git-send-email 2.20.1 Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=jrtc27@jrtc27.com; helo=mail-wm1-x343.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Mailman-Approved-At: Sat, 27 Jun 2020 18:01:45 -0400 X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: <20200627200925.38810-1-jrtc27@jrtc27.com> Xref: csiph.com gnu.bash.bug:16461 We must cast these to unsigned long like the surrounding code. --- examples/loadables/finfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/loadables/finfo.c b/examples/loadables/finfo.c index 4273aa59..92e98008 100644 --- a/examples/loadables/finfo.c +++ b/examples/loadables/finfo.c @@ -334,13 +334,13 @@ int flags; else printf("%ld\n", st->st_ctime); } else if (flags & OPT_DEV) - printf("%d\n", st->st_dev); + printf("%lu\n", (unsigned long)st->st_dev); else if (flags & OPT_INO) printf("%lu\n", (unsigned long)st->st_ino); else if (flags & OPT_FID) - printf("%d:%lu\n", st->st_dev, (unsigned long)st->st_ino); + printf("%lu:%lu\n", (unsigned long)st->st_dev, (unsigned long)st->st_ino); else if (flags & OPT_NLINK) - printf("%d\n", st->st_nlink); + printf("%lu\n", (unsigned long)st->st_nlink); else if (flags & OPT_LNKNAM) { #ifdef S_ISLNK b = xmalloc(4096); -- 2.20.1