Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail From: Jessica Clarke Newsgroups: gnu.bash.bug Subject: [PATCH] Makefile.in: Make for loop failures fatal Date: Sat, 27 Jun 2020 21:10:35 +0100 Lines: 44 Approved: bug-bash@gnu.org Message-ID: References: <20200627201035.39077-1-jrtc27@jrtc27.com> NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Trace: usenet.stanford.edu 1593295307 7489 209.51.188.17 (27 Jun 2020 22:01:47 GMT) X-Complaints-To: action@cs.stanford.edu Cc: Jessica Clarke To: bug-bash@gnu.org Envelope-to: bug-bash@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jrtc27.com; s=gmail.jrtc27.user; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tOvWYPyreoD3PD1vaeWl1fQFm/3pw86JmSMSE3OxXMg=; b=SMPv5A6/DF5OkcaYwd8VQCvkd6oRGgwyhQ7hUjCpvz7IPilZJzEHKJQgn2IykpKfcO +R1l4/hY0zpeL8sZvPhOZ6LoINl/Ef1QSnOxEclxWc5QehLvZokbBOJG3e+4+x3dgD1x 7R2a1+ghbKoS8rYrclwkiXg76bDCqVcuLaoSXgLnmMYdcy3xma7MemnhaQBSAMOP6VIz UfcgjJm32AWnuVPVTEE+lE6t3xAqCXXo8TjsJz7lsnj4T71hHi99QfrMfRQlvOqlUGY2 xUTdjHJFxCZI2S55fYsoG/OtCMd1AxTFVqctSEcg6/e7p08MjDBcOydWCNbH/Qb9uxQ3 +CWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tOvWYPyreoD3PD1vaeWl1fQFm/3pw86JmSMSE3OxXMg=; b=gfQl4ahJX3PmRfdpXh3OauSSLPWHuG/kgycoYkk0Pl/rf+1dh95bxL7RzT3lDPY5gu HO5uWPVyZ9l++zqhOni2jSvdfKf7Nk+o29KbEvF9uqICaGfoZKRmPUds1cNNMfl3UqeQ e4YF2vR1ET5XerHq5kv7UFF+ihYcehnvM4IiXoaxPLXfO4msUZbuZZke+vqbHjH+JH+p HBN01RPSs/MtGqMVQP6z6ZEIS8CIxOyNEdQFfs6KzLt8JZLkx96jgHZy5VDuoK+hmv+9 /OsE05YfXwr12NsluvoxYr1Ee+x8CLnpdIA1b+ahqJDOvchDdvzaCJgVD/doEDWUplMc 3y0A== X-Gm-Message-State: AOAM530GcqQrGH/ti6LNx5IiB3VyTDzSI6nNRa1oTjPGKr6RSzAz+8cH He4j6Jfoth/rTkkdo22WVSSWHMtuv8Q= X-Google-Smtp-Source: ABdhPJzCQFBj716d2yDb28xgrWlSfiEiF220+RyHrqzrwpggguHZwWHJev5ZT4HOYE+mBMKtWjiKPw== X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr9292299wmm.168.1593288637161; Sat, 27 Jun 2020 13:10:37 -0700 (PDT) X-Mailer: git-send-email 2.20.1 Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=jrtc27@jrtc27.com; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Mailman-Approved-At: Sat, 27 Jun 2020 18:01:45 -0400 X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: <20200627201035.39077-1-jrtc27@jrtc27.com> Xref: csiph.com gnu.bash.bug:16459 Without set -e, these for loops will exit with code 0 and so make will regard the recipes as being successful. --- Makefile.in | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile.in b/Makefile.in index ee471583..a12ed426 100644 --- a/Makefile.in +++ b/Makefile.in @@ -752,7 +752,7 @@ Makefile makefile: config.status $(srcdir)/Makefile.in CONFIG_FILES=Makefile CONFIG_HEADERS= $(SHELL) ./config.status Makefiles makefiles: config.status $(srcdir)/Makefile.in - @for mf in $(CREATED_MAKEFILES); do \ + @set -e; for mf in $(CREATED_MAKEFILES); do \ CONFIG_FILES=$$mf CONFIG_HEADERS= $(SHELL) ./config.status ; \ done @@ -838,16 +838,16 @@ install-headers-dirs: @${SHELL} $(SUPPORT_SRC)mkinstalldirs $(DESTDIR)$(pkgconfigdir) install-headers: install-headers-dirs - @for hf in $(INSTALLED_HEADERS) ; do \ + @set -e; for hf in $(INSTALLED_HEADERS) ; do \ ${INSTALL_DATA} $(srcdir)/"$$hf" $(DESTDIR)$(headersdir)/$$hf; \ done - @for hf in $(INSTALLED_INCFILES) ; do \ + @set -e; for hf in $(INSTALLED_INCFILES) ; do \ ${INSTALL_DATA} $(BASHINCDIR)/"$$hf" $(DESTDIR)$(headersdir)/include/$$hf; \ done - @for hf in $(INSTALLED_BUILTINS_HEADERS) ; do \ + @set -e; for hf in $(INSTALLED_BUILTINS_HEADERS) ; do \ ${INSTALL_DATA} $(BUILTIN_SRCDIR)/"$$hf" $(DESTDIR)$(headersdir)/builtins/$$hf; \ done - @for hf in $(CREATED_HEADERS) ; do \ + @set -e; for hf in $(CREATED_HEADERS) ; do \ ${INSTALL_DATA} $(BUILD_DIR)/"$$hf" $(DESTDIR)$(headersdir)/$$hf; \ done -$(INSTALL_DATA) $(SDIR)/bash.pc $(DESTDIR)$(pkgconfigdir)/bash.pc -- 2.20.1