Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail From: Chet Ramey Newsgroups: gnu.bash.bug Subject: Re: memleak in execute_function? Date: Wed, 31 Jul 2019 21:35:37 -0400 Organization: ITS, Case Western Reserve University Lines: 15 Approved: bug-bash@gnu.org Message-ID: References: <1564586812344-0.post@n7.nabble.com> <1564621048237-0.post@n7.nabble.com> <28da8651-f34e-553b-433a-664c64884ee0@case.edu> Reply-To: chet.ramey@case.edu NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: usenet.stanford.edu 1564623347 12959 209.51.188.17 (1 Aug 2019 01:35:47 GMT) X-Complaints-To: action@cs.stanford.edu Cc: chet.ramey@case.edu To: fireshen , Bug-bash@gnu.org Envelope-to: Bug-bash@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1564623342; bh=OerTX9xDKXvEPT+AV1j+H/IvzDtQCCIljub6RWlrlA4=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=IYpQ0NRbmPvNw6FpII2nmkb9WKrnLr/oV8kY1HCrxyZjL8jg4nzHe8BU8AAq3Ym2Er wm2Vbp6ojuvKj0pykX0/OnfVlOe/LC5Y0g6Ots1ZreU9J4P28mVtbvRjlxAB+eOvNrg Qudj0gtfnXftes44Q2BHlAEmruFESp5Ekb/yLjlyzMCwMXt/+prepmFh3uHrU4qz6qo 20SZMWhJ8xBuFDDet0u4ijpD1WtnTDGCaP4m1xxjGFNlNROLFiYTxhQyqoirPpTLETJ H9nHyMQuI8viZsfvSbnGKC17zllkoDufIVqU9uLFvJ+yh+6R81dxx3CQM+j7pVnyCxv YpaSNTeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1564623341; bh=pBvwc3irEicJbgJxyi9XaXoM3I+NVd/JksIxW7LEVJ0=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=e8gviHwQ+cLmHNmdj5fgpXbgFViPxEmZFXdiRkXDOaAYfM2JOFJdcPZtLpvmoDASm5 RFrkk6M/NTDx6IoFLPJqrMAdp7SlHrvsui3JDXOoFziFtBUZAYANV8YaySjO5J2VxGa sSjU4y+AjmmNtL30af3Zyee8H678L5HJI+vCdYWPhQHUIbSnTAYEjH0YKeDcggq/33g PmcFvSub6JUXWCAjKo+mD3JTkSYyLrjdU08V09giqYQ4pYt1Md+A/FqGtt061Td/ILL Z2xFKR2eQwTrsaJU6nxoBKy2NldRNyaF5MUwUmWvvzXloGTwPdp8dJTWnWeykT5Qu72 xE/iSSQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:cc:subject:to:references:from:openpgp :autocrypt:organization:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=pBvwc3irEicJbgJxyi9XaXoM3I+NVd/JksIxW7LEVJ0=; b=IEa4uO2FW86uJpTrWhSIv99PzK/QTB8vDt4hABUsntnT2YVBlHxG0+L2qhREOZ2r2D F9yV7sgqb4j/xo20ELg6WMnRKjPoQaPN4PgFwv0n4qrIWrghaZHOj0PCy9WyXgSCE4Zg 84+enyZJKk9TX0vaV35Z2KGw8CEwyZ3my1y+afuDb5X7KOFvB9N3vENG2b7tvuT3Z6PL dZoHsyQhOchBMAx5pWkSGUoqV5TBozSaWh7yW6Kg0dgz9KQTdtPFo/+5j1pFguLisl5V v4IKlkrxnyfGy1EAY1KPj8h2qFj0rphyWdAOWfm2W1nuBV+EL2UHioIVXf0Oe8AV7SFg QrLg== X-Gm-Message-State: APjAAAXaaz9txXv0oaogdy4zvFUNE9bxlkIz1Tn3dSyqDr45EPCyF0eR /Af8dKsG0SM/JIPwprCGB82dv1XtgNBWnUJ6oSeYHMFAbw0EhKhkYDmky1fjEBWb79gglsAS/oT UVEu+LJwUxbM= X-Received: by 2002:a25:9391:: with SMTP id a17mr38031977ybm.392.1564623340732; Wed, 31 Jul 2019 18:35:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwgedIVkhO0z+zH2sw8nrkSI3DkVaneBQ2cbkzgcDC1HyzMumyFujdmqH6CBhcInS3vHbFA5w== X-Received: by 2002:a25:9391:: with SMTP id a17mr38031968ybm.392.1564623340402; Wed, 31 Jul 2019 18:35:40 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=chet.ramey@case.edu; prefer-encrypt=mutual; keydata= mQGiBEEOsGwRBACFa0A1oa71HSZLWxAx0svXzhOZNQZOzqHmSuGOG92jIpQpr8DpvgRh40Yp AwdcXb8QG1J5yGAKeevNE1zCFaA725vGSdHUyypHouV0xoWwukYO6qlyyX+2BZU+okBUqoWQ koWxiYaCSfzB2Ln7pmdys1fJhcgBKf3VjWCjd2XJTwCgoFJOwyBFJdugjfwjSoRSwDOIMf0D /iQKqlWhIO1LGpMrGX0il0/x4zj0NAcSwAk7LaPZbN4UPjn5pqGEHBlf1+xDDQCkAoZ/VqES GZragl4VqJfxBr29Ag0UDvNbUbXoxQsARdero1M8GiAIRc50hj7HXFoERwenbNDJL86GPLAQ OTGOCa4W2o29nFfFjQrsrrYHzVtyA/9oyKvTeEMJ7NA3VJdWcmn7gOu0FxEmSNhSoV1T4vP2 1Wf7f5niCCRKQLNyUy0wEApQi4tSysdz+AbgAc0b/bHYVzIf2uO2lIEZQNNt+3g2bmXgloWm W5fsm/di50Gm1l1Na63d3RZ00SeFQos6WEwLUHEB0yp6KXluXLLIZitEJLQwQ2hldCBSYW1l eSAoQ2FzZSBzdGFuZGFyZCkgPGNoZXQucmFtZXlAY2FzZS5lZHU+iF8EExECAB8FAkPi19EC GwMHCwkIBwMCAQMVAgMDFgIBAh4BAheAAAoJELtYafBk6nSrelkAn31Gsuib7GcCZHbv5L5t VKYR9LklAJ4hzUHKA49Z0QXR+qCb80osIcmPSbkBDQRBDrBvEAQAkK6TAOKBEM+EC4j6V/7o /riVZqcgU5cid2qG9TXdwNtD9a3kvA/ObZBO93sX59wc6Bnwo4VJxsOmMlpGrAjJsxNwg3QH akEtf8LXRbVpj5xStdmBdQZUhIQyalo/2/TZq5OijtddUQcL5cs70hTv/FpT3wUvr2Xr8rjF 41IFEz8AAwcD/A0CZEGlzIrT5WCBnl6xBog/8vKiUCbarByat3d1mL6DbizvKNXQRTC9E/vE dENAWCQCjr75Bu55xT8n3SXGtWdDC5xmZ/P3OBYORP8yl8H8I1FIosWOFirbIeYdZPq8SPD1 HL+EXo9zSiHVrrZRJ19ooCKKbSdXHFCY+aJG+0KZiEkEGBECAAkFAkEOsG8CGwwACgkQu1hp 8GTqdKvjcACfZlkVCDwaz/NTO9cy3t69oWpVPNwAnRwe0qk/WL/gfhH346xh5B3HFbFN User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 In-Reply-To: <1564621048237-0.post@n7.nabble.com> Content-Language: en-US X-Junkmail-Status: score=7/90, host=mpv2-2015.case.edu X-Junkmail-PrAS-Raw: score=7/90, refid=2.7.2:2019.8.1.10016:17:7.944, ip=, rules=__YOUTUBE_RCVD, DKIM_SIGNATURE, __X_GOOGLE_DKIM_SIGNATURE, __HAS_REPLYTO, __HAS_CC_HDR, __SUBJ_REPLY, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __TO_MALFORMED_2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC1, __FROM_DOMAIN_IN_ANY_CC2, __REPLYTO_SAMEAS_FROM_DOMAIN, __DKIM_ALIGNS_1, __DKIM_ALIGNS_2, __ANY_URI, __URI_WITH_PATH, __URI_NO_WWW, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __BODY_NO_MAILTO, __NO_HTML_TAG_RAW, BODY_SIZE_600_699, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_P1, __MIME_TEXT_ONLY, __URI_NS, HTML_00_01, HTML_00_10, DKIM_ALIGNS, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 129.22.103.227 X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: <28da8651-f34e-553b-433a-664c64884ee0@case.edu> X-Mailman-Original-References: <1564586812344-0.post@n7.nabble.com> <1564621048237-0.post@n7.nabble.com> Xref: csiph.com gnu.bash.bug:15288 On 7/31/19 8:57 PM, fireshen wrote: > Yeah, I agree with your opinion, in the branch "if (subshell == 0) ", we have > the function "maybe_restore_getopt_state" to free gs; however, in the branch > "else", it seems like forget to free "gs", or we don't have to free it？ We don't have to free it. If subshell != 0 we are called from a function that executes a function in a subshell environment, and all it does is call exit(). -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/