Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From: Chet Ramey <chet.ramey@case.edu>
Newsgroups: gnu.bash.bug
Subject: Re: Bug when using pipefail and lastpipe together in bash-4.4
Date: Fri, 11 Oct 2019 11:48:36 -0400
Organization: ITS, Case Western Reserve University
Lines: 62
Approved: bug-bash@gnu.org
Message-ID: <mailman.346.1570808927.9715.bug-bash@gnu.org>
References: <CACm1TQebG+cnYuxqFSU7uu29XczQdRiO_M1RW-ne3isZkwbwsg@mail.gmail.com> <940d7783-fea9-08fa-e440-14303c1025e0@case.edu>
Reply-To: chet.ramey@case.edu
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: chet.ramey@case.edu
To: Webstrand <webstrand@gmail.com>, bug-bash@gnu.org
Envelope-to: bug-bash@gnu.org
Openpgp: preference=signencrypt
Autocrypt: addr=chet.ramey@case.edu; prefer-encrypt=mutual; keydata= mQGiBEEOsGwRBACFa0A1oa71HSZLWxAx0svXzhOZNQZOzqHmSuGOG92jIpQpr8DpvgRh40Yp AwdcXb8QG1J5yGAKeevNE1zCFaA725vGSdHUyypHouV0xoWwukYO6qlyyX+2BZU+okBUqoWQ koWxiYaCSfzB2Ln7pmdys1fJhcgBKf3VjWCjd2XJTwCgoFJOwyBFJdugjfwjSoRSwDOIMf0D /iQKqlWhIO1LGpMrGX0il0/x4zj0NAcSwAk7LaPZbN4UPjn5pqGEHBlf1+xDDQCkAoZ/VqES GZragl4VqJfxBr29Ag0UDvNbUbXoxQsARdero1M8GiAIRc50hj7HXFoERwenbNDJL86GPLAQ OTGOCa4W2o29nFfFjQrsrrYHzVtyA/9oyKvTeEMJ7NA3VJdWcmn7gOu0FxEmSNhSoV1T4vP2 1Wf7f5niCCRKQLNyUy0wEApQi4tSysdz+AbgAc0b/bHYVzIf2uO2lIEZQNNt+3g2bmXgloWm W5fsm/di50Gm1l1Na63d3RZ00SeFQos6WEwLUHEB0yp6KXluXLLIZitEJLQwQ2hldCBSYW1l eSAoQ2FzZSBzdGFuZGFyZCkgPGNoZXQucmFtZXlAY2FzZS5lZHU+iF8EExECAB8FAkPi19EC GwMHCwkIBwMCAQMVAgMDFgIBAh4BAheAAAoJELtYafBk6nSrelkAn31Gsuib7GcCZHbv5L5t VKYR9LklAJ4hzUHKA49Z0QXR+qCb80osIcmPSbkBDQRBDrBvEAQAkK6TAOKBEM+EC4j6V/7o /riVZqcgU5cid2qG9TXdwNtD9a3kvA/ObZBO93sX59wc6Bnwo4VJxsOmMlpGrAjJsxNwg3QH akEtf8LXRbVpj5xStdmBdQZUhIQyalo/2/TZq5OijtddUQcL5cs70hTv/FpT3wUvr2Xr8rjF 41IFEz8AAwcD/A0CZEGlzIrT5WCBnl6xBog/8vKiUCbarByat3d1mL6DbizvKNXQRTC9E/vE dENAWCQCjr75Bu55xT8n3SXGtWdDC5xmZ/P3OBYORP8yl8H8I1FIosWOFirbIeYdZPq8SPD1 HL+EXo9zSiHVrrZRJ19ooCKKbSdXHFCY+aJG+0KZiEkEGBECAAkFAkEOsG8CGwwACgkQu1hp 8GTqdKvjcACfZlkVCDwaz/NTO9cy3t69oWpVPNwAnRwe0qk/WL/gfhH346xh5B3HFbFN
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
In-Reply-To: <CACm1TQebG+cnYuxqFSU7uu29XczQdRiO_M1RW-ne3isZkwbwsg@mail.gmail.com>
Content-Language: en-US
Precedence: list
Xref: csiph.com gnu.bash.bug:15498

On 10/8/19 9:43 AM, Webstrand wrote:
> When running the following script under bash-4.4.0 to bash-4.4.23 it
> seems to fail erroneously on read.
> 
>   set -x
>   set -o pipefail
>   shopt -s lastpipe
> 
>   main() {
>     # Any input piped into while such that the condition
>     # succeeds at least once.
>     echo "x" | while read; do
>       echo | read # anything piped to read
>       sleep 0     # any non-builtin
>     done
>   }
> 
>   main || echo "main failed"
> 
> This produces the xtrace:
> 
>   + set -o pipefail
>   + shopt -s lastpipe
>   + main
>   + read
>   + echo x
>   + read
>   + echo
>   + sleep 0
>   + read
>   + echo 'main failed'
>   main failed
> 
> Under bash-4.3 and bash-5.0 the script does not output "main failed",
> as expected.
> 
> I'm not sure if this is a known bug. One user on IRC reported finding
> the same issue on debian stretch, but another could not reproduce the
> issue for bash-4.4.12.
> 
> I have bisected the history of the devel git branch and found that the commit:
>   85ec0778f9d778e1820fb8c0e3e996f2d1103b45 commit bash-20150417 snapshot
> introduces the issue.
> 
> Applying the attached patch to a bash-4.4.23 source tree produces an
> interpreter which does not output "main failed" when running the
> aforementioned script.

It's pretty clear that that patch is not the determining factor, since that
code exists in bash-5.0 and the problem doesn't occur.

The actual fix probably came in in the bash-20180817 snapshot, as a result
of

https://savannah.gnu.org/support/index.php?109541


-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/