Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From: Chet Ramey <chet.ramey@case.edu>
Newsgroups: gnu.bash.bug
Subject: Re: Does bash save/restore terminal settings as required by POSIX job control?
Date: Mon, 22 Jun 2020 17:19:46 -0400
Organization: ITS, Case Western Reserve University
Lines: 47
Approved: bug-bash@gnu.org
Message-ID: <mailman.297.1592860796.2574.bug-bash@gnu.org>
References: <CAB4+JYKZjPPYaNmhLZCDMUhvj9nEfLbaNgX3Q0c+hDHPC2mAew@mail.gmail.com> <fe98cc42-4613-8f30-10c5-66d95a49a6e2@case.edu>
Reply-To: chet.ramey@case.edu
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: chet.ramey@case.edu
To: Godmar Back <godmar@gmail.com>, bug-bash@gnu.org
Envelope-to: bug-bash@gnu.org
Autocrypt: addr=chet.ramey@case.edu; prefer-encrypt=mutual; keydata= mQGiBEEOsGwRBACFa0A1oa71HSZLWxAx0svXzhOZNQZOzqHmSuGOG92jIpQpr8DpvgRh40Yp AwdcXb8QG1J5yGAKeevNE1zCFaA725vGSdHUyypHouV0xoWwukYO6qlyyX+2BZU+okBUqoWQ koWxiYaCSfzB2Ln7pmdys1fJhcgBKf3VjWCjd2XJTwCgoFJOwyBFJdugjfwjSoRSwDOIMf0D /iQKqlWhIO1LGpMrGX0il0/x4zj0NAcSwAk7LaPZbN4UPjn5pqGEHBlf1+xDDQCkAoZ/VqES GZragl4VqJfxBr29Ag0UDvNbUbXoxQsARdero1M8GiAIRc50hj7HXFoERwenbNDJL86GPLAQ OTGOCa4W2o29nFfFjQrsrrYHzVtyA/9oyKvTeEMJ7NA3VJdWcmn7gOu0FxEmSNhSoV1T4vP2 1Wf7f5niCCRKQLNyUy0wEApQi4tSysdz+AbgAc0b/bHYVzIf2uO2lIEZQNNt+3g2bmXgloWm W5fsm/di50Gm1l1Na63d3RZ00SeFQos6WEwLUHEB0yp6KXluXLLIZitEJLQwQ2hldCBSYW1l eSAoQ2FzZSBzdGFuZGFyZCkgPGNoZXQucmFtZXlAY2FzZS5lZHU+iF8EExECAB8FAkPi19EC GwMHCwkIBwMCAQMVAgMDFgIBAh4BAheAAAoJELtYafBk6nSrelkAn31Gsuib7GcCZHbv5L5t VKYR9LklAJ4hzUHKA49Z0QXR+qCb80osIcmPSbkBDQRBDrBvEAQAkK6TAOKBEM+EC4j6V/7o /riVZqcgU5cid2qG9TXdwNtD9a3kvA/ObZBO93sX59wc6Bnwo4VJxsOmMlpGrAjJsxNwg3QH akEtf8LXRbVpj5xStdmBdQZUhIQyalo/2/TZq5OijtddUQcL5cs70hTv/FpT3wUvr2Xr8rjF 41IFEz8AAwcD/A0CZEGlzIrT5WCBnl6xBog/8vKiUCbarByat3d1mL6DbizvKNXQRTC9E/vE dENAWCQCjr75Bu55xT8n3SXGtWdDC5xmZ/P3OBYORP8yl8H8I1FIosWOFirbIeYdZPq8SPD1 HL+EXo9zSiHVrrZRJ19ooCKKbSdXHFCY+aJG+0KZiEkEGBECAAkFAkEOsG8CGwwACgkQu1hp 8GTqdKvjcACfZlkVCDwaz/NTO9cy3t69oWpVPNwAnRwe0qk/WL/gfhH346xh5B3HFbFN
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.9.0
In-Reply-To: <CAB4+JYKZjPPYaNmhLZCDMUhvj9nEfLbaNgX3Q0c+hDHPC2mAew@mail.gmail.com>
Content-Language: en-US
Received-SPF: pass client-ip=129.22.103.194; envelope-from=chet.ramey@case.edu; helo=mpv3-2015.case.edu
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-BeenThere: bug-bash@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-bash>
List-Post: <mailto:bug-bash@gnu.org>
List-Help: <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID: <fe98cc42-4613-8f30-10c5-66d95a49a6e2@case.edu>
X-Mailman-Original-References: <CAB4+JYKZjPPYaNmhLZCDMUhvj9nEfLbaNgX3Q0c+hDHPC2mAew@mail.gmail.com>
Xref: csiph.com gnu.bash.bug:16437

On 6/22/20 4:48 PM, Godmar Back wrote:
> (Disclosure: I performed a search for terminal, terminal settings,
> tcsetattr in the bash-bug mailing list, without finding a discussion.
> My apologies if this is a known issue or was already discussed.)
> 
> Hi,
> 
> according to POSIX Part A, Base Definitions (line 726-728, pg 20, Part
> A: Base Definitions-IEEE and The Open Group.), a job control shell has
> the following responsibility:
> 
> "When a foreground (not background) job stops, the shell must sample
> and remember the current terminal settings so that it can restore them
> later when it continues the stopped job in the foreground (via the
> tcgetattr( ) and tcsetattr( ) functions)."
> 
> Does bash implement this functionality?  If implemented correctly, I
> would expect the program appended below to not fail its assertions.

Nobody does this. What job control shells do is to save the tty state
after a program's successful termination and use that saved state to
restore the tty settings after a program stops or terminates due to a
signal.

> However, it fails - tested with bash 4.4 on CentOS 8 using a pty
> created by sshd.
> I also looked at the bash 5.0 source code and could not spot where
> bash implements this.

You can look at get_tty_state() and set_tty_state() in jobs.c.

> I first noticed this when students in my class's shell project failed
> to properly implement terminal handling, but programs such vi/vim
> still continued to work even when stopped and later placed back in the
> foreground. I discovered that these programs implement a SIGCONT
> handler where they restore their terminal state when continued, but I
> wrote this off as an attempt to be robust in the presence of buggy
> shells. 

This is how programs that modify terminal settings, like editors or
more/less pagers, do things. It's standard behavior.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/