Path: csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!news.glorb.com!usenet.stanford.edu!not-for-mail
From: Christoph Gysin <christoph.gysin@gmail.com>
Newsgroups: gnu.bash.bug
Subject: Re: command substitution is stripping set -e from options
Date: Fri, 2 Oct 2015 15:53:42 +0300
Lines: 23
Approved: bug-bash@gnu.org
Message-ID: <mailman.275.1443791904.16064.bug-bash@gnu.org>
References: <CADex794C1jOf0wrB298_O4ohAqZghYUdd9DJcuaOvV1dCP5AOQ@mail.gmail.com> <560D83DA.9020405@redhat.com> <CADex795r=oqZ7iv4TxrjUn9coDUnu=PgPngkfRWA1f7EZyohfA@mail.gmail.com> <20151002122925.GK25574@eeg.ccf.org>
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: bug-bash@gnu.org
To: Greg Wooledge <wooledg@eeg.ccf.org>
Envelope-to: bug-bash@gnu.org
In-Reply-To: <20151002122925.GK25574@eeg.ccf.org>
Precedence: list
Xref: csiph.com gnu.bash.bug:11575

> Since it's a function, I would recommend return instead of exit.  Also,
> you don't need the $? there.  exit (or return) with no arguments will
> retain the exit status of the previous command.

Yes, $? is not needed.

exit or return is equivalent in this case though because of set -e.

> Putting "|| return" or "|| exit" after all critical commands in your
> script is precisely what you should do.  (Some people write a die()
> function and then use "|| die 'my message'" instead.)

I consider all commands critical, and if one is allowed to return
unsuccessful, I'd rather explicitly allow it with something like:

can_fail || :

I'm still curious as to why set -e is stripped in the first place?

Chris
-- 
echo mailto: NOSPAM !#$.'<*>'|sed 's. ..'|tr "<*> !#:2" org@fr33z3