Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail From: Chet Ramey Newsgroups: gnu.bash.bug Subject: Re: [PATCH 5.1] zread: read files in 4k chunks Date: Mon, 22 Jun 2020 12:35:10 -0400 Organization: ITS, Case Western Reserve University Lines: 21 Approved: bug-bash@gnu.org Message-ID: References: <20200622055328.155106-1-Jason@zx2c4.com> <3cac1f66-697d-396d-3dc8-fc5b621638a4@case.edu> Reply-To: chet.ramey@case.edu NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: usenet.stanford.edu 1592843719 13466 209.51.188.17 (22 Jun 2020 16:35:19 GMT) X-Complaints-To: action@cs.stanford.edu Cc: chet.ramey@case.edu To: "Jason A. Donenfeld" , bug-bash@gnu.org Envelope-to: bug-bash@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1592843714; bh=bjq2avo+5Hx47yT9MCtXjxB/z90+QM4fi6LpVPIUvn4=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=aN6109ra2XTfg0d8rzefduOl5z0/+lHVhiXHW8ZDG99oh7fWizoWV+FcxaWN8rXDf5 EIUS0k862EhcxEc1Jt2N4sAq6/1byOquOgRXJD1T91KrOITEa/x0+BhAIzHwsNoK3YS 8qQYbp+nKGIeaReGI0m40RpbYuxOEUdtRz+rZVXt+9KnLOHmQw/W1HNgpq1xksSG2IQ ZHnvwsFvWkFH1xinGL+mtIgmVYLJbHCnVdj0mXf1tgG/n35TOOji/yhxWQHSMbS9hXY /W3JOhtbp9+pgG+OXWCAUcLbQFNNOZK6lFhhW0zrKDk5/gStdaQKY/S32BIQ2NSUlIj p9JVERwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1592843713; bh=f6EdyVIi7RN2DIIAskwR1HJd/nfX5IijkpvND5b7hvQ=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=LEVyMYngtfu98V/2jtANeR2tK9iXJMO50JKLZLfiBfD+TFdDUd2JTPHdklDNii5+dA Job14QaknUjK7mZkrir4b6Tr4zqJmfzOWKyPCCt5DM27uuMW+J2HGAST8Dycrxf6/9N FiCGCOkCHWE75myP8UK/kaUz3fXT4tKSaq5FAEc5F5AowbyCVB+x2QBaEmfqJ+sWl4o FgSa/7trKPaG/B4FOPf6dgkhI8zyFiK1apbv4R56sng/4JDSbFisTHxgs3XNiANvPSc NfWttyghHpE/vTmaCGYNSlh12pK5jTzvmjTMlKAS2kCpcN7uSYYhH+ncrL5LEQ204ea YL+6SY2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=g-case; h=reply-to:cc:subject:to:references:from:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=f6EdyVIi7RN2DIIAskwR1HJd/nfX5IijkpvND5b7hvQ=; b=X76e2hvK/v1dVZ/Iiitxsd2Iq6MZ1hmcfsPIReAe64K5yqkhewqyxPKEu0I+U6UoxD 2yhE8buRyrUds/diM/o0AxJAI3BVc48pXcznP8fiwaS4cRTn1RLMiirmeIDAvsKERUQB wyIW42rdHeqhCCiZoWkFWP8AuNwO4NqCYHv++dCG3Yh2OqahlX92ilrUP8sDCz9ty7hR XzDdbafYq6Cw98RQNggmX2econkVGoU8SanZpThEB6JBswU6YxbG1jiQ/+b4DepuvdcZ tlQ/IoNWvUyaI4bMUSLmPqwOGaVZ68FLj6TYkYNACqRW1fqXexcthAk8gdp676/6cG2B MpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:cc:subject:to:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=f6EdyVIi7RN2DIIAskwR1HJd/nfX5IijkpvND5b7hvQ=; b=f2OvHhP9tCWQFYSzcd7VOlCDm9ydHPRrRSJz86HQP1JuCx7fT5Yp7FpLe+DLDn4q9T XrodXPkOpRbcotFf4GUrnTW2jJqu4q7DlyJwwZYFUMXiark46um0oX9vpHlE42KYAEzM SrcsWpWq2s1vQSCY5bLYO4BjR1QM/57L/mpEiNHtobd/CluQqurUiNkls9GCab66BnXx 4q3NDDuVnJX1PbzZCyZtm24ZS4t9ieo73/Yg+Btjq/s4iieJ/nLAiOps8uJ1fXdNZV+C X7+kKAmUMUu/BGpHdPSliCRk8NsKUDV7RKQNjoL9arc1CbKHzmCsgCZQy5l7cCb/X5Uz NIdw== X-Gm-Message-State: AOAM530h8wLgu8Vf07L9Eh+zz3k11u170U8FAmn4RMWvZFbO942NL9ur mdSABbyu4PRrYIOIIWt/s40IEXmz0njX2VfXdLMog0Xl89+bW3y4ReYWGNRbYhHKE7psl8EXIo5 jZoTj4qNhRbI= X-Received: by 2002:aed:2462:: with SMTP id s31mr18055393qtc.188.1592843712465; Mon, 22 Jun 2020 09:35:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxe2qtYIomIygRL7iQI6lLw3nj0ZmEm6RxxQ/fiGDmu1TbnjKp2EDignm2p0YYczSN6ArBeiw== X-Received: by 2002:aed:2462:: with SMTP id s31mr18055363qtc.188.1592843712184; Mon, 22 Jun 2020 09:35:12 -0700 (PDT) Autocrypt: addr=chet.ramey@case.edu; prefer-encrypt=mutual; keydata= mQGiBEEOsGwRBACFa0A1oa71HSZLWxAx0svXzhOZNQZOzqHmSuGOG92jIpQpr8DpvgRh40Yp AwdcXb8QG1J5yGAKeevNE1zCFaA725vGSdHUyypHouV0xoWwukYO6qlyyX+2BZU+okBUqoWQ koWxiYaCSfzB2Ln7pmdys1fJhcgBKf3VjWCjd2XJTwCgoFJOwyBFJdugjfwjSoRSwDOIMf0D /iQKqlWhIO1LGpMrGX0il0/x4zj0NAcSwAk7LaPZbN4UPjn5pqGEHBlf1+xDDQCkAoZ/VqES GZragl4VqJfxBr29Ag0UDvNbUbXoxQsARdero1M8GiAIRc50hj7HXFoERwenbNDJL86GPLAQ OTGOCa4W2o29nFfFjQrsrrYHzVtyA/9oyKvTeEMJ7NA3VJdWcmn7gOu0FxEmSNhSoV1T4vP2 1Wf7f5niCCRKQLNyUy0wEApQi4tSysdz+AbgAc0b/bHYVzIf2uO2lIEZQNNt+3g2bmXgloWm W5fsm/di50Gm1l1Na63d3RZ00SeFQos6WEwLUHEB0yp6KXluXLLIZitEJLQwQ2hldCBSYW1l eSAoQ2FzZSBzdGFuZGFyZCkgPGNoZXQucmFtZXlAY2FzZS5lZHU+iF8EExECAB8FAkPi19EC GwMHCwkIBwMCAQMVAgMDFgIBAh4BAheAAAoJELtYafBk6nSrelkAn31Gsuib7GcCZHbv5L5t VKYR9LklAJ4hzUHKA49Z0QXR+qCb80osIcmPSbkBDQRBDrBvEAQAkK6TAOKBEM+EC4j6V/7o /riVZqcgU5cid2qG9TXdwNtD9a3kvA/ObZBO93sX59wc6Bnwo4VJxsOmMlpGrAjJsxNwg3QH akEtf8LXRbVpj5xStdmBdQZUhIQyalo/2/TZq5OijtddUQcL5cs70hTv/FpT3wUvr2Xr8rjF 41IFEz8AAwcD/A0CZEGlzIrT5WCBnl6xBog/8vKiUCbarByat3d1mL6DbizvKNXQRTC9E/vE dENAWCQCjr75Bu55xT8n3SXGtWdDC5xmZ/P3OBYORP8yl8H8I1FIosWOFirbIeYdZPq8SPD1 HL+EXo9zSiHVrrZRJ19ooCKKbSdXHFCY+aJG+0KZiEkEGBECAAkFAkEOsG8CGwwACgkQu1hp 8GTqdKvjcACfZlkVCDwaz/NTO9cy3t69oWpVPNwAnRwe0qk/WL/gfhH346xh5B3HFbFN User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 In-Reply-To: <20200622055328.155106-1-Jason@zx2c4.com> Content-Language: en-US X-Mirapoint-IP-Reputation: reputation=Good-1, source=Queried, refid=tid=0001.0A020302.5EF0CFB5.0018, actions=tag X-Mirapoint-IP-Reputation: reputation=good-1, source=Fixed, refid=n/a, actions=tag X-Junkmail-Status: score=7/80, host=mpv4-2015.case.edu X-Junkmail-PrAS-Raw: score=7/80, refid=2.7.2:2020.6.22.153018:17:7.944, ip=, rules=__YOUTUBE_RCVD, DKIM_SIGNATURE, __X_GOOGLE_DKIM_SIGNATURE, __HAS_REPLYTO, __HAS_CC_HDR, __SUBJ_REPLY, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __SUBJ_ALPHA_END, __TO_MALFORMED_2, __MULTIPLE_RCPTS_TO_X2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC1, __FROM_DOMAIN_IN_ANY_CC2, __REPLYTO_SAMEAS_FROM_DOMAIN, __DKIM_ALIGNS_1, __DKIM_ALIGNS_2, __ANY_URI, __URI_MAILTO, __URI_WITH_PATH, __URI_ENDS_IN_SLASH, __URI_NO_WWW, __CP_URI_IN_BODY, __FRAUD_MONEY_BIG_COIN_DIG, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __MAIL_CHAIN, __BODY_NO_MAILTO, __NO_HTML_TAG_RAW, BODY_SIZE_600_699, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138 Received-SPF: pass client-ip=129.22.103.195; envelope-from=chet.ramey@case.edu; helo=mpv4-2015.case.edu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/22 12:35:13 X-ACL-Warn: Detected OS = Linux 2.4.x-2.6.x [generic] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: <3cac1f66-697d-396d-3dc8-fc5b621638a4@case.edu> X-Mailman-Original-References: <20200622055328.155106-1-Jason@zx2c4.com> Xref: csiph.com gnu.bash.bug:16430 On 6/22/20 1:53 AM, Jason A. Donenfeld wrote: > Currently a static sized buffer is used for reading files. At the moment > it is extremely small, making parsing of large files extremely slow. > Increase this to 4k for improved performance. I bumped it up to 1024 initially for testing. > This also allows reading > files like /dev/kmsg on Linux, which will error if the read buffer is > too small. What is the minimum size for those reads? Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/