Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > gnu.bash.bug > #15244

Re: leaks fd for internal functions but not external command

Path csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail
From Chet Ramey <chet.ramey@case.edu>
Newsgroups gnu.bash.bug
Subject Re: leaks fd for internal functions but not external command
Date Thu, 25 Jul 2019 10:11:24 -0400
Lines 17
Approved bug-bash@gnu.org
Message-ID <mailman.2209.1564063890.2688.bug-bash@gnu.org> (permalink)
References <CAOj-5WDk=8kt=J8wO23giFVWRp5=_GbCNB2HQO87Upc4kkTg+g@mail.gmail.com> <5c34ecd5-c8b2-7000-46bc-1bbe3f71f163@case.edu> <CAOj-5WCFbUoU1x2aUvidT1opUbGeG2jFSaM__ch=SUAfzQbQ9w@mail.gmail.com> <78679ee9-fdaf-5180-d32f-81d92b936538@case.edu> <CAOj-5WBei5KMar7c967=jSwZRsW-Rz-0iL20TQMeuQoz61rfkw@mail.gmail.com> <CAOj-5WA_URW5b7a2EU+rR=T_wbTDEpOM_PSo9yNyU-Dqj+cWaA@mail.gmail.com> <f6acdcca-4c7c-b05c-004d-9b8ceab1e169@case.edu> <CAOj-5WA0b5Lv9GhXkK6gwoS1uVd2B1a0048tZ6sUNnhVHS+ixg@mail.gmail.com> <40109c28-c4a8-2ea0-cc77-e46a584dc011@case.edu> <CAOj-5WBX2h-nwO-u9ocWitmBQ-o=560dJFZw2xLeojNS5ZKs8Q@mail.gmail.com> <38bf161d-8170-69ba-77d0-638aa0852ad9@case.edu> <CAOj-5WAynQLdAJ9y8tWyXAQKpbB8jXujNVvp8VF817Tt=wRgPQ@mail.gmail.com> <7a33daac-16ba-b98a-54ca-e005fd8b041e@case.edu> <CAOj-5WD0jLQN4eX=gf+wqjRAz4YHVw_9wr747-Gh3dsOkNhXjQ@mail.gmail.com> <8761ae1a-f51c-e468-0a32-3447bfa7f287@case.edu> <CAOj-5WBJA_nxhQ=_Y7307darqs2L55mZqCCU8YOvwN64YwkFGQ@mail.gmail.com> <91868af9-f8a6-bbe2-2983-187683ab5a87@case.edu>
Reply-To chet.ramey@case.edu
NNTP-Posting-Host lists.gnu.org
Mime-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Transfer-Encoding 7bit
X-Trace usenet.stanford.edu 1564063890 28903 209.51.188.17 (25 Jul 2019 14:11:30 GMT)
X-Complaints-To action@cs.stanford.edu
Cc chet.ramey@case.edu, bug-bash@gnu.org, bash@packages.debian.org
To Sam Liddicott <sam@liddicott.com>
Envelope-to bug-bash@gnu.org
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1564063886; bh=+tDw0grePhms3G/IPvV1d9lPIgsWdKpsebZkHn8CXdY=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Ou681CF8+ck8/yyR7Xg1r95AMzhgHmfF7xScue6xpCv1CzieAxXBZKLl/8EJUrewMd ocd0E1DNm/JGdSAWGBXFtS0uQRgPZ4lHTGawQv5KGytdz+VYpwAnF1d908anKGzTP3M iPjgYdBeNH5CU0DAk94w9jm3ppigIu8IaDzBbf58VplDA1//SHnjIaDfhewkSWelswW bldyxKEH8Hoj11PDvcaU0vaGXVTyNo+EeLXjQ06vfBVOhMfnpoSwfMdzFVk2Jyhuq2N sgxQBzrJzWr96d7GpIbSsWmN9EqUvyEyv/ICl7QdpD8VRQbEJoDod/V86Ojgj8AKzur j3jTOKGQ==
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1564063885; bh=nP5FAtGK4Z00UWy2Qm8ivRK6hfKLrquKw+DheWQ2RCo=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=fZFu0s0RAptz+av/sdPLhAoKXtnfrn1xXRhun1bzWpvV2tayEWBgHQ38Gjxbh5tm2d leqnsW0escyZO/h0UUHNOdO+FjWEnL/XTd+/7n4ygbxJy9enn4uzGpvaETBiWoOF5Zz 7oH8j73+N1mHEy225yg0wqhrXSSNsZ8h/ProywgJ1guSqLTE6wP+eOFUHuVWxyasJqv LR3hUE4NWmIMLa1cAL9BfMTJ2AaCuH8/m5HDXZfgNuVysFEkTgHu1AqKrmq0svzxQP+ H5d8CZGPsMtj5tT53MN3dD24rHsqP7U4DqpeB3AcxSA/Ip7Ljk+1dxgFn7XsGJqo3Zo aUt/wp4Q==
Openpgp preference=signencrypt
Autocrypt addr=chet.ramey@case.edu; prefer-encrypt=mutual; keydata= xsDiBEEOsGwRBACFa0A1oa71HSZLWxAx0svXzhOZNQZOzqHmSuGOG92jIpQpr8DpvgRh40Yp AwdcXb8QG1J5yGAKeevNE1zCFaA725vGSdHUyypHouV0xoWwukYO6qlyyX+2BZU+okBUqoWQ koWxiYaCSfzB2Ln7pmdys1fJhcgBKf3VjWCjd2XJTwCgoFJOwyBFJdugjfwjSoRSwDOIMf0D /iQKqlWhIO1LGpMrGX0il0/x4zj0NAcSwAk7LaPZbN4UPjn5pqGEHBlf1+xDDQCkAoZ/VqES GZragl4VqJfxBr29Ag0UDvNbUbXoxQsARdero1M8GiAIRc50hj7HXFoERwenbNDJL86GPLAQ OTGOCa4W2o29nFfFjQrsrrYHzVtyA/9oyKvTeEMJ7NA3VJdWcmn7gOu0FxEmSNhSoV1T4vP2 1Wf7f5niCCRKQLNyUy0wEApQi4tSysdz+AbgAc0b/bHYVzIf2uO2lIEZQNNt+3g2bmXgloWm W5fsm/di50Gm1l1Na63d3RZ00SeFQos6WEwLUHEB0yp6KXluXLLIZitEJM0gQ2hldCBSYW1l eSA8Y2hldC5yYW1leUBjYXNlLmVkdT7CYQQTEQIAIQIbAwYLCQgHAwIDFQIDAxYCAQIeAQIX gAUCRX3FIgIZAQAKCRC7WGnwZOp0q069AKCNDRn+zzN/AHbaynls/Lvq1kH/RQCgkLvF8bDs maUHSxSIPqzlGuKWDxbOwE0EQQ6wbxAEAJCukwDigRDPhAuI+lf+6P64lWanIFOXIndqhvU1 3cDbQ/Wt5LwPzm2QTvd7F+fcHOgZ8KOFScbDpjJaRqwIybMTcIN0B2pBLX/C10W1aY+cUrXZ gXUGVISEMmpaP9v02auToo7XXVEHC+XLO9IU7/xaU98FL69l6/K4xeNSBRM/AAMHA/wNAmRB pcyK0+VggZ5esQaIP/LyolAm2qwcmrd3dZi+g24s7yjV0EUwvRP7xHRDQFgkAo6++QbuecU/ J90lxrVnQwucZmfz9zgWDkT/MpfB/CNRSKLFjhYq2yHmHWT6vEjw9Ry/hF6Pc0oh1a62USdf aKAiim0nVxxQmPmiRvtCmcJJBBgRAgAJBQJBDrBvAhsMAAoJELtYafBk6nSr43AAn2ZZFQg8 Gs/zUzvXMt7evaFqVTzcAJ0cHtKpP1i/4H4R9+OsYeQdxxWxTQ==
User-Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
In-Reply-To <CAOj-5WBJA_nxhQ=_Y7307darqs2L55mZqCCU8YOvwN64YwkFGQ@mail.gmail.com>
Content-Language en-US
X-Junkmail-Status score=8/90, host=mpv2-2015.case.edu
X-Junkmail-PrAS-Raw score=8/90, refid=2.7.2:2019.7.25.130016:17:8.317, ip=, rules=DKIM_SIGNATURE, __HAS_REPLYTO, __HAS_CC_HDR, __MULTIPLE_RCPTS_CC_X2, __SUBJ_REPLY, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __SUBJ_ALPHA_END, __TO_MALFORMED_2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __REPLYTO_SAMEAS_FROM_DOMAIN, __DKIM_ALIGNS_1, __DKIM_ALIGNS_2, __ANY_URI, __URI_WITH_PATH, __URI_NO_WWW, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __FORWARDED_MSG, __BODY_NO_MAILTO, __NO_HTML_TAG_RAW, BODY_SIZE_600_699, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_P1, __MIME_TEXT_ONLY, __URI_NS, HTML_00_01, HTML_00_10, DKIM_ALIGNS, BODY_SIZE_5000_LESS, IN_REP_TO, MSG_THREAD, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138
X-detected-operating-system by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]
X-Received-From 129.22.103.227
X-BeenThere bug-bash@gnu.org
X-Mailman-Version 2.1.23
Precedence list
List-Id Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive <https://lists.gnu.org/archive/html/bug-bash>
List-Post <mailto:bug-bash@gnu.org>
List-Help <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID <91868af9-f8a6-bbe2-2983-187683ab5a87@case.edu>
X-Mailman-Original-References <CAOj-5WDk=8kt=J8wO23giFVWRp5=_GbCNB2HQO87Upc4kkTg+g@mail.gmail.com> <5c34ecd5-c8b2-7000-46bc-1bbe3f71f163@case.edu> <CAOj-5WCFbUoU1x2aUvidT1opUbGeG2jFSaM__ch=SUAfzQbQ9w@mail.gmail.com> <78679ee9-fdaf-5180-d32f-81d92b936538@case.edu> <CAOj-5WBei5KMar7c967=jSwZRsW-Rz-0iL20TQMeuQoz61rfkw@mail.gmail.com> <CAOj-5WA_URW5b7a2EU+rR=T_wbTDEpOM_PSo9yNyU-Dqj+cWaA@mail.gmail.com> <f6acdcca-4c7c-b05c-004d-9b8ceab1e169@case.edu> <CAOj-5WA0b5Lv9GhXkK6gwoS1uVd2B1a0048tZ6sUNnhVHS+ixg@mail.gmail.com> <40109c28-c4a8-2ea0-cc77-e46a584dc011@case.edu> <CAOj-5WBX2h-nwO-u9ocWitmBQ-o=560dJFZw2xLeojNS5ZKs8Q@mail.gmail.com> <38bf161d-8170-69ba-77d0-638aa0852ad9@case.edu> <CAOj-5WAynQLdAJ9y8tWyXAQKpbB8jXujNVvp8VF817Tt=wRgPQ@mail.gmail.com> <7a33daac-16ba-b98a-54ca-e005fd8b041e@case.edu> <CAOj-5WD0jLQN4eX=gf+wqjRAz4YHVw_9wr747-Gh3dsOkNhXjQ@mail.gmail.com> <8761ae1a-f51c-e468-0a32-3447bfa7f287@case.edu> <CAOj-5WBJA_nxhQ=_Y7307darqs2L55mZqCCU8YOvwN64YwkFGQ@mail.gmail.com>
Xref csiph.com gnu.bash.bug:15244

Show key headers only | View raw


On 7/25/19 9:03 AM, Sam Liddicott wrote:

> Perhaps if the named fd is also closed on the same statement that opened
> it, it could be kept closed rather than saved and re-opened.
> Being closed at the same statement is a strong indicator that it was only
> used to aid fd transplants. Why keep open what the author closed?

That's an interesting suggestion. I considered it at some point, and
there's even a comment in the code about it. I'll look at it again.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar | Unroll thread


Thread

Re: leaks fd for internal functions but not external command Chet Ramey <chet.ramey@case.edu> - 2019-07-25 10:11 -0400

csiph-web