Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From: Anthony Thyssen <a.thyssen@griffith.edu.au>
Newsgroups: gnu.bash.bug
Subject: Comment before 'else' on CLI, does not save to history correctly
Date: Wed, 24 Jul 2019 01:16:09 +0000
Lines: 48
Approved: bug-bash@gnu.org
Message-ID: <mailman.2123.1563931148.2688.bug-bash@gnu.org>
References: <SYXPR01MB0718DC9728D93D7FBE3A9538B2C60@SYXPR01MB0718.ausprd01.prod.outlook.com>
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
To: "bug-bash@gnu.org" <bug-bash@gnu.org>
Envelope-to: bug-bash@gnu.org
Thread-Topic: Comment before 'else' on CLI, does not save to history correctly
Thread-Index: AQHVQb1NJK2YI+vIOEiPYQ1MdsHmZQ==
Accept-Language: en-AU, en-US
Content-Language: en-AU
X-MS-Exchange-CrossTenant-Network-Message-Id: 6eb945dd-9d64-4a1f-65f8-08d70fd482df
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 01:16:09.8527 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5a7cc8ab-a4dc-4f9b-bf60-66714049ad62
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a.thyssen@griffith.edu.au
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYXPR01MB1616
X-MC-Unique: tmSsSiXkOFiE8_0xStWPrw-1
X-Mimecast-Spam-Score: 0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 180.189.28.112
X-Mailman-Approved-At: Tue, 23 Jul 2019 21:19:07 -0400
X-Content-Filtered-By: Mailman/MimeDel 2.1.23
X-BeenThere: bug-bash@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-bash>
List-Post: <mailto:bug-bash@gnu.org>
List-Help: <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID: <SYXPR01MB0718DC9728D93D7FBE3A9538B2C60@SYXPR01MB0718.ausprd01.prod.outlook.com>
Xref: csiph.com gnu.bash.bug:15221

Version:  bash --version
GNU bash, version 4.4.23(1)-release (x86_64-redhat-linux-gnu)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.htm=
l>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

OS:  Fedora 28,  Running on a Dell Latitude E7450
Standard RPM Package: bash-4.4.23-1.fc28.x86_64


if you type a multi-line if-then-else-fi  statement with a command before t=
he else.
Bash does not add a semi-colon before the else when saving to history.

Type into command line (watch out for no-break-spaces added by mail)...


if true
then echo yes
# comment - required to activate bug
else echo no
fi

this works fine!  outputting "yes"
But if you look at the history

history|grep i\\f|tail -1

Returning...

  830  if true; then echo "yes" else echo "no"; fi

You will see the required ';' before the else is missing.
Meaning if the command is repeated from history it will go wrong.
Producing instead...

yes else echo no

If the comment was not present, the semicolon is added correctly.
Probably effects other muti-line input containing comments too.

Anthony Thyssen,  writing shell script since 1988