Path: csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail
From: George Nachman <gnachman@llamas.org>
Newsgroups: gnu.bash.bug
Subject: Enabling the fix for echo_input_at_read in run_debug_trap?
Date: Sat, 2 May 2020 00:05:04 -0700
Lines: 24
Approved: bug-bash@gnu.org
Message-ID: <mailman.1848.1588425788.3066.bug-bash@gnu.org>
References: <CAB5Rqonp_tv50b7392SjxdjEffgCtQE_i2L1=AsUmnmLehQ3jA@mail.gmail.com>
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
To: bug-bash@gnu.org
Envelope-to: bug-bash@gnu.org
Received-SPF: pass client-ip=2607:f8b0:4864:20::329; envelope-from=gnachman@gmail.com; helo=mail-ot1-x329.google.com
Precedence: list
Xref: csiph.com gnu.bash.bug:16265

One of my users complained that the debug trap was printing their command
after edit-and-execute-command when using my script, which depends on debug
traps. I noticed that bash 5.0 made this change to run_debug_trap() that
would fix the problem:

+      old_verbose = echo_input_at_read;
+#if 0  /* not yet */
+      echo_input_at_read = 0;
+#endif
+
       trap_exit_value = _run_trap_internal (DEBUG_TRAP, "debug trap");

+      echo_input_at_read = old_verbose;

My questions are:
1. Is the #if is ready to be removed yet?
2. If not, what the plans are to make progress on enabling this fix?

I don't see a way to work around it myself, other than not using debug
traps which isn't an option as far as I can tell. I'll help in any way I
can.

Thanks,
George