Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > gnu.bash.bug > #16265

Enabling the fix for echo_input_at_read in run_debug_trap?

Path csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail
From George Nachman <gnachman@llamas.org>
Newsgroups gnu.bash.bug
Subject Enabling the fix for echo_input_at_read in run_debug_trap?
Date Sat, 2 May 2020 00:05:04 -0700
Lines 24
Approved bug-bash@gnu.org
Message-ID <mailman.1848.1588425788.3066.bug-bash@gnu.org> (permalink)
References <CAB5Rqonp_tv50b7392SjxdjEffgCtQE_i2L1=AsUmnmLehQ3jA@mail.gmail.com>
NNTP-Posting-Host lists.gnu.org
Mime-Version 1.0
Content-Type text/plain; charset="UTF-8"
X-Trace usenet.stanford.edu 1588425789 23234 209.51.188.17 (2 May 2020 13:23:09 GMT)
X-Complaints-To action@cs.stanford.edu
To bug-bash@gnu.org
Envelope-to bug-bash@gnu.org
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=llamas-org.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=6cqomRil7Ra45OtKIJb8yTAKWZUmZfgx+1vZxoAHhZQ=; b=fBDcmEslnrz26Z9/Maeif4MGiw/ZVm9G3Btgf/SAbYu45ZiNUYUPSFW8fZLSS74R7S N6xr0FAlEa9XPQxxW4asgY40LcWMuP4H+jpejmIzRYOgDxvDt0xt0FggriHO5a3ddgUW crIwDgDav7AGO3zzjxzjOAARwSKqL89gBGjgiZ6nHU3o1+s2V+jdQSjPM+KVNEKCcMjK shKAjR9HPkjlLoK+xlslFmmEo5ufwmfwC4MAtWiSlT5pfxIMXmGBJKQ+9BT4lETV6x2v 20mMVsSj+xrm37uxE8BqfN1d2DN7m9UTaEYy1PnafqZoXf9dvZlrvW+vH3qcpOQTh6eA 4nBQ==
X-Google-DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=6cqomRil7Ra45OtKIJb8yTAKWZUmZfgx+1vZxoAHhZQ=; b=rs5OKDmt9yddIk5VNIUFPU50vol5NkO0pmjWaAn49+gyZiZasOZbBs47mkG29Clf5Q G1wNvpYt1Abv7JYck6LBwxJ+4NBqFvLp9Ogm+Mh7rN/Dnx2JB8G0NJMQaaVvJUOv/feO pJ0Nm++KepG3WD8MTz/8ytJfYqHkG6BlaVuVBD5j7M7DXwsfaaC3OnyoQIlokKKq+hXA ika/kgQAPRlBnhpdD2UR3tcPkBLMpFQiaMVT4ShKb6gJxatkHoEG3tziv7R2tV54svBV 6HN18rB1ZrXktArOQuRWZGss0oW8L+evM29HCvaUn2KZzsJ2H0GRJTz0dl2tIbsY8CZP 6Y7A==
X-Gm-Message-State AGi0PuZLv/J3RFNhJvFMQSVqko3vzY7ntV0aRcX7uAwCSJ9livRE8elU 6sOSn0ZRwANVIaolEv1RWIIArF7Ru6mFDCK3QtsyHImN1PE=
X-Google-Smtp-Source APiQypL5Ec+7tx0miaqOsk3WTwGDtK0iLIU/St02dA5r/8cQJRJAQdPqS8/YuU/DuW1Ggu0uZk2LqlsWi/UTF8TO1+c=
X-Received by 2002:a05:6830:1e45:: with SMTP id e5mr6451966otj.236.1588403114841; Sat, 02 May 2020 00:05:14 -0700 (PDT)
Received-SPF pass client-ip=2607:f8b0:4864:20::329; envelope-from=gnachman@gmail.com; helo=mail-ot1-x329.google.com
X-detected-operating-system by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67
X-Received-From 2607:f8b0:4864:20::329
X-Mailman-Approved-At Sat, 02 May 2020 09:23:06 -0400
X-Content-Filtered-By Mailman/MimeDel 2.1.23
X-BeenThere bug-bash@gnu.org
X-Mailman-Version 2.1.23
Precedence list
List-Id Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive <https://lists.gnu.org/archive/html/bug-bash>
List-Post <mailto:bug-bash@gnu.org>
List-Help <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID <CAB5Rqonp_tv50b7392SjxdjEffgCtQE_i2L1=AsUmnmLehQ3jA@mail.gmail.com>
Xref csiph.com gnu.bash.bug:16265

Show key headers only | View raw


One of my users complained that the debug trap was printing their command
after edit-and-execute-command when using my script, which depends on debug
traps. I noticed that bash 5.0 made this change to run_debug_trap() that
would fix the problem:

+      old_verbose = echo_input_at_read;
+#if 0  /* not yet */
+      echo_input_at_read = 0;
+#endif
+
       trap_exit_value = _run_trap_internal (DEBUG_TRAP, "debug trap");

+      echo_input_at_read = old_verbose;

My questions are:
1. Is the #if is ready to be removed yet?
2. If not, what the plans are to make progress on enabling this fix?

I don't see a way to work around it myself, other than not using debug
traps which isn't an option as far as I can tell. I'll help in any way I
can.

Thanks,
George

Back to gnu.bash.bug | Previous | Next | Find similar


Thread

Enabling the fix for echo_input_at_read in run_debug_trap? George Nachman <gnachman@llamas.org> - 2020-05-02 00:05 -0700

csiph-web