Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail From: Chet Ramey Newsgroups: gnu.bash.bug Subject: Re: [PATCH] Add nofirstword completion option Date: Tue, 12 Jun 2018 14:54:55 -0400 Lines: 133 Approved: bug-bash@gnu.org Message-ID: References: <20180518110611.5099-1-bluca@debian.org> <96bcb197-40d1-aac8-c214-c513a6db805d@case.edu> <1527068652.6997.5.camel@debian.org> <76b1d3fa-4cb1-3e70-d93c-ada07c04dfa2@case.edu> <1527082457.6997.14.camel@debian.org> <4ccfc554-15a9-2ec1-55e1-b2df687f0bee@case.edu> <1527270167.6997.22.camel@debian.org> <3a98f6c5-0f1e-54aa-491c-da7100430ce8@case.edu> <1527605096.6997.27.camel@debian.org> <1527860403.6997.72.camel@debian.org> <1528468856.6554.6.camel@debian.org> <1528824534.6554.23.camel@debian.org> Reply-To: chet.ramey@case.edu NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6Avll67LFATho6pgvFpYw9TTyaylXpqsr" X-Trace: usenet.stanford.edu 1528829715 18303 208.118.235.17 (12 Jun 2018 18:55:15 GMT) X-Complaints-To: action@cs.stanford.edu Cc: chet.ramey@case.edu To: Luca Boccassi , bug-bash@gnu.org Envelope-to: bug-bash@gnu.org Openpgp: preference=signencrypt Autocrypt: addr=chet.ramey@case.edu; prefer-encrypt=mutual; keydata= xsDiBEEOsGwRBACFa0A1oa71HSZLWxAx0svXzhOZNQZOzqHmSuGOG92jIpQpr8DpvgRh40Yp AwdcXb8QG1J5yGAKeevNE1zCFaA725vGSdHUyypHouV0xoWwukYO6qlyyX+2BZU+okBUqoWQ koWxiYaCSfzB2Ln7pmdys1fJhcgBKf3VjWCjd2XJTwCgoFJOwyBFJdugjfwjSoRSwDOIMf0D /iQKqlWhIO1LGpMrGX0il0/x4zj0NAcSwAk7LaPZbN4UPjn5pqGEHBlf1+xDDQCkAoZ/VqES GZragl4VqJfxBr29Ag0UDvNbUbXoxQsARdero1M8GiAIRc50hj7HXFoERwenbNDJL86GPLAQ OTGOCa4W2o29nFfFjQrsrrYHzVtyA/9oyKvTeEMJ7NA3VJdWcmn7gOu0FxEmSNhSoV1T4vP2 1Wf7f5niCCRKQLNyUy0wEApQi4tSysdz+AbgAc0b/bHYVzIf2uO2lIEZQNNt+3g2bmXgloWm W5fsm/di50Gm1l1Na63d3RZ00SeFQos6WEwLUHEB0yp6KXluXLLIZitEJM0gQ2hldCBSYW1l eSA8Y2hldC5yYW1leUBjYXNlLmVkdT7CYQQTEQIAIQIbAwYLCQgHAwIDFQIDAxYCAQIeAQIX gAUCRX3FIgIZAQAKCRC7WGnwZOp0q069AKCNDRn+zzN/AHbaynls/Lvq1kH/RQCgkLvF8bDs maUHSxSIPqzlGuKWDxbOwE0EQQ6wbxAEAJCukwDigRDPhAuI+lf+6P64lWanIFOXIndqhvU1 3cDbQ/Wt5LwPzm2QTvd7F+fcHOgZ8KOFScbDpjJaRqwIybMTcIN0B2pBLX/C10W1aY+cUrXZ gXUGVISEMmpaP9v02auToo7XXVEHC+XLO9IU7/xaU98FL69l6/K4xeNSBRM/AAMHA/wNAmRB pcyK0+VggZ5esQaIP/LyolAm2qwcmrd3dZi+g24s7yjV0EUwvRP7xHRDQFgkAo6++QbuecU/ J90lxrVnQwucZmfz9zgWDkT/MpfB/CNRSKLFjhYq2yHmHWT6vEjw9Ry/hF6Pc0oh1a62USdf aKAiim0nVxxQmPmiRvtCmcJJBBgRAgAJBQJBDrBvAhsMAAoJELtYafBk6nSr43AAn2ZZFQg8 Gs/zUzvXMt7evaFqVTzcAJ0cHtKpP1i/4H4R9+OsYeQdxxWxTQ== User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 In-Reply-To: <1528824534.6554.23.camel@debian.org> X-Junkmail-Status: score=7/90, host=mpv3-2015.case.edu X-Junkmail-PrAS-Raw: score=7/90, refid=2.7.2:2018.6.12.173616:17:7.944, ip=, rules=__HAS_REPLYTO, __HAS_CC_HDR, __SUBJ_REPLY, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __SUBJ_ALPHA_END, __TO_MALFORMED_2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CTYPE_HAS_BOUNDARY, __CTYPE_MULTIPART, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC1, __FROM_DOMAIN_IN_ANY_CC2, __REPLYTO_SAMEAS_FROM_DOMAIN, __MIME_TEXT_P2, __HAS_ATTACHMENT1, __ANY_URI, __URI_WITH_PATH, __URI_NO_WWW, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __FORWARDED_MSG, __NO_HTML_TAG_RAW, __ATTACHMENT_SIZE_0_10K, __HAS_ATTACHMENT2, BODYTEXTP_SIZE_3000_LESS, BODY_SIZE_5000_5999, __MIME_TEXT_P1, __URI_NS, HTML_00_01, HTML_00_10, IN_REP_TO, MSG_THREAD, __FROM_DOMAIN_IN_RCPT, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-Received-From: 129.22.103.194 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Xref: csiph.com gnu.bash.bug:14234 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6Avll67LFATho6pgvFpYw9TTyaylXpqsr From: Chet Ramey Reply-To: chet.ramey@case.edu To: Luca Boccassi , bug-bash@gnu.org Cc: chet.ramey@case.edu Message-ID: Subject: Re: [PATCH] Add nofirstword completion option References: <20180518110611.5099-1-bluca@debian.org> <96bcb197-40d1-aac8-c214-c513a6db805d@case.edu> <1527068652.6997.5.camel@debian.org> <76b1d3fa-4cb1-3e70-d93c-ada07c04dfa2@case.edu> <1527082457.6997.14.camel@debian.org> <4ccfc554-15a9-2ec1-55e1-b2df687f0bee@case.edu> <1527270167.6997.22.camel@debian.org> <3a98f6c5-0f1e-54aa-491c-da7100430ce8@case.edu> <1527605096.6997.27.camel@debian.org> <1527860403.6997.72.camel@debian.org> <1528468856.6554.6.camel@debian.org> <1528824534.6554.23.camel@debian.org> In-Reply-To: <1528824534.6554.23.camel@debian.org> Content-Type: multipart/mixed; boundary="------------311002D3F361B962180B6F92" --------------311002D3F361B962180B6F92 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 6/12/18 1:28 PM, Luca Boccassi wrote: > On Fri, 2018-06-08 at 11:03 -0400, Chet Ramey wrote: >> On 6/8/18 10:40 AM, Luca Boccassi wrote: >> >>> Any chance you had a sec to look at the diff? Would love some >>> feedback! >> >> I'm going to try and look at it this weekend. It's been a busy couple >> of >> months. >=20 > Hi Chet, >=20 > I've seen that the change is now in the devel branch, thank you so > much! > I also like way more the new option name, definitely clearer :-) >=20 > One difference I noticed with the previous version is that when trying > to complete a command when the line starts with an empty space (eg: to > avoid the history) the initial word programmable completion doesn't > happen. >=20 > It seems to hit the following branch: >=20 > else if (s >=3D e && n[0] =3D=3D '\0' && text[0] =3D=3D '\0' && = start > 0) > { > foundcs =3D 0; /* empty command name following assignments *= / > in_command_position =3D was_assignment; > } >=20 > Given was_assignment is 0, then the programmable completion is later > not attempted. >=20 > Since that branch matches an empty command name, should it perhaps call= > the EMPTYCMD completion? It's not an empty command line, since it starts with point after column 0= =2E It should perform command completion, though. Try the attached patch, or wait for the next devel branch push. Chet --=20 ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/= --------------311002D3F361B962180B6F92 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="command-completion.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="command-completion.patch" KioqIC9mczIvY2hldC9iYXNoL2Jhc2gtMjAxODA2MDgvYmFzaGxpbmUuYwkyMDE4LTA2LTA4 IDE0OjU4OjE0LjAwMDAwMDAwMCAtMDQwMAotLS0gYmFzaGxpbmUuYwkyMDE4LTA2LTEyIDE0 OjQzOjM4LjAwMDAwMDAwMCAtMDQwMAoqKioqKioqKioqKioqKioKKioqIDE1OTMsMTU5OCAq KioqCiAgICAgICAgZWxzZSBpZiAocyA+PSBlICYmIG5bMF0gPT0gJ1wwJyAmJiB0ZXh0WzBd ID09ICdcMCcgJiYgc3RhcnQgPiAwKQogICAgICAgICAgewohICAgICAgICAgICBmb3VuZGNz ID0gMDsJLyogZW1wdHkgY29tbWFuZCBuYW1lIGZvbGxvd2luZyBhc3NpZ25tZW50cyAqLwoh ICAgICAgICAgICBpbl9jb21tYW5kX3Bvc2l0aW9uID0gd2FzX2Fzc2lnbm1lbnQ7CiAgICAg ICAgICB9CiAgICAgICAgZWxzZSBpZiAocyA9PSBzdGFydCAmJiBlID09IGVuZCAmJiBTVFJF USAobiwgdGV4dCkgJiYgc3RhcnQgPiAwKQotLS0gMTU5MywxNTk4IC0tLS0KICAgICAgICBl bHNlIGlmIChzID49IGUgJiYgblswXSA9PSAnXDAnICYmIHRleHRbMF0gPT0gJ1wwJyAmJiBz dGFydCA+IDApCiAgICAgICAgICB7CiEgICAgICAgICAgIGZvdW5kY3MgPSAwOwkvKiBlbXB0 eSBjb21tYW5kIG5hbWUgZm9sbG93aW5nIG9wdGlvbmFsIGFzc2lnbm1lbnRzICovCiEgICAg ICAgICAgIGluX2NvbW1hbmRfcG9zaXRpb24gKz0gd2FzX2Fzc2lnbm1lbnQ7CiAgICAgICAg ICB9CiAgICAgICAgZWxzZSBpZiAocyA9PSBzdGFydCAmJiBlID09IGVuZCAmJiBTVFJFUSAo biwgdGV4dCkgJiYgc3RhcnQgPiAwKQoqKioqKioqKioqKioqKioKKioqIDE2MDYsMTYxMCAq KioqCiAgICAgICAgLyogSWYgd2UgaGF2ZSBkZWZpbmVkIGEgY29tcHNwZWMgZm9yIHRoZSBp bml0aWFsIChjb21tYW5kKSB3b3JkLCBjYWxsCiAgCSBpdCBhbmQgcHJvY2VzcyB0aGUgcmVz dWx0cyBsaWtlIGFueSBvdGhlciBwcm9ncmFtbWFibGUgY29tcGxldGlvbi4gKi8KISAgICAg ICBpZiAoaW5fY29tbWFuZF9wb3NpdGlvbiAmJiBmb3VuZGNzID09IDAgJiYgaXdfY29tcHNw ZWMpCiAgCXByb2dfY29tcGxldGVfbWF0Y2hlcyA9IHByb2dyYW1tYWJsZV9jb21wbGV0aW9u cyAoSU5JVElBTFdPUkQsIHRleHQsIHMsIGUsICZmb3VuZGNzKTsKICAKLS0tIDE2MDYsMTYx MCAtLS0tCiAgICAgICAgLyogSWYgd2UgaGF2ZSBkZWZpbmVkIGEgY29tcHNwZWMgZm9yIHRo ZSBpbml0aWFsIChjb21tYW5kKSB3b3JkLCBjYWxsCiAgCSBpdCBhbmQgcHJvY2VzcyB0aGUg cmVzdWx0cyBsaWtlIGFueSBvdGhlciBwcm9ncmFtbWFibGUgY29tcGxldGlvbi4gKi8KISAg ICAgICBpZiAoaW5fY29tbWFuZF9wb3NpdGlvbiAmJiBoYXZlX3Byb2djb21wcyAmJiBmb3Vu ZGNzID09IDAgJiYgaXdfY29tcHNwZWMpCiAgCXByb2dfY29tcGxldGVfbWF0Y2hlcyA9IHBy b2dyYW1tYWJsZV9jb21wbGV0aW9ucyAoSU5JVElBTFdPUkQsIHRleHQsIHMsIGUsICZmb3Vu ZGNzKTsKICAK --------------311002D3F361B962180B6F92-- --6Avll67LFATho6pgvFpYw9TTyaylXpqsr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQR8ATX7CIqvbGbGULm7WGnwZOp0qwUCWyAXAAAKCRC7WGnwZOp0 q0lVAJ9tFQ0DF428aBhC0o9iKafAsHmMMACdFkuUen4V1mxMgLMKUU77ySNlBig= =dUFV -----END PGP SIGNATURE----- --6Avll67LFATho6pgvFpYw9TTyaylXpqsr--