Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail From: Daniel Colascione Newsgroups: gnu.bash.bug Subject: Re: [PATCH] Add active mark, face support; activate mark on paste Date: Sun, 12 Apr 2020 20:04:03 -0700 Lines: 16 Approved: bug-bash@gnu.org Message-ID: References: <875c423e-0420-78d2-af4b-dfb168432e2d@case.edu> <902c38ef-7534-8f6d-51b7-daa0843b8440@case.edu> <4b6878e3-adb3-50e2-d2b3-c66fe96f57bb@case.edu> <62d418c2-4824-6c78-7f6b-09e2a0300888@case.edu> NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: usenet.stanford.edu 1586747055 7247 209.51.188.17 (13 Apr 2020 03:04:15 GMT) X-Complaints-To: action@cs.stanford.edu Cc: bug-bash@gnu.org To: chet.ramey@case.edu, gentoo_eshoes@tutanota.com Envelope-to: bug-bash@gnu.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gWrFtUvf9zRIckBXBsnzF8OT9OrNHTUze1jKd63JUmU=; b=S8txgpE4OS9yoE6TbEJ5SUHSoY GKR5O9OpR+bFwDkmXkTjYzveOkwBa7dsR1KlXHUpVx0NHj8Dl0nL/I6IHWKhiD2DhZD2pYu1yGWUp /PthkXo6Cr5LfrNVSuxHX2yDPNiZ07JpaKBvBHvhtBi0WidtLmLg6jSxB4I6TXGvv9Q9QacMvPJDm 2KN8ijNHfHqdZeENtfJxM6xqpWDPAYsg5Y5OAwYoLa1Rwr2VzurjU//LplsnK582Hof6NxIAOoH1A tp9fP8C3voi6zGFEjU3aKA5I89A/EImEEPhNZH5CocIeGAjIMU5ZFCnXxN4qUIaW2S/SQm0OouTdb +PagMmYA==; User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 In-Reply-To: <62d418c2-4824-6c78-7f6b-09e2a0300888@case.edu> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Mailman-Original-Message-ID: X-Mailman-Original-References: <875c423e-0420-78d2-af4b-dfb168432e2d@case.edu> <902c38ef-7534-8f6d-51b7-daa0843b8440@case.edu> <4b6878e3-adb3-50e2-d2b3-c66fe96f57bb@case.edu> <62d418c2-4824-6c78-7f6b-09e2a0300888@case.edu> Xref: csiph.com gnu.bash.bug:16128 On 4/12/20 6:23 PM, Chet Ramey wrote: > On 4/12/20 2:15 PM, gentoo_eshoes@tutanota.com wrote: > >> There is one more/different 'face' issue: if I paste a line and then press Enter (as opposed to any alphanumeric key or arrow keys) then the highlight remains(highlighted), possibly because the ^M is echoed and thus moves the cursor one line up(?) before the highlight is attempted to be removed. But I'm just guessing. > > Unsurprising. The highlights are added and removed in readline's redisplay. > Once you enter newline (or any key bound to accept-line), readline returns > the line immediately without any redisplay, so the line remains as is. Is that a regression relative to my original patch? I could have sworn I made command submission deactivate the mark and redisplay, but maybe I'm recalling incorrectly. In any case, isn't that the right thing to do? FWIW, for debugging the kinds of issues we're discussing here, rr(1) is _incredibly_ helpful.