Re: [PATCH] Add active mark, face support; activate mark on paste

From	Daniel Colascione <dancol@dancol.org>
Newsgroups	gnu.bash.bug
Subject	Re: [PATCH] Add active mark, face support; activate mark on paste
Date	2020-04-12 20:04 -0700
Message-ID	<mailman.137.1586747055.3066.bug-bash@gnu.org> (permalink)
References	(4 earlier) <M4glUEn--3-2@tutanota.com> <4b6878e3-adb3-50e2-d2b3-c66fe96f57bb@case.edu> <M4jafDF--3-2@tutanota.com> <62d418c2-4824-6c78-7f6b-09e2a0300888@case.edu> <d74e594c-64a7-e5a8-4136-bacae88a8078@dancol.org>

Show all headers | View raw

On 4/12/20 6:23 PM, Chet Ramey wrote:
> On 4/12/20 2:15 PM, gentoo_eshoes@tutanota.com wrote:
> 
>> There is one more/different 'face' issue: if I paste a line and then press Enter (as opposed to any alphanumeric key or arrow keys) then the highlight remains(highlighted), possibly because the ^M is echoed and thus moves the cursor one line up(?) before the highlight is attempted to be removed. But I'm just guessing.
> 
> Unsurprising. The highlights are added and removed in readline's redisplay.
> Once you enter newline (or any key bound to accept-line), readline returns
> the line immediately without any redisplay, so the line remains as is.

Is that a regression relative to my original patch? I could have sworn I 
made command submission deactivate the mark and redisplay, but maybe I'm 
recalling incorrectly. In any case, isn't that the right thing to do?

FWIW, for debugging the kinds of issues we're discussing here, rr(1) is 
_incredibly_ helpful.

Back to gnu.bash.bug | Previous | Next | Find similar

Thread

Re: [PATCH] Add active mark, face support; activate mark on paste Daniel Colascione <dancol@dancol.org> - 2020-04-12 20:04 -0700

csiph-web