Path: csiph.com!goblin1!goblin.stu.neva.ru!usenet.stanford.edu!not-for-mail
From: Tomas Janousek <tomi@nomi.cz>
Newsgroups: gnu.bash.bug
Subject: Re: History not saved when closing terminal while bash is sourcing a script
Date: Thu, 8 Aug 2019 10:13:35 +0200
Lines: 25
Approved: bug-bash@gnu.org
Message-ID: <mailman.1042.1565252025.1985.bug-bash@gnu.org>
References: <20190803150529.u5lf2tzvgo5sie7m@nomi.cz> <2b96a07b-c679-ea90-a714-056c81ee0c97@case.edu> <20190808081335.vlcr2ele27hoogue@nomi.cz>
NNTP-Posting-Host: lists.gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: bug-bash@gnu.org
To: Chet Ramey <chet.ramey@case.edu>
Envelope-to: bug-bash@gnu.org
Content-Disposition: inline
In-Reply-To: <2b96a07b-c679-ea90-a714-056c81ee0c97@case.edu>
User-Agent: NeoMutt/20180716
Precedence: list
Xref: csiph.com gnu.bash.bug:15309

Hi,

On Sun, Aug 04, 2019 at 01:42:12PM -0400, Chet Ramey wrote:
> On 8/3/19 11:05 AM, Tomas Janousek wrote:
> I don't have or use tmux, but I'm going to guess that `kill-window' sen=
ds
> a SIGHUP to the process group and follows it up with a SIGKILL. The
> `source' turns off saving to history -- the `source' gets saved in the
> history list, not the commands it runs -- and is still running when the
> SIGHUP arrives. The SIGHUP causes the shell to exit without saving the
> history because history is turned off when the signal handler runs.

So this means `source' shouldn't ever be used in interactive shells if on=
e
cares about their shell history, right? I'll file an issue in the Midnigh=
t
Commander bug tracker to use a shell function instead. It might be worth
documenting the behaviour, though, as it is quite suprising -- shell func=
tions
don't need to turn off saving to history, so why should `source'?

--=20
Tom=C3=A1=C5=A1 Janou=C5=A1ek, a.k.a. Pivn=C3=ADk, a.k.a. Liskni_si, http=
://work.lisk.in/