Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!rt.uk.eu.org!newsfeed.xs4all.nl!newsfeed4.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; '+++': 0.03; 'diff': 0.07; 'subject:PEP': 0.07; '+1,5': 0.09; '-0500': 0.09; 'insertion': 0.09; 'lines.': 0.09; 'trailing': 0.09; 'cc:addr:python-list': 0.11; '-1,4': 0.16; '-tkc': 0.16; 'deletion': 0.16; 'finney': 0.16; 'from:addr:python.list': 0.16; 'from:addr:tim.thechases.com': 0.16; 'from:name:tim chase': 0.16; 'merely': 0.16; 'proc': 0.16; 'wrote:': 0.18; 'putting': 0.22; 'cc:addr:python.org': 0.22; '---': 0.24; 'cc:2**0': 0.24; 'cc:no real name:2**0': 0.24; 'subject: : ': 0.26; 'second': 0.26; 'header:In-Reply-To:1': 0.27; 'idea': 0.28; "doesn't": 0.30; 'compared': 0.30; 'easier': 0.31; 'quite': 0.32; 'skip:s 30': 0.35; 'add': 0.35; 'charset:us-ascii': 0.36; 'changing': 0.37; 'clear': 0.37; 'ben': 0.38; 'that,': 0.38; 'anything': 0.39; 'changed': 0.39; 'first': 0.61; 'name': 0.63; 'between': 0.67; 'reads': 0.68; 'inevitable': 0.84; 'received:50.22': 0.84 Date: Tue, 13 May 2014 07:52:06 -0500 From: Tim Chase To: Ben Finney Subject: Re: PEP 8 : Maximum line Length : In-Reply-To: <85mwel985b.fsf@benfinney.id.au> References: <85mwel985b.fsf@benfinney.id.au> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - boston.accountservergroup.com X-AntiAbuse: Original Domain - python.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tim.thechases.com X-Get-Message-Sender-Via: boston.accountservergroup.com: authenticated_id: tim@thechases.com Cc: python-list@python.org X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 57 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1399985555 news.xs4all.nl 2904 [2001:888:2000:d::a6]:37252 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:71480 On 2014-05-13 22:26, Ben Finney wrote: > Changing the name on the first line doesn't entail changing any > other line:: > > proc = Subprocess.Popen( > shlex.split(cmd), > stdout=subprocess.PIPE, > stderr=subprocess.PIPE) > > special_process_map[this_process] = Subprocess.Popen( > shlex.split(cmd), > stdout=subprocess.PIPE, > stderr=subprocess.PIPE) I second the idea of just putting each-of-many-parameters on its own line. Not only that, I also like to tack on trailing commas and put the closing paren on its own line to make diffs easier to read: special_process_map[this_process] = Subprocess.Popen( shlex.split(cmd), stdout=subprocess.PIPE, stderr=subprocess.PIPE, ) so that when I add the inevitable parameter, the diff merely reads like --- tim1.txt 2014-05-13 07:44:42.441754319 -0500 +++ tim2.txt 2014-05-13 07:45:35.753755858 -0500 @@ -2,4 +2,5 @@ shlex.split(cmd), stdout=subprocess.PIPE, stderr=subprocess.PIPE, + bufsize=1024, ) which is quite clear that just one line was added, compared to --- ben1.txt 2014-05-13 07:44:51.033754566 -0500 +++ ben2.txt 2014-05-13 07:45:46.737756176 -0500 @@ -1,4 +1,5 @@ special_process_map[this_process] = Subprocess.Popen( shlex.split(cmd), stdout=subprocess.PIPE, - stderr=subprocess.PIPE) + stderr=subprocess.PIPE, + bufsize=1024) which makes me have to think/verify about whether anything else changed between insertion and deletion of lines. -tkc